Re: [Qemu-devel] [PATCH for-2.5 0/4] vhost: cleanups and switching to sorted memory map

[Igor Mammedov]

On Wed, 12 Aug 2015 10:33:47 +0300
"Michael S. Tsirkin"  wrote:

> On Tue, Jul 28, 2015 at 04:52:49PM +0200, Igor Mammedov wrote:
> > making memory map a sorted array helps to simplify
> > and speed up lookup/insertion and deletion ops on it.
> > It also makes insertion/deteletion code easier to read.
> 
> I'm a bit confused by all the vhost patches you sent.
> Is this series still something you want me to merge?
Yes, I'd like it to be merged.
There is no functional change, it's just self sufficient
cleanups/optimizations and a base for follow up:

patches that try to make initial memory not fragmented
in vhost view assuming that vhost won't use RAM in places
where it's overlapped by other MemoryRegions (PAM/VGA ..etc),
(i.e. borrowing continuous HVA idea).

That would make vhost more migration friendly since
number of entries in its memap will stay constant during
host boot compared to number of entries at startup time.


> Or was it the one that caused memory corruptions with
> mem hotplug?
> 
> > Igor Mammedov (4):
> >   vhost: codding style fix tab indents
> >   vhost: simplify/speedify vhost_dev_assign_memory()
> >   vhost: switch region lookup from linear to bsearch
> >   vhost: simplify/speedify vhost_dev_unassign_memory()
> > 
> >  hw/virtio/vhost.c | 252 
> > ++
> >  1 file changed, 123 insertions(+), 129 deletions(-)
> > 
> > -- 
> > 1.8.3.1

Re: [Qemu-devel] [PATCH for-2.5 0/4] vhost: cleanups and switching to sorted memory map

[Michael S. Tsirkin]

On Tue, Jul 28, 2015 at 04:52:49PM +0200, Igor Mammedov wrote:
 making memory map a sorted array helps to simplify
 and speed up lookup/insertion and deletion ops on it.
 It also makes insertion/deteletion code easier to read.

I'm a bit confused by all the vhost patches you sent.
Is this series still something you want me to merge?
Or was it the one that caused memory corruptions with
mem hotplug?

 Igor Mammedov (4):
   vhost: codding style fix tab indents
   vhost: simplify/speedify vhost_dev_assign_memory()
   vhost: switch region lookup from linear to bsearch
   vhost: simplify/speedify vhost_dev_unassign_memory()
 
  hw/virtio/vhost.c | 252 
 ++
  1 file changed, 123 insertions(+), 129 deletions(-)
 
 -- 
 1.8.3.1

[Qemu-devel] [PATCH for-2.5 0/4] vhost: cleanups and switching to sorted memory map

[Igor Mammedov]

making memory map a sorted array helps to simplify
and speed up lookup/insertion and deletion ops on it.
It also makes insertion/deteletion code easier to read.

Igor Mammedov (4):
  vhost: codding style fix tab indents
  vhost: simplify/speedify vhost_dev_assign_memory()
  vhost: switch region lookup from linear to bsearch
  vhost: simplify/speedify vhost_dev_unassign_memory()

 hw/virtio/vhost.c | 252 ++
 1 file changed, 123 insertions(+), 129 deletions(-)

-- 
1.8.3.1