Re: [Qemu-devel] [PATCH for-3.2 22/41] slirp: remove unused DECLARE_IOVEC
Daniel P. Berrangé, le mer. 14 nov. 2018 13:53:31 +, a ecrit: > On Wed, Nov 14, 2018 at 04:36:24PM +0400, Marc-André Lureau wrote: > > It's actually qemu configure CONFIG_IOVEC that is being used. > > That makes it sound like slirp is using CONFIG_IOVEC, but AFAICT > that's only used by QEMU's osdep code. > > > > > Signed-off-by: Marc-André Lureau > > --- > > slirp/slirp_config.h | 6 -- > > 1 file changed, 6 deletions(-) > > Reviewed-by: Daniel P. Berrangé Applied to my tree, thanks!
Re: [Qemu-devel] [PATCH for-3.2 22/41] slirp: remove unused DECLARE_IOVEC
On Wed, Nov 14, 2018 at 04:36:24PM +0400, Marc-André Lureau wrote: > It's actually qemu configure CONFIG_IOVEC that is being used. That makes it sound like slirp is using CONFIG_IOVEC, but AFAICT that's only used by QEMU's osdep code. > > Signed-off-by: Marc-André Lureau > --- > slirp/slirp_config.h | 6 -- > 1 file changed, 6 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
[Qemu-devel] [PATCH for-3.2 22/41] slirp: remove unused DECLARE_IOVEC
It's actually qemu configure CONFIG_IOVEC that is being used. Signed-off-by: Marc-André Lureau --- slirp/slirp_config.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/slirp/slirp_config.h b/slirp/slirp_config.h index f1ee927c15..833f25a965 100644 --- a/slirp/slirp_config.h +++ b/slirp/slirp_config.h @@ -14,12 +14,6 @@ /* Define if the machine is big endian */ //#undef HOST_WORDS_BIGENDIAN -/* Define if iovec needs to be declared */ -#undef DECLARE_IOVEC -#ifdef _WIN32 -#define DECLARE_IOVEC -#endif - /* Define to sizeof(char *) */ #define SIZEOF_CHAR_P (HOST_LONG_BITS / 8) -- 2.19.1.708.g4ede3d42df
