Re: [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device()
On 04/15/2014 10:51 PM, Markus Armbruster wrote: > Chen Gang writes: > >> On 04/15/2014 04:49 PM, Markus Armbruster wrote: >>> In future submissions, please send the patches in-reply-to the cover >>> letter, not chained together in-reply-to the previous part. Check out >>> git-send-email --no-chain-reply-to. >>> >> >> OK, thanks. But excuse me, I use thunderbird client to send/recv mail >> (not use git send-mail), so not quit understand what you said. And I >> guess what your meaning is: >> >> - start a new thread "[PATH 0/3]..." >> >> - "[PATH 1/3]..." need "reply all" the "[PATH 0/3]..." >> >> - "[PATH 2/3]..." need "reply all" the "[PATH 0/3]..." >> >> - "[PATH 3/3]..." need "reply all" the "[PATH 0/3]..." >> >> If what I guess is incorrect, please let me know, and it will be better >> to provide more detials. > > Sounds okay. But sending with git-send-email is so much easier... > I guess so, too (sending with git-send-email is much easier, which I am not quite familiar). I have already familiar with Thunderbird, and at least now, I am not a maintainer, neither a main patch maker. at present, I have no too many patches to process. So Thunderbird is enough to me. :-) Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed
Re: [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device()
Chen Gang writes: > On 04/15/2014 04:49 PM, Markus Armbruster wrote: >> In future submissions, please send the patches in-reply-to the cover >> letter, not chained together in-reply-to the previous part. Check out >> git-send-email --no-chain-reply-to. >> > > OK, thanks. But excuse me, I use thunderbird client to send/recv mail > (not use git send-mail), so not quit understand what you said. And I > guess what your meaning is: > > - start a new thread "[PATH 0/3]..." > > - "[PATH 1/3]..." need "reply all" the "[PATH 0/3]..." > > - "[PATH 2/3]..." need "reply all" the "[PATH 0/3]..." > > - "[PATH 3/3]..." need "reply all" the "[PATH 0/3]..." > > If what I guess is incorrect, please let me know, and it will be better > to provide more detials. Sounds okay. But sending with git-send-email is so much easier...
Re: [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device()
On 04/15/2014 04:49 PM, Markus Armbruster wrote:
> Chen Gang writes:
>
>> In "vl.c", at least, we can simplify the code below, so can let readers
>> read professional C code (especially for new readers, which often start
>> reading code at main function).
>>
>> - remove useless 'continue' in main().
>>
>> - remove redundant local variable 'res' in get_boot_device().
>>
>> - remove local variable 'args' in the middle of code block in main().
>>
>> The following 3 patches are for the 3 'remove' above.
>>
>> And "vl.c" has a very long function main() which is about 17K lines.
>> Next, it can be split into sub-functions (so can bypass another code
>> style issue: multiple "{...}" styles within "swith(...)").
>>
>>
>> Signed-off-by: Chen Gang
>> ---
>> vl.c | 23 ++-
>> 1 file changed, 10 insertions(+), 13 deletions(-)
>
> In future submissions, please send the patches in-reply-to the cover
> letter, not chained together in-reply-to the previous part. Check out
> git-send-email --no-chain-reply-to.
>
OK, thanks. But excuse me, I use thunderbird client to send/recv mail
(not use git send-mail), so not quit understand what you said. And I
guess what your meaning is:
- start a new thread "[PATH 0/3]..."
- "[PATH 1/3]..." need "reply all" the "[PATH 0/3]..."
- "[PATH 2/3]..." need "reply all" the "[PATH 0/3]..."
- "[PATH 3/3]..." need "reply all" the "[PATH 0/3]..."
If what I guess is incorrect, please let me know, and it will be better
to provide more detials.
Thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
Re: [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device()
Chen Gang writes:
> In "vl.c", at least, we can simplify the code below, so can let readers
> read professional C code (especially for new readers, which often start
> reading code at main function).
>
> - remove useless 'continue' in main().
>
> - remove redundant local variable 'res' in get_boot_device().
>
> - remove local variable 'args' in the middle of code block in main().
>
> The following 3 patches are for the 3 'remove' above.
>
> And "vl.c" has a very long function main() which is about 17K lines.
> Next, it can be split into sub-functions (so can bypass another code
> style issue: multiple "{...}" styles within "swith(...)").
>
>
> Signed-off-by: Chen Gang
> ---
> vl.c | 23 ++-
> 1 file changed, 10 insertions(+), 13 deletions(-)
In future submissions, please send the patches in-reply-to the cover
letter, not chained together in-reply-to the previous part. Check out
git-send-email --no-chain-reply-to.
Re: [Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device()
May any member help to check them?
And next, I shall try to find bug issues (not code style or document
issues), and fix them. Hope I can succeed.
Thanks.
On 04/08/2014 08:00 PM, Chen Gang wrote:
> In "vl.c", at least, we can simplify the code below, so can let readers
> read professional C code (especially for new readers, which often start
> reading code at main function).
>
> - remove useless 'continue' in main().
>
> - remove redundant local variable 'res' in get_boot_device().
>
> - remove local variable 'args' in the middle of code block in main().
>
> The following 3 patches are for the 3 'remove' above.
>
> And "vl.c" has a very long function main() which is about 17K lines.
> Next, it can be split into sub-functions (so can bypass another code
> style issue: multiple "{...}" styles within "swith(...)").
>
>
> Signed-off-by: Chen Gang
> ---
> vl.c | 23 ++-
> 1 file changed, 10 insertions(+), 13 deletions(-)
>
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
[Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device()
In "vl.c", at least, we can simplify the code below, so can let readers
read professional C code (especially for new readers, which often start
reading code at main function).
- remove useless 'continue' in main().
- remove redundant local variable 'res' in get_boot_device().
- remove local variable 'args' in the middle of code block in main().
The following 3 patches are for the 3 'remove' above.
And "vl.c" has a very long function main() which is about 17K lines.
Next, it can be split into sub-functions (so can bypass another code
style issue: multiple "{...}" styles within "swith(...)").
Signed-off-by: Chen Gang
---
vl.c | 23 ++-
1 file changed, 10 insertions(+), 13 deletions(-)
