Re: [Qemu-devel] [PATCH v1 02/19] include/fpu/softfloat: implement float16_abs helper

2017-12-15 Thread Philippe Mathieu-Daudé
On 12/11/2017 09:56 AM, Alex Bennée wrote:
> This will be required when expanding the MINMAX() macro for 16
> bit/half-precision operations.
> 
> Signed-off-by: Alex Bennée 
> Reviewed-by: Richard Henderson 

Reviewed-by: Philippe Mathieu-Daudé 

> ---
>  include/fpu/softfloat.h | 7 +++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/include/fpu/softfloat.h b/include/fpu/softfloat.h
> index d5e99667b6..edf402d422 100644
> --- a/include/fpu/softfloat.h
> +++ b/include/fpu/softfloat.h
> @@ -374,6 +374,13 @@ static inline int float16_is_zero_or_denormal(float16 a)
>  return (float16_val(a) & 0x7c00) == 0;
>  }
>  
> +static inline float16 float16_abs(float16 a)
> +{
> +/* Note that abs does *not* handle NaN specially, nor does
> + * it flush denormal inputs to zero.
> + */
> +return make_float16(float16_val(a) & 0x7fff);
> +}
>  
> /*
>  | The pattern for a default generated half-precision NaN.
>  
> **/
> 



[Qemu-devel] [PATCH v1 02/19] include/fpu/softfloat: implement float16_abs helper

2017-12-11 Thread Alex Bennée
This will be required when expanding the MINMAX() macro for 16
bit/half-precision operations.

Signed-off-by: Alex Bennée 
Reviewed-by: Richard Henderson 
---
 include/fpu/softfloat.h | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/include/fpu/softfloat.h b/include/fpu/softfloat.h
index d5e99667b6..edf402d422 100644
--- a/include/fpu/softfloat.h
+++ b/include/fpu/softfloat.h
@@ -374,6 +374,13 @@ static inline int float16_is_zero_or_denormal(float16 a)
 return (float16_val(a) & 0x7c00) == 0;
 }
 
+static inline float16 float16_abs(float16 a)
+{
+/* Note that abs does *not* handle NaN specially, nor does
+ * it flush denormal inputs to zero.
+ */
+return make_float16(float16_val(a) & 0x7fff);
+}
 /*
 | The pattern for a default generated half-precision NaN.
 **/
-- 
2.15.1