Re: [Qemu-devel] [PATCH v10] msix: rename and create a wrapper

[Markus Armbruster]

Cao jin  writes:

> Rename msix_init to msix_validate_and_init which doesn't assert;
> New a wrapper msix_init to assert programming error.
>
> CC: Alex Williamson 
> CC: Markus Armbruster 
> CC: Marcel Apfelbaum 
> CC: Michael S. Tsirkin 
> Signed-off-by: Cao jin 

Reviewed-by: Markus Armbruster 

[Qemu-devel] [PATCH v10] msix: rename and create a wrapper

[Cao jin]

Rename msix_init to msix_validate_and_init which doesn't assert;
New a wrapper msix_init to assert programming error.

CC: Alex Williamson 
CC: Markus Armbruster 
CC: Marcel Apfelbaum 
CC: Michael S. Tsirkin 
Signed-off-by: Cao jin 
---
revert the modification in msix_init_exclusive_bar()

 hw/pci/msix.c | 23 ++-
 hw/vfio/pci.c | 12 ++--
 include/hw/pci/msix.h |  5 +
 3 files changed, 29 insertions(+), 11 deletions(-)

diff --git a/hw/pci/msix.c b/hw/pci/msix.c
index bb54e8b0ac37..02697de32dfc 100644
--- a/hw/pci/msix.c
+++ b/hw/pci/msix.c
@@ -239,6 +239,19 @@ static void msix_mask_all(struct PCIDevice *dev, unsigned 
nentries)
 }
 }
 
+/* Just a wrapper to check the return value */
+int msix_init(struct PCIDevice *dev, unsigned short nentries,
+  MemoryRegion *table_bar, uint8_t table_bar_nr,
+  unsigned table_offset, MemoryRegion *pba_bar,
+  uint8_t pba_bar_nr, unsigned pba_offset, uint8_t cap_pos,
+  Error **errp)
+{
+int ret = msix_validate_and_init(dev, nentries, table_bar, table_bar_nr,
+table_offset, pba_bar, pba_bar_nr, pba_offset, cap_pos, errp);
+
+assert(ret != -EINVAL);
+return ret;
+}
 /*
  * Make PCI device @dev MSI-X capable
  * @nentries is the max number of MSI-X vectors that the device support.
@@ -259,11 +272,11 @@ static void msix_mask_all(struct PCIDevice *dev, unsigned 
nentries)
  * also means a programming error, except device assignment, which can check
  * if a real HW is broken.
  */
-int msix_init(struct PCIDevice *dev, unsigned short nentries,
-  MemoryRegion *table_bar, uint8_t table_bar_nr,
-  unsigned table_offset, MemoryRegion *pba_bar,
-  uint8_t pba_bar_nr, unsigned pba_offset, uint8_t cap_pos,
-  Error **errp)
+int msix_validate_and_init(struct PCIDevice *dev, unsigned short nentries,
+   MemoryRegion *table_bar, uint8_t table_bar_nr,
+   unsigned table_offset, MemoryRegion *pba_bar,
+   uint8_t pba_bar_nr, unsigned pba_offset,
+   uint8_t cap_pos, Error **errp)
 {
 int cap;
 unsigned table_size, pba_size;
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 332f41d6627f..06828b537a75 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -1436,12 +1436,12 @@ static int vfio_msix_setup(VFIOPCIDevice *vdev, int 
pos, Error **errp)
 
 vdev->msix->pending = g_malloc0(BITS_TO_LONGS(vdev->msix->entries) *
 sizeof(unsigned long));
-ret = msix_init(>pdev, vdev->msix->entries,
-vdev->bars[vdev->msix->table_bar].region.mem,
-vdev->msix->table_bar, vdev->msix->table_offset,
-vdev->bars[vdev->msix->pba_bar].region.mem,
-vdev->msix->pba_bar, vdev->msix->pba_offset, pos,
-);
+ret = msix_validate_and_init(>pdev, vdev->msix->entries,
+ vdev->bars[vdev->msix->table_bar].region.mem,
+ vdev->msix->table_bar, vdev->msix->table_offset,
+ vdev->bars[vdev->msix->pba_bar].region.mem,
+ vdev->msix->pba_bar, vdev->msix->pba_offset, pos,
+ );
 if (ret < 0) {
 if (ret == -ENOTSUP) {
 error_report_err(err);
diff --git a/include/hw/pci/msix.h b/include/hw/pci/msix.h
index 1f27658d352f..815e59bc96f3 100644
--- a/include/hw/pci/msix.h
+++ b/include/hw/pci/msix.h
@@ -11,6 +11,11 @@ int msix_init(PCIDevice *dev, unsigned short nentries,
   unsigned table_offset, MemoryRegion *pba_bar,
   uint8_t pba_bar_nr, unsigned pba_offset, uint8_t cap_pos,
   Error **errp);
+int msix_validate_and_init(PCIDevice *dev, unsigned short nentries,
+   MemoryRegion *table_bar, uint8_t table_bar_nr,
+   unsigned table_offset, MemoryRegion *pba_bar,
+   uint8_t pba_bar_nr, unsigned pba_offset,
+   uint8_t cap_pos, Error **errp);
 int msix_init_exclusive_bar(PCIDevice *dev, unsigned short nentries,
 uint8_t bar_nr, Error **errp);
 
-- 
2.1.0