Re: [Qemu-devel] [PATCH v11 00/13] Dirty bitmaps postcopy migration
* Su Hang (suhan...@mails.ucas.ac.cn) wrote:
>
> Sincerely sorry for my negligence to cause this bug!
> I will fix it as quick as I can!
>
> Sorry again, I'm really ashamed about the mistake I have made.
No need to be ashamed; bugs happen!
Dave
> Su Hang
>
> > -Original Messages-
> > From: "Dr. David Alan Gilbert" <dgilb...@redhat.com>
> > Sent Time: 2018-03-14 04:10:24 (Wednesday)
> > To: "Vladimir Sementsov-Ogievskiy" <vsement...@virtuozzo.com>,
> > suhan...@mails.ucas.ac.cn, ebl...@redhat.com
> > Cc: "peter.mayd...@linaro.org" <peter.mayd...@linaro.org>, "Denis Lunev"
> > <d...@virtuozzo.com>, "qemu-bl...@nongnu.org" <qemu-bl...@nongnu.org>,
> > "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "arm...@redhat.com"
> > <arm...@redhat.com>, "pbonz...@redhat.com" <pbonz...@redhat.com>,
> > "js...@redhat.com" <js...@redhat.com>
> > Subject: Re: [Qemu-devel] [PATCH v11 00/13] Dirty bitmaps postcopy migration
> >
> > * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote:
> > > It looks like a bug in a recent commit to checkpatch. It don't support do
> > > { } while
> >
> > Yes, adding Su Hang and Eric in and trimming some others out.
> > So yes, ignore this patchew failure for this case, but we need to fix
> > that separately.
> >
> > Dave
> >
> > >
> > > Best regards,
> > >
> > > Vladimir.
> > >
> > >
> > > От: no-re...@patchew.org <no-re...@patchew.org>
> > > Отправлено: 13 марта 2018 г. 22:03:29
> > > Кому: Vladimir Sementsov-Ogievskiy
> > > Копия: f...@redhat.com; qemu-bl...@nongnu.org; qemu-devel@nongnu.org;
> > > kw...@redhat.com; peter.mayd...@linaro.org; Vladimir Sementsov-Ogievskiy;
> > > f...@redhat.com; lir...@il.ibm.com; quint...@redhat.com;
> > > js...@redhat.com; arm...@redhat.com; mre...@redhat.com;
> > > stefa...@redhat.com; Denis Lunev; amit.s...@redhat.com;
> > > pbonz...@redhat.com; dgilb...@redhat.com
> > > Тема: Re: [Qemu-devel] [PATCH v11 00/13] Dirty bitmaps postcopy migration
> > >
> > > Hi,
> > >
> > > This series seems to have some coding style problems. See output below for
> > > more information:
> > >
> > > Type: series
> > > Message-id: 20180313180320.339796-1-vsement...@virtuozzo.com
> > > Subject: [Qemu-devel] [PATCH v11 00/13] Dirty bitmaps postcopy migration
> > >
> > > === TEST SCRIPT BEGIN ===
> > > #!/bin/bash
> > >
> > > BASE=base
> > > n=1
> > > total=$(git log --oneline $BASE.. | wc -l)
> > > failed=0
> > >
> > > git config --local diff.renamelimit 0
> > > git config --local diff.renames True
> > > git config --local diff.algorithm histogram
> > >
> > > commits="$(git log --format=%H --reverse $BASE..)"
> > > for c in $commits; do
> > > echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
> > > if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback
> > > -; then
> > > failed=1
> > > echo
> > > fi
> > > n=$((n+1))
> > > done
> > >
> > > exit $failed
> > > === TEST SCRIPT END ===
> > >
> > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> > > From https://github.com/patchew-project/qemu
> > > * [new tag]
> > > patchew/20180313180320.339796-1-vsement...@virtuozzo.com ->
> > > patchew/20180313180320.339796-1-vsement...@virtuozzo.com
> > > Auto packing the repository in background for optimum performance.
> > > See "git help gc" for manual housekeeping.
> > > Switched to a new branch 'test'
> > > 71e03c4ecc iotests: add dirty bitmap postcopy test
> > > daa548f79f iotests: add dirty bitmap migration test
> > > 353c5fdae1 migration: add postcopy migration of dirty bitmaps
> > > 1da07d4ba2 migration: allow qmp command migrate-start-postcopy for any
> > > postcopy
> > > b789a2887e migration: add is_active_iterate handler
> > > 48eb14f856 migration/qemu-file: add qemu_put_counted_string()
> > > 1d6549dae1 migration: include migrate_dirty_bitmaps in migrate_postcopy
> > > e9e40af39a qapi: add dirty-bitmaps migration capability
> > > c575185038 migrati
Re: [Qemu-devel] [PATCH v11 00/13] Dirty bitmaps postcopy migration
Sincerely sorry for my negligence to cause this bug!
I will fix it as quick as I can!
Sorry again, I'm really ashamed about the mistake I have made.
Su Hang
> -Original Messages-
> From: "Dr. David Alan Gilbert" <dgilb...@redhat.com>
> Sent Time: 2018-03-14 04:10:24 (Wednesday)
> To: "Vladimir Sementsov-Ogievskiy" <vsement...@virtuozzo.com>,
> suhan...@mails.ucas.ac.cn, ebl...@redhat.com
> Cc: "peter.mayd...@linaro.org" <peter.mayd...@linaro.org>, "Denis Lunev"
> <d...@virtuozzo.com>, "qemu-bl...@nongnu.org" <qemu-bl...@nongnu.org>,
> "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "arm...@redhat.com"
> <arm...@redhat.com>, "pbonz...@redhat.com" <pbonz...@redhat.com>,
> "js...@redhat.com" <js...@redhat.com>
> Subject: Re: [Qemu-devel] [PATCH v11 00/13] Dirty bitmaps postcopy migration
>
> * Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote:
> > It looks like a bug in a recent commit to checkpatch. It don't support do {
> > } while
>
> Yes, adding Su Hang and Eric in and trimming some others out.
> So yes, ignore this patchew failure for this case, but we need to fix
> that separately.
>
> Dave
>
> >
> > Best regards,
> >
> > Vladimir.
> >
> >
> > От: no-re...@patchew.org <no-re...@patchew.org>
> > Отправлено: 13 марта 2018 г. 22:03:29
> > Кому: Vladimir Sementsov-Ogievskiy
> > Копия: f...@redhat.com; qemu-bl...@nongnu.org; qemu-devel@nongnu.org;
> > kw...@redhat.com; peter.mayd...@linaro.org; Vladimir Sementsov-Ogievskiy;
> > f...@redhat.com; lir...@il.ibm.com; quint...@redhat.com; js...@redhat.com;
> > arm...@redhat.com; mre...@redhat.com; stefa...@redhat.com; Denis Lunev;
> > amit.s...@redhat.com; pbonz...@redhat.com; dgilb...@redhat.com
> > Тема: Re: [Qemu-devel] [PATCH v11 00/13] Dirty bitmaps postcopy migration
> >
> > Hi,
> >
> > This series seems to have some coding style problems. See output below for
> > more information:
> >
> > Type: series
> > Message-id: 20180313180320.339796-1-vsement...@virtuozzo.com
> > Subject: [Qemu-devel] [PATCH v11 00/13] Dirty bitmaps postcopy migration
> >
> > === TEST SCRIPT BEGIN ===
> > #!/bin/bash
> >
> > BASE=base
> > n=1
> > total=$(git log --oneline $BASE.. | wc -l)
> > failed=0
> >
> > git config --local diff.renamelimit 0
> > git config --local diff.renames True
> > git config --local diff.algorithm histogram
> >
> > commits="$(git log --format=%H --reverse $BASE..)"
> > for c in $commits; do
> > echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
> > if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -;
> > then
> > failed=1
> > echo
> > fi
> > n=$((n+1))
> > done
> >
> > exit $failed
> > === TEST SCRIPT END ===
> >
> > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> > From https://github.com/patchew-project/qemu
> > * [new tag]
> > patchew/20180313180320.339796-1-vsement...@virtuozzo.com ->
> > patchew/20180313180320.339796-1-vsement...@virtuozzo.com
> > Auto packing the repository in background for optimum performance.
> > See "git help gc" for manual housekeeping.
> > Switched to a new branch 'test'
> > 71e03c4ecc iotests: add dirty bitmap postcopy test
> > daa548f79f iotests: add dirty bitmap migration test
> > 353c5fdae1 migration: add postcopy migration of dirty bitmaps
> > 1da07d4ba2 migration: allow qmp command migrate-start-postcopy for any
> > postcopy
> > b789a2887e migration: add is_active_iterate handler
> > 48eb14f856 migration/qemu-file: add qemu_put_counted_string()
> > 1d6549dae1 migration: include migrate_dirty_bitmaps in migrate_postcopy
> > e9e40af39a qapi: add dirty-bitmaps migration capability
> > c575185038 migration: introduce postcopy-only pending
> > 7cae35cd7c dirty-bitmap: add locked state
> > 47bbd2a70c block/dirty-bitmap: add _locked version of
> > bdrv_reclaim_dirty_bitmap
> > 870ff1d916 block/dirty-bitmap: fix locking in bdrv_reclaim_dirty_bitmap
> > 5dca3ae226 block/dirty-bitmap: add bdrv_dirty_bitmap_enable_successor()
> >
> > === OUTPUT BEGIN ===
> > Checking PATCH 1/13: block/dirty-bitmap: add
> > bdrv_dirty_bitmap_enable_successor()...
> > Checking PATCH 2/13: block/dirty-bitmap: fix locking in
> > bdrv_reclaim_dirty_b
Re: [Qemu-devel] [PATCH v11 00/13] Dirty bitmaps postcopy migration
* Vladimir Sementsov-Ogievskiy (vsement...@virtuozzo.com) wrote:
> It looks like a bug in a recent commit to checkpatch. It don't support do { }
> while
Yes, adding Su Hang and Eric in and trimming some others out.
So yes, ignore this patchew failure for this case, but we need to fix
that separately.
Dave
>
> Best regards,
>
> Vladimir.
>
>
> От: no-re...@patchew.org <no-re...@patchew.org>
> Отправлено: 13 марта 2018 г. 22:03:29
> Кому: Vladimir Sementsov-Ogievskiy
> Копия: f...@redhat.com; qemu-bl...@nongnu.org; qemu-devel@nongnu.org;
> kw...@redhat.com; peter.mayd...@linaro.org; Vladimir Sementsov-Ogievskiy;
> f...@redhat.com; lir...@il.ibm.com; quint...@redhat.com; js...@redhat.com;
> arm...@redhat.com; mre...@redhat.com; stefa...@redhat.com; Denis Lunev;
> amit.s...@redhat.com; pbonz...@redhat.com; dgilb...@redhat.com
> Тема: Re: [Qemu-devel] [PATCH v11 00/13] Dirty bitmaps postcopy migration
>
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> Type: series
> Message-id: 20180313180320.339796-1-vsement...@virtuozzo.com
> Subject: [Qemu-devel] [PATCH v11 00/13] Dirty bitmaps postcopy migration
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
>
> BASE=base
> n=1
> total=$(git log --oneline $BASE.. | wc -l)
> failed=0
>
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
>
> commits="$(git log --format=%H --reverse $BASE..)"
> for c in $commits; do
> echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
> if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -;
> then
> failed=1
> echo
> fi
> n=$((n+1))
> done
>
> exit $failed
> === TEST SCRIPT END ===
>
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> From https://github.com/patchew-project/qemu
> * [new tag]
> patchew/20180313180320.339796-1-vsement...@virtuozzo.com ->
> patchew/20180313180320.339796-1-vsement...@virtuozzo.com
> Auto packing the repository in background for optimum performance.
> See "git help gc" for manual housekeeping.
> Switched to a new branch 'test'
> 71e03c4ecc iotests: add dirty bitmap postcopy test
> daa548f79f iotests: add dirty bitmap migration test
> 353c5fdae1 migration: add postcopy migration of dirty bitmaps
> 1da07d4ba2 migration: allow qmp command migrate-start-postcopy for any
> postcopy
> b789a2887e migration: add is_active_iterate handler
> 48eb14f856 migration/qemu-file: add qemu_put_counted_string()
> 1d6549dae1 migration: include migrate_dirty_bitmaps in migrate_postcopy
> e9e40af39a qapi: add dirty-bitmaps migration capability
> c575185038 migration: introduce postcopy-only pending
> 7cae35cd7c dirty-bitmap: add locked state
> 47bbd2a70c block/dirty-bitmap: add _locked version of
> bdrv_reclaim_dirty_bitmap
> 870ff1d916 block/dirty-bitmap: fix locking in bdrv_reclaim_dirty_bitmap
> 5dca3ae226 block/dirty-bitmap: add bdrv_dirty_bitmap_enable_successor()
>
> === OUTPUT BEGIN ===
> Checking PATCH 1/13: block/dirty-bitmap: add
> bdrv_dirty_bitmap_enable_successor()...
> Checking PATCH 2/13: block/dirty-bitmap: fix locking in
> bdrv_reclaim_dirty_bitmap...
> Checking PATCH 3/13: block/dirty-bitmap: add _locked version of
> bdrv_reclaim_dirty_bitmap...
> Checking PATCH 4/13: dirty-bitmap: add locked state...
> Checking PATCH 5/13: migration: introduce postcopy-only pending...
> Checking PATCH 6/13: qapi: add dirty-bitmaps migration capability...
> Checking PATCH 7/13: migration: include migrate_dirty_bitmaps in
> migrate_postcopy...
> Checking PATCH 8/13: migration/qemu-file: add qemu_put_counted_string()...
> Checking PATCH 9/13: migration: add is_active_iterate handler...
> Checking PATCH 10/13: migration: allow qmp command migrate-start-postcopy for
> any postcopy...
> Checking PATCH 11/13: migration: add postcopy migration of dirty bitmaps...
> ERROR: braces {} are necessary for all arms of this statement
> #737: FILE: migration/block-dirty-bitmap.c:690:
> +} while (!(s.flags & DIRTY_BITMAP_MIG_FLAG_EOS));
> [...]
>
> total: 1 errors, 0 warnings, 816 lines checked
>
> Your patch has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> Checking PATCH 12/13: iotests: add dirty bitmap migration test...
> Checking PATCH 13/13: iotests: add dirty bitmap postcopy test...
> === OUTPUT END ===
>
> Test command exited with code: 1
>
>
> ---
> Email generated automatically by Patchew [http://patchew.org/].
> Please send your feedback to patchew-de...@freelists.org
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
Re: [Qemu-devel] [PATCH v11 00/13] Dirty bitmaps postcopy migration
On 03/13/2018 03:01 PM, Vladimir Sementsov-Ogievskiy wrote:
It looks like a bug in a recent commit to checkpatch. It don't support do { }
while
Checking PATCH 11/13: migration: add postcopy migration of dirty bitmaps...
ERROR: braces {} are necessary for all arms of this statement
#737: FILE: migration/block-dirty-bitmap.c:690:
+} while (!(s.flags & DIRTY_BITMAP_MIG_FLAG_EOS));
[...]
Indeed, this is a regression in Su Hang's commit 2b9aef6f.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
Re: [Qemu-devel] [PATCH v11 00/13] Dirty bitmaps postcopy migration
It looks like a bug in a recent commit to checkpatch. It don't support do { }
while
Best regards,
Vladimir.
От: no-re...@patchew.org <no-re...@patchew.org>
Отправлено: 13 марта 2018 г. 22:03:29
Кому: Vladimir Sementsov-Ogievskiy
Копия: f...@redhat.com; qemu-bl...@nongnu.org; qemu-devel@nongnu.org;
kw...@redhat.com; peter.mayd...@linaro.org; Vladimir Sementsov-Ogievskiy;
f...@redhat.com; lir...@il.ibm.com; quint...@redhat.com; js...@redhat.com;
arm...@redhat.com; mre...@redhat.com; stefa...@redhat.com; Denis Lunev;
amit.s...@redhat.com; pbonz...@redhat.com; dgilb...@redhat.com
Тема: Re: [Qemu-devel] [PATCH v11 00/13] Dirty bitmaps postcopy migration
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180313180320.339796-1-vsement...@virtuozzo.com
Subject: [Qemu-devel] [PATCH v11 00/13] Dirty bitmaps postcopy migration
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
>From https://github.com/patchew-project/qemu
* [new tag]
patchew/20180313180320.339796-1-vsement...@virtuozzo.com ->
patchew/20180313180320.339796-1-vsement...@virtuozzo.com
Auto packing the repository in background for optimum performance.
See "git help gc" for manual housekeeping.
Switched to a new branch 'test'
71e03c4ecc iotests: add dirty bitmap postcopy test
daa548f79f iotests: add dirty bitmap migration test
353c5fdae1 migration: add postcopy migration of dirty bitmaps
1da07d4ba2 migration: allow qmp command migrate-start-postcopy for any postcopy
b789a2887e migration: add is_active_iterate handler
48eb14f856 migration/qemu-file: add qemu_put_counted_string()
1d6549dae1 migration: include migrate_dirty_bitmaps in migrate_postcopy
e9e40af39a qapi: add dirty-bitmaps migration capability
c575185038 migration: introduce postcopy-only pending
7cae35cd7c dirty-bitmap: add locked state
47bbd2a70c block/dirty-bitmap: add _locked version of bdrv_reclaim_dirty_bitmap
870ff1d916 block/dirty-bitmap: fix locking in bdrv_reclaim_dirty_bitmap
5dca3ae226 block/dirty-bitmap: add bdrv_dirty_bitmap_enable_successor()
=== OUTPUT BEGIN ===
Checking PATCH 1/13: block/dirty-bitmap: add
bdrv_dirty_bitmap_enable_successor()...
Checking PATCH 2/13: block/dirty-bitmap: fix locking in
bdrv_reclaim_dirty_bitmap...
Checking PATCH 3/13: block/dirty-bitmap: add _locked version of
bdrv_reclaim_dirty_bitmap...
Checking PATCH 4/13: dirty-bitmap: add locked state...
Checking PATCH 5/13: migration: introduce postcopy-only pending...
Checking PATCH 6/13: qapi: add dirty-bitmaps migration capability...
Checking PATCH 7/13: migration: include migrate_dirty_bitmaps in
migrate_postcopy...
Checking PATCH 8/13: migration/qemu-file: add qemu_put_counted_string()...
Checking PATCH 9/13: migration: add is_active_iterate handler...
Checking PATCH 10/13: migration: allow qmp command migrate-start-postcopy for
any postcopy...
Checking PATCH 11/13: migration: add postcopy migration of dirty bitmaps...
ERROR: braces {} are necessary for all arms of this statement
#737: FILE: migration/block-dirty-bitmap.c:690:
+} while (!(s.flags & DIRTY_BITMAP_MIG_FLAG_EOS));
[...]
total: 1 errors, 0 warnings, 816 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 12/13: iotests: add dirty bitmap migration test...
Checking PATCH 13/13: iotests: add dirty bitmap postcopy test...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org
Re: [Qemu-devel] [PATCH v11 00/13] Dirty bitmaps postcopy migration
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180313180320.339796-1-vsement...@virtuozzo.com
Subject: [Qemu-devel] [PATCH v11 00/13] Dirty bitmaps postcopy migration
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag]
patchew/20180313180320.339796-1-vsement...@virtuozzo.com ->
patchew/20180313180320.339796-1-vsement...@virtuozzo.com
Auto packing the repository in background for optimum performance.
See "git help gc" for manual housekeeping.
Switched to a new branch 'test'
71e03c4ecc iotests: add dirty bitmap postcopy test
daa548f79f iotests: add dirty bitmap migration test
353c5fdae1 migration: add postcopy migration of dirty bitmaps
1da07d4ba2 migration: allow qmp command migrate-start-postcopy for any postcopy
b789a2887e migration: add is_active_iterate handler
48eb14f856 migration/qemu-file: add qemu_put_counted_string()
1d6549dae1 migration: include migrate_dirty_bitmaps in migrate_postcopy
e9e40af39a qapi: add dirty-bitmaps migration capability
c575185038 migration: introduce postcopy-only pending
7cae35cd7c dirty-bitmap: add locked state
47bbd2a70c block/dirty-bitmap: add _locked version of bdrv_reclaim_dirty_bitmap
870ff1d916 block/dirty-bitmap: fix locking in bdrv_reclaim_dirty_bitmap
5dca3ae226 block/dirty-bitmap: add bdrv_dirty_bitmap_enable_successor()
=== OUTPUT BEGIN ===
Checking PATCH 1/13: block/dirty-bitmap: add
bdrv_dirty_bitmap_enable_successor()...
Checking PATCH 2/13: block/dirty-bitmap: fix locking in
bdrv_reclaim_dirty_bitmap...
Checking PATCH 3/13: block/dirty-bitmap: add _locked version of
bdrv_reclaim_dirty_bitmap...
Checking PATCH 4/13: dirty-bitmap: add locked state...
Checking PATCH 5/13: migration: introduce postcopy-only pending...
Checking PATCH 6/13: qapi: add dirty-bitmaps migration capability...
Checking PATCH 7/13: migration: include migrate_dirty_bitmaps in
migrate_postcopy...
Checking PATCH 8/13: migration/qemu-file: add qemu_put_counted_string()...
Checking PATCH 9/13: migration: add is_active_iterate handler...
Checking PATCH 10/13: migration: allow qmp command migrate-start-postcopy for
any postcopy...
Checking PATCH 11/13: migration: add postcopy migration of dirty bitmaps...
ERROR: braces {} are necessary for all arms of this statement
#737: FILE: migration/block-dirty-bitmap.c:690:
+} while (!(s.flags & DIRTY_BITMAP_MIG_FLAG_EOS));
[...]
total: 1 errors, 0 warnings, 816 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 12/13: iotests: add dirty bitmap migration test...
Checking PATCH 13/13: iotests: add dirty bitmap postcopy test...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org
[Qemu-devel] [PATCH v11 00/13] Dirty bitmaps postcopy migration
Hi all! There is a new version of dirty bitmap postcopy migration series. Patches 01-04 are directly from John's branch https://github.com/jnsnow/qemu/tree/bitmaps , they are included only for patchew. v11 clone: tag postcopy-v11 from https://src.openvz.org/scm/~vsementsov/qemu.git online: https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=postcopy-v11 05: drop inconsistent behavior change, keeping necessity of setting s->start_postcopy 10: new patch. it is needed because of 05 change, we should allow migrate-start-postcopy for dirty-bitmaps too. 11: in dirty_bitmap_load_bits(): - check too large buffer size - check return value of qemu_get_buffer drop "\n" from trace-event 12: - set dirty-bitmap capability for target (only for online case and left a TODO for offline). - move from STOP to MIGRATION event like in 203 13: - drop Fam's r-b - set dirty-bitmap capability for target - move from STOP to MIGRATION event like in 203 - add missed self.assert_qmp after migrate cmd - add call of migrate-start-postcopy (see 05 changes and patch 10) v10 clone: tag postcopy-v10 from https://src.openvz.org/scm/~vsementsov/qemu.git online: https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=postcopy-v10 01,02: r-b Fam 03: adjust comments about locking 04: fixed 124 iotest (was broken because of small mistake in block/dirty-bitmap.c) 05: rebased on master, staff from migration_thread is moved to migration_iteration_run, so drop r-b by John and Juan 06: 2.11->2.12, r-b Fam 07,08,09,: r-b Fam 10: move to device names instead of node names, looks like libvirt don't care about same node-names. flag AUTOLOAD is ignored for now use QEMU_ALIGN_UP and DIV_ROUND_UP skip automatically inserted nodes, when search for dirty bitmaps allow migration of no bitmaps (see in dirty_bitmap_load_header new logic with nothing variable, which avoids extra errors) handle return code of dirty_bitmap_load_header avoid iteration if there are no bitmaps (see new .no_bitmaps field of dirty_bitmap_mig_state) call dirty_bitmap_mig_before_vm_start from process_incoming_migration_bh too, to enable bitmaps in case of postcopy not actually started. 11: not add r-b Fam tiny reorganisation of do_test_migration parameters: remove useless default values and make shared_storage to be the last disable shared storage test for now, until it will be fixed (it will be separate series, more related to qcow2 than to migration) 12: r-b Fam also, "iotests: add default node-name" is dropped, as not more needed. v9 clone: tag postcopy-v9 from https://src.openvz.org/scm/~vsementsov/qemu.git online: https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=postcopy-v9 01: r-b John 02: was incomplete, now add here bdrv_reclaim_dirty_bitmap fix 03: new 04: new 05: r-b John 07: fix type in commit message, r-b John 09: add comment about is_active_iterate, r-b Snow and keep Juan's r-b, hope comment is ok 10: change copyright to Virtuozzo reword comment at the top of the file rewrite init_dirty_bitmap_migration, to not do same things twice (John) and skip _only_ unnamed bitmaps, error out for unnamed nodes (John) use new "locked" state of bitmaps instead of frozen on source vm do not support migrating bitmap to existent one with the same name, keep only create-new-bitmap way break loop in dirty_bitmap_load_complete when bitmap is found use bitmap locking instead of context acquire 12: rewrite, to add more cases. (note, that 169 iotest is also in my "[PATCH v2 0/3] fix bitmaps migration through shared storage", which probably should go to qemu-stable. So this patch should rewrite it, but here I make it like new patch, to simplify review. When "[PATCH v2..." merged I'll rebase this on it), drop r-b 13: move to separate test, drop r-b v8.1 clone: tag postcopy-v8.1 from https://src.openvz.org/scm/~vsementsov/qemu.git online: https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=postcopy-v8.1 05: fix compilation, add new version for cmma_save_pending too. v8 clone: tag postcopy-v8 from https://src.openvz.org/scm/~vsementsov/qemu.git online: https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=postcopy-v8 - rebased on master - patches 01-03 from v7 are already merged to master - patch order is changed to make it possible to merge block/dirty-bitmap patches in separate if is needed 01: new patch 03: fixed to use _locked version of bdrv_release_dirty_bitmap 06: qapi-schema.json -> qapi/migration.json 2.9 -> 2.11 10: protocol changed a bit: instead of 1 byte "bitmap enabled flag" this byte becomes just "flags" and have "enabled", "persistent" and "autoloading" flags inside. also, make all migrated bitmaps to be not persistent (to prevent their storing on source vm) 14: new patch
