Re: [Qemu-devel] [PATCH v12 0/2] Add a generic loader

[Fam Zheng]

On Thu, 09/29 11:25, Markus Armbruster wrote:
> no-re...@ec2-52-6-146-230.compute-1.amazonaws.com writes:
> 
> > Hi,
> >
> > Your series failed automatic build test. Please find the testing commands 
> > and
> > their output below. If you have docker installed, you can probably 
> > reproduce it
> > locally.
> >
> > Type: series
> > Message-id: cover.1475102513.git.alistair.fran...@xilinx.com
> > Subject: [Qemu-devel] [PATCH v12 0/2]  Add a generic loader
> >
> > === TEST SCRIPT BEGIN ===
> > #!/bin/bash
> > set -e
> > git submodule update --init dtc
> > # Let docker tests dump environment info
> > export SHOW_ENV=1
> > make J=8 docker-test-quick@centos6
> > make J=8 docker-test-mingw@fedora
> > === TEST SCRIPT END ===
> >
> > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> > Switched to a new branch 'test'
> > e1a89b7 docs: Add a generic loader explanation document
> > 1826cff generic-loader: Add a generic loader
> >
> > === OUTPUT BEGIN ===
> > Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 
> > 'dtc'
> > Cloning into 'dtc'...
> > Submodule path 'dtc': checked out '65cc4d2748a2c2e6f27f1cf39e07a5dbabd80ebf'
> >   BUILD centos6
> > === OUTPUT END ===
> >
> > Abort: command timeout (>3600 seconds)
> 
> Patchew hiccup or a real problem?

Likely a docker hiccup. The laste line being "BUILD centos6" means the "make
docker-test-quick@centos6" is hung. I don't know much more either. :(

Fam

Re: [Qemu-devel] [PATCH v12 0/2] Add a generic loader

[Alistair Francis]

On Thu, Sep 29, 2016 at 5:09 PM, Alistair Francis
 wrote:
> On Thu, Sep 29, 2016 at 5:00 PM, Peter Maydell  
> wrote:
>> On 29 September 2016 at 02:25, Markus Armbruster  wrote:
>>> Patchew hiccup or a real problem?
>>
>> Looks like a hiccup to me.
>
> Same, it looks like it can't clone dtc.
>
> Thanks,
>
> Alistair
>
>>
>> Can you let me know if you're happy with the new commit messages?
>> If so I'll apply these to target-arm.next.

I just sent out a V13 which include Markus's updates. It doesn't touch
any code, just updated the comments in the c file and re-words the
value passing in the doc.

Thanks,

Alistair

>>
>> thanks
>> -- PMM
>>

Re: [Qemu-devel] [PATCH v12 0/2] Add a generic loader

[Peter Maydell]

On 29 September 2016 at 17:09, Alistair Francis
 wrote:
> On Thu, Sep 29, 2016 at 5:00 PM, Peter Maydell  
> wrote:
>> On 29 September 2016 at 02:25, Markus Armbruster  wrote:
>>> Patchew hiccup or a real problem?
>>
>> Looks like a hiccup to me.
>
> Same, it looks like it can't clone dtc

I think it cloned dtc but then hung after that; either way,
nothing to do with these patches.

-- PMM

Re: [Qemu-devel] [PATCH v12 0/2] Add a generic loader

[Alistair Francis]

On Thu, Sep 29, 2016 at 5:00 PM, Peter Maydell  wrote:
> On 29 September 2016 at 02:25, Markus Armbruster  wrote:
>> Patchew hiccup or a real problem?
>
> Looks like a hiccup to me.

Same, it looks like it can't clone dtc.

Thanks,

Alistair

>
> Can you let me know if you're happy with the new commit messages?
> If so I'll apply these to target-arm.next.
>
> thanks
> -- PMM
>

Re: [Qemu-devel] [PATCH v12 0/2] Add a generic loader

[Peter Maydell]

On 29 September 2016 at 02:25, Markus Armbruster  wrote:
> Patchew hiccup or a real problem?

Looks like a hiccup to me.

Can you let me know if you're happy with the new commit messages?
If so I'll apply these to target-arm.next.

thanks
-- PMM

Re: [Qemu-devel] [PATCH v12 0/2] Add a generic loader

[Markus Armbruster]

no-re...@ec2-52-6-146-230.compute-1.amazonaws.com writes:

> Hi,
>
> Your series failed automatic build test. Please find the testing commands and
> their output below. If you have docker installed, you can probably reproduce 
> it
> locally.
>
> Type: series
> Message-id: cover.1475102513.git.alistair.fran...@xilinx.com
> Subject: [Qemu-devel] [PATCH v12 0/2]  Add a generic loader
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> set -e
> git submodule update --init dtc
> # Let docker tests dump environment info
> export SHOW_ENV=1
> make J=8 docker-test-quick@centos6
> make J=8 docker-test-mingw@fedora
> === TEST SCRIPT END ===
>
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> Switched to a new branch 'test'
> e1a89b7 docs: Add a generic loader explanation document
> 1826cff generic-loader: Add a generic loader
>
> === OUTPUT BEGIN ===
> Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc'
> Cloning into 'dtc'...
> Submodule path 'dtc': checked out '65cc4d2748a2c2e6f27f1cf39e07a5dbabd80ebf'
>   BUILD centos6
> === OUTPUT END ===
>
> Abort: command timeout (>3600 seconds)

Patchew hiccup or a real problem?

Re: [Qemu-devel] [PATCH v12 0/2] Add a generic loader

[no-reply]

Hi,

Your series failed automatic build test. Please find the testing commands and
their output below. If you have docker installed, you can probably reproduce it
locally.

Type: series
Message-id: cover.1475102513.git.alistair.fran...@xilinx.com
Subject: [Qemu-devel] [PATCH v12 0/2]  Add a generic loader

=== TEST SCRIPT BEGIN ===
#!/bin/bash
set -e
git submodule update --init dtc
# Let docker tests dump environment info
export SHOW_ENV=1
make J=8 docker-test-quick@centos6
make J=8 docker-test-mingw@fedora
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
e1a89b7 docs: Add a generic loader explanation document
1826cff generic-loader: Add a generic loader

=== OUTPUT BEGIN ===
Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '65cc4d2748a2c2e6f27f1cf39e07a5dbabd80ebf'
  BUILD centos6
=== OUTPUT END ===

Abort: command timeout (>3600 seconds)


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org

[Qemu-devel] [PATCH v12 0/2] Add a generic loader

[Alistair Francis]

This work is based on the original work by Li Guang with extra
features added by Peter C and myself.

The idea of this loader is to allow the user to load multiple images
or values into QEMU at startup.

Memory values can be loaded like this: -device 
loader,addr=0xfd1a0104,data=0x800e,data-len=4

Images can be loaded like this: -device loader,file=./images/u-boot.elf,cpu=0

This can be useful and we use it a lot in Xilinx to load multiple images
into a machine at creation (ATF, Kernel and DTB for example).

Tested with the latest Xilinx ZynqMP machine, if I enable EL3 and EL2 I can
boot ATF through to u-boot using the loader to load the images.

It can also be used to set registers.

This patch series makes the load_elf() function more generic by not
requiring an architecture. It also adds new functions load_elf_as(),
load_uimage_as and load_image_targphys_as which allows custom
AddressSpaces when loading images.

V12:
 - All patches have been reviewed
 - Most patches have been merged
 - The commit message of the actual device patch has been updated to
   justify why it is a device.


Alistair Francis (2):
  generic-loader: Add a generic loader
  docs: Add a generic loader explanation document

 MAINTAINERS  |   6 ++
 docs/generic-loader.txt  |  81 
 hw/core/Makefile.objs|   2 +
 hw/core/generic-loader.c | 197 +++
 include/hw/core/generic-loader.h |  46 +
 5 files changed, 332 insertions(+)
 create mode 100644 docs/generic-loader.txt
 create mode 100644 hw/core/generic-loader.c
 create mode 100644 include/hw/core/generic-loader.h

-- 
2.7.4