Re: [Qemu-devel] [PATCH v19 0/2] virtio-crypto: virtio crypto device specification
On 2017/9/8 12:31, Michael S. Tsirkin wrote: > On Fri, Sep 08, 2017 at 12:22:01PM +0800, Longpeng (Mike) wrote: >> >> >> On 2017/9/8 11:49, Michael S. Tsirkin wrote: >> >>> On Fri, Sep 01, 2017 at 08:47:28AM +0800, Longpeng (Mike) wrote: Ping... Stefan, Halil, do you have any suggestion ? >>> >>> I do not see this patchset in the virtio list archives. >>> It could be that youa re posting from an email that is >>> not a subscriber. >>> >>> Please subscribe and repost. >>> >> >> >> OK, I'll subscribe and repost after I complete the implementation based on >> the >> v19 :) > > To clarify does not existing device in qemu work according to > this spec? We need to make the spec compatible with what's > out there in the field somehow (feature bit?). Yep, the spec is compatible with the existing device in QEMU by a feature bit(VIRTIO_CRYPTO_F_MUX_MODE). > >>> We'll then have to allow up to 2 weeks for comments. >>> >>> Halil, I hope this timing works for you. >>> -- Regards, Longpeng(Mike) On 2017/8/26 15:53, Longpeng(Mike) wrote: > Hi guys, > > I'll work on the virtio-crypto spec with Gonglei together, Because He is > so busy on the inner production project. > > --- > v19 -> v18: > - fix some typos and grammar fixes [Stefan, Halil] > - rename VIRTIO_CRYPTO_F_STATELESS_MODE to VIRTIO_CRYPTO_F_MUX_MODE > - describe the VIRTIO_CRYPTO_STATUS in detial. [Halil] > - refactor and redescribe the controlq/dataq request's format >of mux mode. [Halil] > - other small fixes. [Halil] > > v18 -> v17: > - fix many English grammar problems suggested by Stefan, Thanks a lot! > > v17 -> v16: > - Some grammar fixes [Stefan, Halil, Michael] > - add a section named "Supported crypto services" in order to explain bit >numbers and valuse clearly. [Halil, Cornelia] > - avoid word reptition [Halil] > - rename non-session mode to stateless mode [Halil] > - change descriptions for all elements in struct virtio_crypto_config > [Halil] > - add Halil as a reviewer in the ackonwledgement part, thanks for his > work. > - other fixes here and there. > > Changes since v15: > - use feature bits for non-session mode in order to keep compatibility > with >pre-existing code. [Halil & Michael] > - introduce VIRTIO_CRYPTO_F_ NON_SESSION_MODE feature bit to control all > other >non-session mode feature bits. > - fix some typos. [Stefan] > - introduce struct virtio_crypto_op_data_req_mux to support both session >and non-session based crypto operations and keep compatibility with >pre-existing code. > > Changes since v14: > - drop VIRTIO_CRYPTO_S_STARTED status [Halil & Cornelia] > - correct a sentence about dataqueue and controlq in the first > paragraph. > [Halil] > - change a MAY to MUST about max_dataqueues. [Halil] > - add non-session mode support >a) add four features for different crypto services to identify > wheather > support session mode. >b) rewrite some > > For pervious versions of virtio crypto spec, Pls see: > > [v18]: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg444897.html > > [v14]: > https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg02212.html > > [v13]: > https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07348.html > > For more information, please see: > http://qemu-project.org/Features/VirtioCrypto > > --- > Gonglei (2): > virtio-crypto: Add virtio crypto device specification > virtio-crypto: Add conformance clauses > > acknowledgements.tex |3 + > conformance.tex | 29 + > content.tex |2 + > virtio-crypto.tex| 1470 > ++ > 4 files changed, 1504 insertions(+) > create mode 100644 virtio-crypto.tex > -- Regards, Longpeng(Mike) >>> >>> . >>> >> >> >> -- >> Regards, >> Longpeng(Mike) > > . > -- Regards, Longpeng(Mike)
Re: [Qemu-devel] [PATCH v19 0/2] virtio-crypto: virtio crypto device specification
On Fri, Sep 08, 2017 at 12:22:01PM +0800, Longpeng (Mike) wrote: > > > On 2017/9/8 11:49, Michael S. Tsirkin wrote: > > > On Fri, Sep 01, 2017 at 08:47:28AM +0800, Longpeng (Mike) wrote: > >> Ping... > >> > >> Stefan, Halil, do you have any suggestion ? > > > > I do not see this patchset in the virtio list archives. > > It could be that youa re posting from an email that is > > not a subscriber. > > > > Please subscribe and repost. > > > > > OK, I'll subscribe and repost after I complete the implementation based on the > v19 :) To clarify does not existing device in qemu work according to this spec? We need to make the spec compatible with what's out there in the field somehow (feature bit?). > > We'll then have to allow up to 2 weeks for comments. > > > > Halil, I hope this timing works for you. > > > >> -- > >> Regards, > >> Longpeng(Mike) > >> > >> On 2017/8/26 15:53, Longpeng(Mike) wrote: > >> > >>> Hi guys, > >>> > >>> I'll work on the virtio-crypto spec with Gonglei together, Because He is > >>> so busy on the inner production project. > >>> > >>> --- > >>> v19 -> v18: > >>> - fix some typos and grammar fixes [Stefan, Halil] > >>> - rename VIRTIO_CRYPTO_F_STATELESS_MODE to VIRTIO_CRYPTO_F_MUX_MODE > >>> - describe the VIRTIO_CRYPTO_STATUS in detial. [Halil] > >>> - refactor and redescribe the controlq/dataq request's format > >>>of mux mode. [Halil] > >>> - other small fixes. [Halil] > >>> > >>> v18 -> v17: > >>> - fix many English grammar problems suggested by Stefan, Thanks a lot! > >>> > >>> v17 -> v16: > >>> - Some grammar fixes [Stefan, Halil, Michael] > >>> - add a section named "Supported crypto services" in order to explain bit > >>>numbers and valuse clearly. [Halil, Cornelia] > >>> - avoid word reptition [Halil] > >>> - rename non-session mode to stateless mode [Halil] > >>> - change descriptions for all elements in struct virtio_crypto_config > >>> [Halil] > >>> - add Halil as a reviewer in the ackonwledgement part, thanks for his > >>> work. > >>> - other fixes here and there. > >>> > >>> Changes since v15: > >>> - use feature bits for non-session mode in order to keep compatibility > >>> with > >>>pre-existing code. [Halil & Michael] > >>> - introduce VIRTIO_CRYPTO_F_ NON_SESSION_MODE feature bit to control all > >>> other > >>>non-session mode feature bits. > >>> - fix some typos. [Stefan] > >>> - introduce struct virtio_crypto_op_data_req_mux to support both session > >>>and non-session based crypto operations and keep compatibility with > >>>pre-existing code. > >>> > >>> Changes since v14: > >>> - drop VIRTIO_CRYPTO_S_STARTED status [Halil & Cornelia] > >>> - correct a sentence about dataqueue and controlq in the first > >>> paragraph. > >>> [Halil] > >>> - change a MAY to MUST about max_dataqueues. [Halil] > >>> - add non-session mode support > >>>a) add four features for different crypto services to identify > >>> wheather > >>> support session mode. > >>>b) rewrite some > >>> > >>> For pervious versions of virtio crypto spec, Pls see: > >>> > >>> [v18]: > >>> https://www.mail-archive.com/qemu-devel@nongnu.org/msg444897.html > >>> > >>> [v14]: > >>> https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg02212.html > >>> > >>> [v13]: > >>> https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07348.html > >>> > >>> For more information, please see: > >>> http://qemu-project.org/Features/VirtioCrypto > >>> > >>> --- > >>> Gonglei (2): > >>> virtio-crypto: Add virtio crypto device specification > >>> virtio-crypto: Add conformance clauses > >>> > >>> acknowledgements.tex |3 + > >>> conformance.tex | 29 + > >>> content.tex |2 + > >>> virtio-crypto.tex| 1470 > >>> ++ > >>> 4 files changed, 1504 insertions(+) > >>> create mode 100644 virtio-crypto.tex > >>> > >> > >> > >> -- > >> Regards, > >> Longpeng(Mike) > > > > . > > > > > -- > Regards, > Longpeng(Mike)
Re: [Qemu-devel] [PATCH v19 0/2] virtio-crypto: virtio crypto device specification
On 2017/9/8 11:49, Michael S. Tsirkin wrote: > On Fri, Sep 01, 2017 at 08:47:28AM +0800, Longpeng (Mike) wrote: >> Ping... >> >> Stefan, Halil, do you have any suggestion ? > > I do not see this patchset in the virtio list archives. > It could be that youa re posting from an email that is > not a subscriber. > > Please subscribe and repost. > OK, I'll subscribe and repost after I complete the implementation based on the v19 :) > We'll then have to allow up to 2 weeks for comments. > > Halil, I hope this timing works for you. > >> -- >> Regards, >> Longpeng(Mike) >> >> On 2017/8/26 15:53, Longpeng(Mike) wrote: >> >>> Hi guys, >>> >>> I'll work on the virtio-crypto spec with Gonglei together, Because He is >>> so busy on the inner production project. >>> >>> --- >>> v19 -> v18: >>> - fix some typos and grammar fixes [Stefan, Halil] >>> - rename VIRTIO_CRYPTO_F_STATELESS_MODE to VIRTIO_CRYPTO_F_MUX_MODE >>> - describe the VIRTIO_CRYPTO_STATUS in detial. [Halil] >>> - refactor and redescribe the controlq/dataq request's format >>>of mux mode. [Halil] >>> - other small fixes. [Halil] >>> >>> v18 -> v17: >>> - fix many English grammar problems suggested by Stefan, Thanks a lot! >>> >>> v17 -> v16: >>> - Some grammar fixes [Stefan, Halil, Michael] >>> - add a section named "Supported crypto services" in order to explain bit >>>numbers and valuse clearly. [Halil, Cornelia] >>> - avoid word reptition [Halil] >>> - rename non-session mode to stateless mode [Halil] >>> - change descriptions for all elements in struct virtio_crypto_config >>> [Halil] >>> - add Halil as a reviewer in the ackonwledgement part, thanks for his work. >>> - other fixes here and there. >>> >>> Changes since v15: >>> - use feature bits for non-session mode in order to keep compatibility with >>>pre-existing code. [Halil & Michael] >>> - introduce VIRTIO_CRYPTO_F_ NON_SESSION_MODE feature bit to control all >>> other >>>non-session mode feature bits. >>> - fix some typos. [Stefan] >>> - introduce struct virtio_crypto_op_data_req_mux to support both session >>>and non-session based crypto operations and keep compatibility with >>>pre-existing code. >>> >>> Changes since v14: >>> - drop VIRTIO_CRYPTO_S_STARTED status [Halil & Cornelia] >>> - correct a sentence about dataqueue and controlq in the first paragraph. >>> [Halil] >>> - change a MAY to MUST about max_dataqueues. [Halil] >>> - add non-session mode support >>>a) add four features for different crypto services to identify wheather >>> support session mode. >>>b) rewrite some >>> >>> For pervious versions of virtio crypto spec, Pls see: >>> >>> [v18]: >>> https://www.mail-archive.com/qemu-devel@nongnu.org/msg444897.html >>> >>> [v14]: >>> https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg02212.html >>> >>> [v13]: >>> https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07348.html >>> >>> For more information, please see: >>> http://qemu-project.org/Features/VirtioCrypto >>> >>> --- >>> Gonglei (2): >>> virtio-crypto: Add virtio crypto device specification >>> virtio-crypto: Add conformance clauses >>> >>> acknowledgements.tex |3 + >>> conformance.tex | 29 + >>> content.tex |2 + >>> virtio-crypto.tex| 1470 >>> ++ >>> 4 files changed, 1504 insertions(+) >>> create mode 100644 virtio-crypto.tex >>> >> >> >> -- >> Regards, >> Longpeng(Mike) > > . > -- Regards, Longpeng(Mike)
Re: [Qemu-devel] [PATCH v19 0/2] virtio-crypto: virtio crypto device specification
On Fri, Sep 01, 2017 at 08:47:28AM +0800, Longpeng (Mike) wrote: > Ping... > > Stefan, Halil, do you have any suggestion ? I do not see this patchset in the virtio list archives. It could be that youa re posting from an email that is not a subscriber. Please subscribe and repost. We'll then have to allow up to 2 weeks for comments. Halil, I hope this timing works for you. > -- > Regards, > Longpeng(Mike) > > On 2017/8/26 15:53, Longpeng(Mike) wrote: > > > Hi guys, > > > > I'll work on the virtio-crypto spec with Gonglei together, Because He is > > so busy on the inner production project. > > > > --- > > v19 -> v18: > > - fix some typos and grammar fixes [Stefan, Halil] > > - rename VIRTIO_CRYPTO_F_STATELESS_MODE to VIRTIO_CRYPTO_F_MUX_MODE > > - describe the VIRTIO_CRYPTO_STATUS in detial. [Halil] > > - refactor and redescribe the controlq/dataq request's format > >of mux mode. [Halil] > > - other small fixes. [Halil] > > > > v18 -> v17: > > - fix many English grammar problems suggested by Stefan, Thanks a lot! > > > > v17 -> v16: > > - Some grammar fixes [Stefan, Halil, Michael] > > - add a section named "Supported crypto services" in order to explain bit > >numbers and valuse clearly. [Halil, Cornelia] > > - avoid word reptition [Halil] > > - rename non-session mode to stateless mode [Halil] > > - change descriptions for all elements in struct virtio_crypto_config > > [Halil] > > - add Halil as a reviewer in the ackonwledgement part, thanks for his work. > > - other fixes here and there. > > > > Changes since v15: > > - use feature bits for non-session mode in order to keep compatibility with > >pre-existing code. [Halil & Michael] > > - introduce VIRTIO_CRYPTO_F_ NON_SESSION_MODE feature bit to control all > > other > >non-session mode feature bits. > > - fix some typos. [Stefan] > > - introduce struct virtio_crypto_op_data_req_mux to support both session > >and non-session based crypto operations and keep compatibility with > >pre-existing code. > > > > Changes since v14: > > - drop VIRTIO_CRYPTO_S_STARTED status [Halil & Cornelia] > > - correct a sentence about dataqueue and controlq in the first paragraph. > > [Halil] > > - change a MAY to MUST about max_dataqueues. [Halil] > > - add non-session mode support > >a) add four features for different crypto services to identify wheather > > support session mode. > >b) rewrite some > > > > For pervious versions of virtio crypto spec, Pls see: > > > > [v18]: > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg444897.html > > > > [v14]: > > https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg02212.html > > > > [v13]: > > https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07348.html > > > > For more information, please see: > > http://qemu-project.org/Features/VirtioCrypto > > > > --- > > Gonglei (2): > > virtio-crypto: Add virtio crypto device specification > > virtio-crypto: Add conformance clauses > > > > acknowledgements.tex |3 + > > conformance.tex | 29 + > > content.tex |2 + > > virtio-crypto.tex| 1470 > > ++ > > 4 files changed, 1504 insertions(+) > > create mode 100644 virtio-crypto.tex > > > > > -- > Regards, > Longpeng(Mike)
Re: [Qemu-devel] [PATCH v19 0/2] virtio-crypto: virtio crypto device specification
Hi Halil, On 2017/9/1 19:45, Halil Pasic wrote: > > > On 09/01/2017 02:47 AM, Longpeng (Mike) wrote: >> Ping... >> >> Stefan, Halil, do you have any suggestion ? >> > > Hi Longpeng, > > I've ran trough your patch, and it reads much better that > what I recall v18 used to read like. Because it's been a while > since v18 doing a conscious review on this will take a considerable > amount of time (my memories of the issues identified back then > are very sketchy/vague now). It's on my todo list, but it ain't the > only item there. > That's great, thanks :) > Btw. I like to have a reference implementation at hand when reviewing > a spec. What is the status of the (reference) implementation (I mean > the new stuff like stateless/mux)? I think it would be nice to provide > this info in the cover letter (e.g. next time, should we need another > iteration). > OK, I'll send a reference implementation based on the v19 spec next week. > Regards, > Halil > > > . > -- Regards, Longpeng(Mike)
Re: [Qemu-devel] [PATCH v19 0/2] virtio-crypto: virtio crypto device specification
On 09/01/2017 02:47 AM, Longpeng (Mike) wrote: > Ping... > > Stefan, Halil, do you have any suggestion ? > Hi Longpeng, I've ran trough your patch, and it reads much better that what I recall v18 used to read like. Because it's been a while since v18 doing a conscious review on this will take a considerable amount of time (my memories of the issues identified back then are very sketchy/vague now). It's on my todo list, but it ain't the only item there. Btw. I like to have a reference implementation at hand when reviewing a spec. What is the status of the (reference) implementation (I mean the new stuff like stateless/mux)? I think it would be nice to provide this info in the cover letter (e.g. next time, should we need another iteration). Regards, Halil
Re: [Qemu-devel] [PATCH v19 0/2] virtio-crypto: virtio crypto device specification
Ping... Stefan, Halil, do you have any suggestion ? -- Regards, Longpeng(Mike) On 2017/8/26 15:53, Longpeng(Mike) wrote: > Hi guys, > > I'll work on the virtio-crypto spec with Gonglei together, Because He is > so busy on the inner production project. > > --- > v19 -> v18: > - fix some typos and grammar fixes [Stefan, Halil] > - rename VIRTIO_CRYPTO_F_STATELESS_MODE to VIRTIO_CRYPTO_F_MUX_MODE > - describe the VIRTIO_CRYPTO_STATUS in detial. [Halil] > - refactor and redescribe the controlq/dataq request's format >of mux mode. [Halil] > - other small fixes. [Halil] > > v18 -> v17: > - fix many English grammar problems suggested by Stefan, Thanks a lot! > > v17 -> v16: > - Some grammar fixes [Stefan, Halil, Michael] > - add a section named "Supported crypto services" in order to explain bit >numbers and valuse clearly. [Halil, Cornelia] > - avoid word reptition [Halil] > - rename non-session mode to stateless mode [Halil] > - change descriptions for all elements in struct virtio_crypto_config [Halil] > - add Halil as a reviewer in the ackonwledgement part, thanks for his work. > - other fixes here and there. > > Changes since v15: > - use feature bits for non-session mode in order to keep compatibility with >pre-existing code. [Halil & Michael] > - introduce VIRTIO_CRYPTO_F_ NON_SESSION_MODE feature bit to control all > other >non-session mode feature bits. > - fix some typos. [Stefan] > - introduce struct virtio_crypto_op_data_req_mux to support both session >and non-session based crypto operations and keep compatibility with >pre-existing code. > > Changes since v14: > - drop VIRTIO_CRYPTO_S_STARTED status [Halil & Cornelia] > - correct a sentence about dataqueue and controlq in the first paragraph. > [Halil] > - change a MAY to MUST about max_dataqueues. [Halil] > - add non-session mode support >a) add four features for different crypto services to identify wheather > support session mode. >b) rewrite some > > For pervious versions of virtio crypto spec, Pls see: > > [v18]: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg444897.html > > [v14]: > https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg02212.html > > [v13]: > https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07348.html > > For more information, please see: > http://qemu-project.org/Features/VirtioCrypto > > --- > Gonglei (2): > virtio-crypto: Add virtio crypto device specification > virtio-crypto: Add conformance clauses > > acknowledgements.tex |3 + > conformance.tex | 29 + > content.tex |2 + > virtio-crypto.tex| 1470 > ++ > 4 files changed, 1504 insertions(+) > create mode 100644 virtio-crypto.tex > -- Regards, Longpeng(Mike)
[Qemu-devel] [PATCH v19 0/2] virtio-crypto: virtio crypto device specification
Hi guys, I'll work on the virtio-crypto spec with Gonglei together, Because He is so busy on the inner production project. --- v19 -> v18: - fix some typos and grammar fixes [Stefan, Halil] - rename VIRTIO_CRYPTO_F_STATELESS_MODE to VIRTIO_CRYPTO_F_MUX_MODE - describe the VIRTIO_CRYPTO_STATUS in detial. [Halil] - refactor and redescribe the controlq/dataq request's format of mux mode. [Halil] - other small fixes. [Halil] v18 -> v17: - fix many English grammar problems suggested by Stefan, Thanks a lot! v17 -> v16: - Some grammar fixes [Stefan, Halil, Michael] - add a section named "Supported crypto services" in order to explain bit numbers and valuse clearly. [Halil, Cornelia] - avoid word reptition [Halil] - rename non-session mode to stateless mode [Halil] - change descriptions for all elements in struct virtio_crypto_config [Halil] - add Halil as a reviewer in the ackonwledgement part, thanks for his work. - other fixes here and there. Changes since v15: - use feature bits for non-session mode in order to keep compatibility with pre-existing code. [Halil & Michael] - introduce VIRTIO_CRYPTO_F_ NON_SESSION_MODE feature bit to control all other non-session mode feature bits. - fix some typos. [Stefan] - introduce struct virtio_crypto_op_data_req_mux to support both session and non-session based crypto operations and keep compatibility with pre-existing code. Changes since v14: - drop VIRTIO_CRYPTO_S_STARTED status [Halil & Cornelia] - correct a sentence about dataqueue and controlq in the first paragraph. [Halil] - change a MAY to MUST about max_dataqueues. [Halil] - add non-session mode support a) add four features for different crypto services to identify wheather support session mode. b) rewrite some For pervious versions of virtio crypto spec, Pls see: [v18]: https://www.mail-archive.com/qemu-devel@nongnu.org/msg444897.html [v14]: https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg02212.html [v13]: https://lists.gnu.org/archive/html/qemu-devel/2016-10/msg07348.html For more information, please see: http://qemu-project.org/Features/VirtioCrypto --- Gonglei (2): virtio-crypto: Add virtio crypto device specification virtio-crypto: Add conformance clauses acknowledgements.tex |3 + conformance.tex | 29 + content.tex |2 + virtio-crypto.tex| 1470 ++ 4 files changed, 1504 insertions(+) create mode 100644 virtio-crypto.tex -- 2.7.4
