Re: [Qemu-devel] [PATCH v2 0/2] block: warn about aio=native if libaio is unavailable
On Thu, Jul 23, 2015 at 10:03:32AM +0200, Markus Armbruster wrote: Stefan Hajnoczi stefa...@redhat.com writes: v2: * Banish CONFIG_LINUX_AIO from blockdev.c, that is raw-posix.c's business [Kevin] * Print the warning in the same way as the aio=native,cache.direct=off deprecation warning [Kevin] Open question: what about the Windows case? We now pass the FILE_FLAG_OVERLAPPED flag which we didn't do before for -drive aio=native. Odd. Commit a273652 takes the trouble to implement native asynchronous I/O there, but unless CONFIG_LINUX_AIO somehow gets defined, it's unreachable, isn't it? Paolo? I think PATCH 2's commit message needs to be updated to discuss the impact. Nice find! I'll send a v2. pgpzWITsrPE9t.pgp Description: PGP signature
Re: [Qemu-devel] [PATCH v2 0/2] block: warn about aio=native if libaio is unavailable
On 23/07/2015 10:03, Markus Armbruster wrote: v2: * Banish CONFIG_LINUX_AIO from blockdev.c, that is raw-posix.c's business [Kevin] * Print the warning in the same way as the aio=native,cache.direct=off deprecation warning [Kevin] Open question: what about the Windows case? We now pass the FILE_FLAG_OVERLAPPED flag which we didn't do before for -drive aio=native. Odd. Commit a273652 takes the trouble to implement native asynchronous I/O there, but unless CONFIG_LINUX_AIO somehow gets defined, it's unreachable, isn't it? Paolo? I don't remember how I tested that code, but it's probably been dead code since it was committed. If it's bitrot and thus these patches break it, I will fix it. Paolo I think PATCH 2's commit message needs to be updated to discuss the impact.
Re: [Qemu-devel] [PATCH v2 0/2] block: warn about aio=native if libaio is unavailable
Am 23.07.2015 um 10:08 hat Paolo Bonzini geschrieben: On 23/07/2015 10:03, Markus Armbruster wrote: v2: * Banish CONFIG_LINUX_AIO from blockdev.c, that is raw-posix.c's business [Kevin] * Print the warning in the same way as the aio=native,cache.direct=off deprecation warning [Kevin] Open question: what about the Windows case? We now pass the FILE_FLAG_OVERLAPPED flag which we didn't do before for -drive aio=native. Odd. Commit a273652 takes the trouble to implement native asynchronous I/O there, but unless CONFIG_LINUX_AIO somehow gets defined, it's unreachable, isn't it? Paolo? I don't remember how I tested that code, but it's probably been dead code since it was committed. If it's bitrot and thus these patches break it, I will fix it. The tools use a different path, so qemu-img/io would have correctly used AIO on Windows. Kevin
Re: [Qemu-devel] [PATCH v2 0/2] block: warn about aio=native if libaio is unavailable
Stefan Hajnoczi stefa...@redhat.com writes: v2: * Banish CONFIG_LINUX_AIO from blockdev.c, that is raw-posix.c's business [Kevin] * Print the warning in the same way as the aio=native,cache.direct=off deprecation warning [Kevin] Open question: what about the Windows case? We now pass the FILE_FLAG_OVERLAPPED flag which we didn't do before for -drive aio=native. Odd. Commit a273652 takes the trouble to implement native asynchronous I/O there, but unless CONFIG_LINUX_AIO somehow gets defined, it's unreachable, isn't it? Paolo? I think PATCH 2's commit message needs to be updated to discuss the impact.
[Qemu-devel] [PATCH v2 0/2] block: warn about aio=native if libaio is unavailable
v2: * Banish CONFIG_LINUX_AIO from blockdev.c, that is raw-posix.c's business [Kevin] * Print the warning in the same way as the aio=native,cache.direct=off deprecation warning [Kevin] Open question: what about the Windows case? We now pass the FILE_FLAG_OVERLAPPED flag which we didn't do before for -drive aio=native. Stefan Hajnoczi (2): raw-posix: warn about BDRV_O_NATIVE_AIO if libaio is unavailable blockdev: always compile in -drive aio= parsing block/raw-posix.c | 11 ++- blockdev.c| 2 -- 2 files changed, 10 insertions(+), 3 deletions(-) -- 2.4.3
