Re: [Qemu-devel] [PATCH v2 0/2] qga umask fix addenda
On Sun, May 12, 2013 at 06:47:05PM +0200, Andreas Färber wrote: Am 10.05.2013 22:09, schrieb mdroth: On Fri, May 10, 2013 at 09:53:27PM +0200, Laszlo Ersek wrote: On 05/10/13 21:30, mdroth wrote: On Wed, May 08, 2013 at 05:31:34PM +0200, Laszlo Ersek wrote: I should have paid more attention to portability and error path cleanup in the CVE-2013-2007 fix. (We continue to assume, like the rest of qemu code, that qemu_set_cloexec() never fails internally. This should be a reasonable assumption when the input fd is valid.) Laszlo Ersek (2): qga: distinguish binary modes in guest_file_open_modes map qga: unlink just created guest-file if fchmod() or fdopen() fails on it Thanks, applied to qga branch: https://github.com/mdroth/qemu/commits/qga Thanks! Can you reword the second commit to include Eric's R-b? http://lists.nongnu.org/archive/html/qemu-devel/2013-05/msg01179.html Sure, missed that one. Should be fixed in tree now. Shouldn't at least the unlinking be backported to stable as well? Yes, these are basically updates to the CVE fix, so I think they should all be applied to stable. I'll send PULL today so hopefully we can get them into 1.5 prior to patch freeze for 1.4.2. Otherwise I'll backport from the qga tree. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
Re: [Qemu-devel] [PATCH v2 0/2] qga umask fix addenda
Am 10.05.2013 22:09, schrieb mdroth: On Fri, May 10, 2013 at 09:53:27PM +0200, Laszlo Ersek wrote: On 05/10/13 21:30, mdroth wrote: On Wed, May 08, 2013 at 05:31:34PM +0200, Laszlo Ersek wrote: I should have paid more attention to portability and error path cleanup in the CVE-2013-2007 fix. (We continue to assume, like the rest of qemu code, that qemu_set_cloexec() never fails internally. This should be a reasonable assumption when the input fd is valid.) Laszlo Ersek (2): qga: distinguish binary modes in guest_file_open_modes map qga: unlink just created guest-file if fchmod() or fdopen() fails on it Thanks, applied to qga branch: https://github.com/mdroth/qemu/commits/qga Thanks! Can you reword the second commit to include Eric's R-b? http://lists.nongnu.org/archive/html/qemu-devel/2013-05/msg01179.html Sure, missed that one. Should be fixed in tree now. Shouldn't at least the unlinking be backported to stable as well? Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
Re: [Qemu-devel] [PATCH v2 0/2] qga umask fix addenda
On Wed, 8 May 2013 17:31:34 +0200 Laszlo Ersek ler...@redhat.com wrote: I should have paid more attention to portability and error path cleanup in the CVE-2013-2007 fix. (We continue to assume, like the rest of qemu code, that qemu_set_cloexec() never fails internally. This should be a reasonable assumption when the input fd is valid.) Series: Reviewed-by: Luiz Capitulino lcapitul...@redhat.com Laszlo Ersek (2): qga: distinguish binary modes in guest_file_open_modes map qga: unlink just created guest-file if fchmod() or fdopen() fails on it qga/commands-posix.c | 25 +++-- 1 files changed, 19 insertions(+), 6 deletions(-)
Re: [Qemu-devel] [PATCH v2 0/2] qga umask fix addenda
On Wed, May 08, 2013 at 05:31:34PM +0200, Laszlo Ersek wrote: I should have paid more attention to portability and error path cleanup in the CVE-2013-2007 fix. (We continue to assume, like the rest of qemu code, that qemu_set_cloexec() never fails internally. This should be a reasonable assumption when the input fd is valid.) Laszlo Ersek (2): qga: distinguish binary modes in guest_file_open_modes map qga: unlink just created guest-file if fchmod() or fdopen() fails on it Thanks, applied to qga branch: https://github.com/mdroth/qemu/commits/qga qga/commands-posix.c | 25 +++-- 1 files changed, 19 insertions(+), 6 deletions(-)
Re: [Qemu-devel] [PATCH v2 0/2] qga umask fix addenda
On 05/10/13 21:30, mdroth wrote: On Wed, May 08, 2013 at 05:31:34PM +0200, Laszlo Ersek wrote: I should have paid more attention to portability and error path cleanup in the CVE-2013-2007 fix. (We continue to assume, like the rest of qemu code, that qemu_set_cloexec() never fails internally. This should be a reasonable assumption when the input fd is valid.) Laszlo Ersek (2): qga: distinguish binary modes in guest_file_open_modes map qga: unlink just created guest-file if fchmod() or fdopen() fails on it Thanks, applied to qga branch: https://github.com/mdroth/qemu/commits/qga Thanks! Can you reword the second commit to include Eric's R-b? http://lists.nongnu.org/archive/html/qemu-devel/2013-05/msg01179.html Thanks! Laszlo
Re: [Qemu-devel] [PATCH v2 0/2] qga umask fix addenda
On Fri, May 10, 2013 at 09:53:27PM +0200, Laszlo Ersek wrote: On 05/10/13 21:30, mdroth wrote: On Wed, May 08, 2013 at 05:31:34PM +0200, Laszlo Ersek wrote: I should have paid more attention to portability and error path cleanup in the CVE-2013-2007 fix. (We continue to assume, like the rest of qemu code, that qemu_set_cloexec() never fails internally. This should be a reasonable assumption when the input fd is valid.) Laszlo Ersek (2): qga: distinguish binary modes in guest_file_open_modes map qga: unlink just created guest-file if fchmod() or fdopen() fails on it Thanks, applied to qga branch: https://github.com/mdroth/qemu/commits/qga Thanks! Can you reword the second commit to include Eric's R-b? http://lists.nongnu.org/archive/html/qemu-devel/2013-05/msg01179.html Sure, missed that one. Should be fixed in tree now. Thanks! Laszlo
[Qemu-devel] [PATCH v2 0/2] qga umask fix addenda
I should have paid more attention to portability and error path cleanup in the CVE-2013-2007 fix. (We continue to assume, like the rest of qemu code, that qemu_set_cloexec() never fails internally. This should be a reasonable assumption when the input fd is valid.) Laszlo Ersek (2): qga: distinguish binary modes in guest_file_open_modes map qga: unlink just created guest-file if fchmod() or fdopen() fails on it qga/commands-posix.c | 25 +++-- 1 files changed, 19 insertions(+), 6 deletions(-)
