Re: [Qemu-devel] [PATCH v2 0/2] ramblock: add hmp command "info ramblock"

2017-04-26 Thread Peter Xu
On Thu, Apr 27, 2017 at 09:12:43AM +0800, Fam Zheng wrote:
> On Wed, 04/26 19:13, Peter Xu wrote:
> > v2:
> > - replace "lx" with "PRIx64" in three places
> 
> ram_addr_t doesn't have a fixed bit width, to keep compilers happy, maybe you
> can stick to PRIx64 in the format string, and cast the parameters.

Will do when there is new version. Thanks!

-- 
Peter Xu



Re: [Qemu-devel] [PATCH v2 0/2] ramblock: add hmp command "info ramblock"

2017-04-26 Thread Fam Zheng
On Wed, 04/26 19:13, Peter Xu wrote:
> v2:
> - replace "lx" with "PRIx64" in three places

ram_addr_t doesn't have a fixed bit width, to keep compilers happy, maybe you
can stick to PRIx64 in the format string, and cast the parameters.

Fam



[Qemu-devel] [PATCH v2 0/2] ramblock: add hmp command "info ramblock"

2017-04-26 Thread Peter Xu
v2:
- replace "lx" with "PRIx64" in three places

Sometimes I would like to know ramblock info for a VM. This command
would help. It provides a way to dump ramblock info. Currently the
list is by default sorted by size, though I think it's good enough.

Please review, thanks.

Peter Xu (2):
  ramblock: add RAMBLOCK_FOREACH()
  ramblock: add new hmp command "info ramblock"

 exec.c | 57 --
 hmp-commands-info.hx   | 14 +
 hmp.c  |  6 ++
 hmp.h  |  1 +
 include/exec/ramlist.h |  6 ++
 migration/ram.c| 15 ++---
 6 files changed, 81 insertions(+), 18 deletions(-)

-- 
2.7.4