Re: [Qemu-devel] [PATCH v2 04/16] virtio: split virtio rng bits from virtio-pci

2018-12-12 Thread Juan Quintela
Laurent Vivier  wrote:
> On 26/11/2018 20:59, Juan Quintela wrote:
>> Signed-off-by: Juan Quintela 
>> 
>> ---
>> 
>> Remove the "contributions after" clause.  This is based on
>> 
>> commit 59ccd20a9ac719cff82180429458728f03ec612f
>> Author: KONRAD Frederic 
>> Date:   Wed Apr 24 10:07:56 2013 +0200
>> ---
>>  hw/virtio/Makefile.objs|  1 +
>>  hw/virtio/virtio-pci.c | 52 ---
>>  hw/virtio/virtio-pci.h | 14 ---
>>  hw/virtio/virtio-rng-pci.c | 86 ++
>>  tests/Makefile.include |  1 +
>>  5 files changed, 88 insertions(+), 66 deletions(-)
>>  create mode 100644 hw/virtio/virtio-rng-pci.c
> ...
>> diff --git a/tests/Makefile.include b/tests/Makefile.include
>> index fb0b449c02..e8235890ec 100644
>> --- a/tests/Makefile.include
>> +++ b/tests/Makefile.include
>> @@ -149,6 +149,7 @@ check-qtest-virtio-y += tests/virtio-net-test$(EXESUF)
>>  check-qtest-virtio-y += tests/virtio-balloon-test$(EXESUF)
>>  check-qtest-virtio-y += tests/virtio-blk-test$(EXESUF)
>>  check-qtest-virtio-y += tests/virtio-rng-test$(EXESUF)
>> +check-qtest-virtio-$(CONFIG_VIRTIO_RNG) += tests/virtio-rng-test$(EXESUF)
>
> I think you should remove the line just above.
>
> except that:

Done.

Thanks.

>
> Reviewed-by: Laurent Vivier 



Re: [Qemu-devel] [PATCH v2 04/16] virtio: split virtio rng bits from virtio-pci

2018-11-28 Thread Laurent Vivier
On 26/11/2018 20:59, Juan Quintela wrote:
> Signed-off-by: Juan Quintela 
> 
> ---
> 
> Remove the "contributions after" clause.  This is based on
> 
> commit 59ccd20a9ac719cff82180429458728f03ec612f
> Author: KONRAD Frederic 
> Date:   Wed Apr 24 10:07:56 2013 +0200
> ---
>  hw/virtio/Makefile.objs|  1 +
>  hw/virtio/virtio-pci.c | 52 ---
>  hw/virtio/virtio-pci.h | 14 ---
>  hw/virtio/virtio-rng-pci.c | 86 ++
>  tests/Makefile.include |  1 +
>  5 files changed, 88 insertions(+), 66 deletions(-)
>  create mode 100644 hw/virtio/virtio-rng-pci.c
...
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index fb0b449c02..e8235890ec 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -149,6 +149,7 @@ check-qtest-virtio-y += tests/virtio-net-test$(EXESUF)
>  check-qtest-virtio-y += tests/virtio-balloon-test$(EXESUF)
>  check-qtest-virtio-y += tests/virtio-blk-test$(EXESUF)
>  check-qtest-virtio-y += tests/virtio-rng-test$(EXESUF)
> +check-qtest-virtio-$(CONFIG_VIRTIO_RNG) += tests/virtio-rng-test$(EXESUF)

I think you should remove the line just above.

except that:

Reviewed-by: Laurent Vivier 




[Qemu-devel] [PATCH v2 04/16] virtio: split virtio rng bits from virtio-pci

2018-11-26 Thread Juan Quintela
Signed-off-by: Juan Quintela 

---

Remove the "contributions after" clause.  This is based on

commit 59ccd20a9ac719cff82180429458728f03ec612f
Author: KONRAD Frederic 
Date:   Wed Apr 24 10:07:56 2013 +0200
---
 hw/virtio/Makefile.objs|  1 +
 hw/virtio/virtio-pci.c | 52 ---
 hw/virtio/virtio-pci.h | 14 ---
 hw/virtio/virtio-rng-pci.c | 86 ++
 tests/Makefile.include |  1 +
 5 files changed, 88 insertions(+), 66 deletions(-)
 create mode 100644 hw/virtio/virtio-rng-pci.c

diff --git a/hw/virtio/Makefile.objs b/hw/virtio/Makefile.objs
index 6819ed4e14..2efa544a2d 100644
--- a/hw/virtio/Makefile.objs
+++ b/hw/virtio/Makefile.objs
@@ -13,6 +13,7 @@ obj-$(CONFIG_LINUX) += vhost.o vhost-backend.o vhost-user.o
 obj-$(CONFIG_VHOST_VSOCK) += vhost-vsock.o vhost-vsock-pci.o
 obj-$(CONFIG_VIRTIO_INPUT_HOST) += virtio-input-host-pci.o
 obj-$(CONFIG_VIRTIO_INPUT) += virtio-input-pci.o
+obj-$(CONFIG_VIRTIO_RNG) += virtio-rng-pci.o
 endif
 
 common-obj-$(call lnot,$(call land,$(CONFIG_VIRTIO),$(CONFIG_LINUX))) += 
vhost-stub.o
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index bb1d2db032..433ece611d 100644
--- a/hw/virtio/virtio-pci.c
+++ b/hw/virtio/virtio-pci.c
@@ -2421,57 +2421,6 @@ static const TypeInfo virtio_net_pci_info = {
 .class_init= virtio_net_pci_class_init,
 };
 
-/* virtio-rng-pci */
-
-static void virtio_rng_pci_realize(VirtIOPCIProxy *vpci_dev, Error **errp)
-{
-VirtIORngPCI *vrng = VIRTIO_RNG_PCI(vpci_dev);
-DeviceState *vdev = DEVICE(>vdev);
-Error *err = NULL;
-
-qdev_set_parent_bus(vdev, BUS(_dev->bus));
-object_property_set_bool(OBJECT(vdev), true, "realized", );
-if (err) {
-error_propagate(errp, err);
-return;
-}
-
-object_property_set_link(OBJECT(vrng),
- OBJECT(vrng->vdev.conf.rng), "rng",
- NULL);
-}
-
-static void virtio_rng_pci_class_init(ObjectClass *klass, void *data)
-{
-DeviceClass *dc = DEVICE_CLASS(klass);
-VirtioPCIClass *k = VIRTIO_PCI_CLASS(klass);
-PCIDeviceClass *pcidev_k = PCI_DEVICE_CLASS(klass);
-
-k->realize = virtio_rng_pci_realize;
-set_bit(DEVICE_CATEGORY_MISC, dc->categories);
-
-pcidev_k->vendor_id = PCI_VENDOR_ID_REDHAT_QUMRANET;
-pcidev_k->device_id = PCI_DEVICE_ID_VIRTIO_RNG;
-pcidev_k->revision = VIRTIO_PCI_ABI_VERSION;
-pcidev_k->class_id = PCI_CLASS_OTHERS;
-}
-
-static void virtio_rng_initfn(Object *obj)
-{
-VirtIORngPCI *dev = VIRTIO_RNG_PCI(obj);
-
-virtio_instance_init_common(obj, >vdev, sizeof(dev->vdev),
-TYPE_VIRTIO_RNG);
-}
-
-static const TypeInfo virtio_rng_pci_info = {
-.name  = TYPE_VIRTIO_RNG_PCI,
-.parent= TYPE_VIRTIO_PCI,
-.instance_size = sizeof(VirtIORngPCI),
-.instance_init = virtio_rng_initfn,
-.class_init= virtio_rng_pci_class_init,
-};
-
 /* virtio-pci-bus */
 
 static void virtio_pci_bus_new(VirtioBusState *bus, size_t bus_size,
@@ -2519,7 +2468,6 @@ static const TypeInfo virtio_pci_bus_info = {
 
 static void virtio_pci_register_types(void)
 {
-type_register_static(_rng_pci_info);
 type_register_static(_pci_bus_info);
 type_register_static(_pci_info);
 #ifdef CONFIG_VIRTFS
diff --git a/hw/virtio/virtio-pci.h b/hw/virtio/virtio-pci.h
index 32d5f0fbff..2415eb6a4d 100644
--- a/hw/virtio/virtio-pci.h
+++ b/hw/virtio/virtio-pci.h
@@ -18,7 +18,6 @@
 #include "hw/pci/msi.h"
 #include "hw/virtio/virtio-blk.h"
 #include "hw/virtio/virtio-net.h"
-#include "hw/virtio/virtio-rng.h"
 #include "hw/virtio/virtio-serial.h"
 #include "hw/virtio/virtio-scsi.h"
 #include "hw/virtio/virtio-balloon.h"
@@ -46,7 +45,6 @@ typedef struct VirtIONetPCI VirtIONetPCI;
 typedef struct VHostSCSIPCI VHostSCSIPCI;
 typedef struct VHostUserSCSIPCI VHostUserSCSIPCI;
 typedef struct VHostUserBlkPCI VHostUserBlkPCI;
-typedef struct VirtIORngPCI VirtIORngPCI;
 typedef struct VirtIOGPUPCI VirtIOGPUPCI;
 typedef struct VirtIOCryptoPCI VirtIOCryptoPCI;
 
@@ -319,18 +317,6 @@ typedef struct V9fsPCIState {
 
 #endif
 
-/*
- * virtio-rng-pci: This extends VirtioPCIProxy.
- */
-#define TYPE_VIRTIO_RNG_PCI "virtio-rng-pci"
-#define VIRTIO_RNG_PCI(obj) \
-OBJECT_CHECK(VirtIORngPCI, (obj), TYPE_VIRTIO_RNG_PCI)
-
-struct VirtIORngPCI {
-VirtIOPCIProxy parent_obj;
-VirtIORNG vdev;
-};
-
 /*
  * virtio-input-pci: This extends VirtioPCIProxy.
  */
diff --git a/hw/virtio/virtio-rng-pci.c b/hw/virtio/virtio-rng-pci.c
new file mode 100644
index 00..60688fbea9
--- /dev/null
+++ b/hw/virtio/virtio-rng-pci.c
@@ -0,0 +1,86 @@
+/*
+ * Virtio rng PCI Bindings
+ *
+ * Copyright 2012 Red Hat, Inc.
+ * Copyright 2012 Amit Shah 
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or
+ * (at your option) any later version.  See the COPYING file in the
+ * top-level directory.
+ */
+
+#include "qemu/osdep.h"
+
+#include "virtio-pci.h"