Re: [Qemu-devel] [PATCH v2 20/21] xen_backend: remove xen_sysdev_init() function

2018-11-26 Thread Anthony PERARD
On Fri, Nov 23, 2018 at 11:30:39PM +0800, Mao Zhongyi wrote:
> The init function doesn't do anything at all, so we
> just omit it.
> 
> Cc: sstabell...@kernel.org
> Cc: anthony.per...@citrix.com
> Cc: xen-de...@lists.xenproject.org
> Cc: peter.mayd...@linaro.org
> 
> Signed-off-by: Mao Zhongyi 
> Signed-off-by: Zhang Shengju 

Acked-by: Anthony PERARD 

Thanks,

-- 
Anthony PERARD



[Qemu-devel] [PATCH v2 20/21] xen_backend: remove xen_sysdev_init() function

2018-11-23 Thread Mao Zhongyi
The init function doesn't do anything at all, so we
just omit it.

Cc: sstabell...@kernel.org
Cc: anthony.per...@citrix.com
Cc: xen-de...@lists.xenproject.org
Cc: peter.mayd...@linaro.org

Signed-off-by: Mao Zhongyi 
Signed-off-by: Zhang Shengju 
---
 hw/xen/xen_backend.c | 7 ---
 1 file changed, 7 deletions(-)

diff --git a/hw/xen/xen_backend.c b/hw/xen/xen_backend.c
index 9a8e8771ec..0bc6b1de60 100644
--- a/hw/xen/xen_backend.c
+++ b/hw/xen/xen_backend.c
@@ -809,11 +809,6 @@ static const TypeInfo xensysbus_info = {
 }
 };
 
-static int xen_sysdev_init(SysBusDevice *dev)
-{
-return 0;
-}
-
 static Property xen_sysdev_properties[] = {
 {/* end of property list */},
 };
@@ -821,9 +816,7 @@ static Property xen_sysdev_properties[] = {
 static void xen_sysdev_class_init(ObjectClass *klass, void *data)
 {
 DeviceClass *dc = DEVICE_CLASS(klass);
-SysBusDeviceClass *k = SYS_BUS_DEVICE_CLASS(klass);
 
-k->init = xen_sysdev_init;
 dc->props = xen_sysdev_properties;
 dc->bus_type = TYPE_XENSYSBUS;
 }
-- 
2.17.1