Re: [Qemu-devel] [PATCH v2 5/5] migration: Missing rcu_read_unlock

2019-09-12 Thread Paolo Bonzini 
On 11/09/19 21:06, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" 
> 
> Error path missing an unlock.
> 
> Signed-off-by: Dr. David Alan Gilbert 
> ---
>  migration/ram.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/migration/ram.c b/migration/ram.c
> index 1bb82acfe0..977172ea7e 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -3445,6 +3445,7 @@ static int ram_save_setup(QEMUFile *f, void *opaque)
>  RAMBLOCK_FOREACH_MIGRATABLE(block) {
>  if (!block->idstr[0]) {
>  error_report("%s: RAMBlock with empty name", __func__);
> +rcu_read_unlock();
>  return -1;
>  }
>  qemu_put_byte(f, strlen(block->idstr));
> 

(The scoped version would be useful here).

Paolo

Re: [Qemu-devel] [PATCH v2 5/5] migration: Missing rcu_read_unlock

2019-09-12 Thread Daniel P . Berrangé 
On Wed, Sep 11, 2019 at 08:06:22PM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" 
> 
> Error path missing an unlock.
> 
> Signed-off-by: Dr. David Alan Gilbert 
> ---
>  migration/ram.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Daniel P. Berrangé 


Regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

[Qemu-devel] [PATCH v2 5/5] migration: Missing rcu_read_unlock

2019-09-11 Thread Dr. David Alan Gilbert (git) 
From: "Dr. David Alan Gilbert" 

Error path missing an unlock.

Signed-off-by: Dr. David Alan Gilbert 
---
 migration/ram.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/migration/ram.c b/migration/ram.c
index 1bb82acfe0..977172ea7e 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -3445,6 +3445,7 @@ static int ram_save_setup(QEMUFile *f, void *opaque)
 RAMBLOCK_FOREACH_MIGRATABLE(block) {
 if (!block->idstr[0]) {
 error_report("%s: RAMBlock with empty name", __func__);
+rcu_read_unlock();
 return -1;
 }
 qemu_put_byte(f, strlen(block->idstr));
-- 
2.21.0