Re: [Qemu-devel] [PATCH v3 08/13] pc-dimm: merge get_(vmstate_)memory_region()

2018-06-18 Thread Igor Mammedov 
On Fri, 15 Jun 2018 16:04:43 +0200
David Hildenbrand  wrote:

> Importantly, get_vmstate_memory_region() should also fail with a proper
> error if called before the device is realized. For a PCDIMM, both functions
> are to return the same thing, so share the implementation.
> 
> All current users are called after the device has been realized, so we
> can expect the calls to succeed.
> 
> Signed-off-by: David Hildenbrand 

Reviewed-by: Igor Mammedov 

> ---
>  hw/mem/pc-dimm.c | 13 +
>  include/hw/mem/pc-dimm.h |  3 ++-
>  2 files changed, 7 insertions(+), 9 deletions(-)
> 
> diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c
> index 73f0eee4c7..4ff39b59ef 100644
> --- a/hw/mem/pc-dimm.c
> +++ b/hw/mem/pc-dimm.c
> @@ -35,7 +35,8 @@ void pc_dimm_plug(DeviceState *dev, MachineState *machine, 
> uint64_t align,
>  int slot;
>  PCDIMMDevice *dimm = PC_DIMM(dev);
>  PCDIMMDeviceClass *ddc = PC_DIMM_GET_CLASS(dimm);
> -MemoryRegion *vmstate_mr = ddc->get_vmstate_memory_region(dimm);
> +MemoryRegion *vmstate_mr = ddc->get_vmstate_memory_region(dimm,
> +  _abort);
>  Error *local_err = NULL;
>  MemoryRegion *mr;
>  uint64_t addr;
> @@ -90,7 +91,8 @@ void pc_dimm_unplug(DeviceState *dev, MachineState *machine)
>  {
>  PCDIMMDevice *dimm = PC_DIMM(dev);
>  PCDIMMDeviceClass *ddc = PC_DIMM_GET_CLASS(dimm);
> -MemoryRegion *vmstate_mr = ddc->get_vmstate_memory_region(dimm);
> +MemoryRegion *vmstate_mr = ddc->get_vmstate_memory_region(dimm,
> +  _abort);
>  MemoryRegion *mr = ddc->get_memory_region(dimm, _abort);
>  
>  memory_device_unplug_region(machine, mr);
> @@ -229,11 +231,6 @@ static MemoryRegion 
> *pc_dimm_get_memory_region(PCDIMMDevice *dimm, Error **errp)
>  return host_memory_backend_get_memory(dimm->hostmem);
>  }
>  
> -static MemoryRegion *pc_dimm_get_vmstate_memory_region(PCDIMMDevice *dimm)
> -{
> -return host_memory_backend_get_memory(dimm->hostmem);
> -}
> -
>  static uint64_t pc_dimm_md_get_addr(const MemoryDeviceState *md)
>  {
>  const PCDIMMDevice *dimm = PC_DIMM(md);
> @@ -298,7 +295,7 @@ static void pc_dimm_class_init(ObjectClass *oc, void 
> *data)
>  dc->desc = "DIMM memory module";
>  
>  ddc->get_memory_region = pc_dimm_get_memory_region;
> -ddc->get_vmstate_memory_region = pc_dimm_get_vmstate_memory_region;
> +ddc->get_vmstate_memory_region = pc_dimm_get_memory_region;
>  
>  mdc->get_addr = pc_dimm_md_get_addr;
>  /* for a dimm plugged_size == region_size */
> diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h
> index cf71247630..5679a80465 100644
> --- a/include/hw/mem/pc-dimm.h
> +++ b/include/hw/mem/pc-dimm.h
> @@ -73,7 +73,8 @@ typedef struct PCDIMMDeviceClass {
>  /* public */
>  void (*realize)(PCDIMMDevice *dimm, Error **errp);
>  MemoryRegion *(*get_memory_region)(PCDIMMDevice *dimm, Error **errp);
> -MemoryRegion *(*get_vmstate_memory_region)(PCDIMMDevice *dimm);
> +MemoryRegion *(*get_vmstate_memory_region)(PCDIMMDevice *dimm,
> +   Error **errp);
>  } PCDIMMDeviceClass;
>  
>  void pc_dimm_plug(DeviceState *dev, MachineState *machine, uint64_t align,

Re: [Qemu-devel] [PATCH v3 08/13] pc-dimm: merge get_(vmstate_)memory_region()

2018-06-17 Thread David Gibson 
On Fri, Jun 15, 2018 at 04:04:43PM +0200, David Hildenbrand wrote:
> Importantly, get_vmstate_memory_region() should also fail with a proper
> error if called before the device is realized. For a PCDIMM, both functions
> are to return the same thing, so share the implementation.
> 
> All current users are called after the device has been realized, so we
> can expect the calls to succeed.
> 
> Signed-off-by: David Hildenbrand 

Reviewed-by: David Gibson 

> ---
>  hw/mem/pc-dimm.c | 13 +
>  include/hw/mem/pc-dimm.h |  3 ++-
>  2 files changed, 7 insertions(+), 9 deletions(-)
> 
> diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c
> index 73f0eee4c7..4ff39b59ef 100644
> --- a/hw/mem/pc-dimm.c
> +++ b/hw/mem/pc-dimm.c
> @@ -35,7 +35,8 @@ void pc_dimm_plug(DeviceState *dev, MachineState *machine, 
> uint64_t align,
>  int slot;
>  PCDIMMDevice *dimm = PC_DIMM(dev);
>  PCDIMMDeviceClass *ddc = PC_DIMM_GET_CLASS(dimm);
> -MemoryRegion *vmstate_mr = ddc->get_vmstate_memory_region(dimm);
> +MemoryRegion *vmstate_mr = ddc->get_vmstate_memory_region(dimm,
> +  _abort);
>  Error *local_err = NULL;
>  MemoryRegion *mr;
>  uint64_t addr;
> @@ -90,7 +91,8 @@ void pc_dimm_unplug(DeviceState *dev, MachineState *machine)
>  {
>  PCDIMMDevice *dimm = PC_DIMM(dev);
>  PCDIMMDeviceClass *ddc = PC_DIMM_GET_CLASS(dimm);
> -MemoryRegion *vmstate_mr = ddc->get_vmstate_memory_region(dimm);
> +MemoryRegion *vmstate_mr = ddc->get_vmstate_memory_region(dimm,
> +  _abort);
>  MemoryRegion *mr = ddc->get_memory_region(dimm, _abort);
>  
>  memory_device_unplug_region(machine, mr);
> @@ -229,11 +231,6 @@ static MemoryRegion 
> *pc_dimm_get_memory_region(PCDIMMDevice *dimm, Error **errp)
>  return host_memory_backend_get_memory(dimm->hostmem);
>  }
>  
> -static MemoryRegion *pc_dimm_get_vmstate_memory_region(PCDIMMDevice *dimm)
> -{
> -return host_memory_backend_get_memory(dimm->hostmem);
> -}
> -
>  static uint64_t pc_dimm_md_get_addr(const MemoryDeviceState *md)
>  {
>  const PCDIMMDevice *dimm = PC_DIMM(md);
> @@ -298,7 +295,7 @@ static void pc_dimm_class_init(ObjectClass *oc, void 
> *data)
>  dc->desc = "DIMM memory module";
>  
>  ddc->get_memory_region = pc_dimm_get_memory_region;
> -ddc->get_vmstate_memory_region = pc_dimm_get_vmstate_memory_region;
> +ddc->get_vmstate_memory_region = pc_dimm_get_memory_region;
>  
>  mdc->get_addr = pc_dimm_md_get_addr;
>  /* for a dimm plugged_size == region_size */
> diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h
> index cf71247630..5679a80465 100644
> --- a/include/hw/mem/pc-dimm.h
> +++ b/include/hw/mem/pc-dimm.h
> @@ -73,7 +73,8 @@ typedef struct PCDIMMDeviceClass {
>  /* public */
>  void (*realize)(PCDIMMDevice *dimm, Error **errp);
>  MemoryRegion *(*get_memory_region)(PCDIMMDevice *dimm, Error **errp);
> -MemoryRegion *(*get_vmstate_memory_region)(PCDIMMDevice *dimm);
> +MemoryRegion *(*get_vmstate_memory_region)(PCDIMMDevice *dimm,
> +   Error **errp);
>  } PCDIMMDeviceClass;
>  
>  void pc_dimm_plug(DeviceState *dev, MachineState *machine, uint64_t align,

-- 
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson


signature.asc
Description: PGP signature

[Qemu-devel] [PATCH v3 08/13] pc-dimm: merge get_(vmstate_)memory_region()

2018-06-15 Thread David Hildenbrand 
Importantly, get_vmstate_memory_region() should also fail with a proper
error if called before the device is realized. For a PCDIMM, both functions
are to return the same thing, so share the implementation.

All current users are called after the device has been realized, so we
can expect the calls to succeed.

Signed-off-by: David Hildenbrand 
---
 hw/mem/pc-dimm.c | 13 +
 include/hw/mem/pc-dimm.h |  3 ++-
 2 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c
index 73f0eee4c7..4ff39b59ef 100644
--- a/hw/mem/pc-dimm.c
+++ b/hw/mem/pc-dimm.c
@@ -35,7 +35,8 @@ void pc_dimm_plug(DeviceState *dev, MachineState *machine, 
uint64_t align,
 int slot;
 PCDIMMDevice *dimm = PC_DIMM(dev);
 PCDIMMDeviceClass *ddc = PC_DIMM_GET_CLASS(dimm);
-MemoryRegion *vmstate_mr = ddc->get_vmstate_memory_region(dimm);
+MemoryRegion *vmstate_mr = ddc->get_vmstate_memory_region(dimm,
+  _abort);
 Error *local_err = NULL;
 MemoryRegion *mr;
 uint64_t addr;
@@ -90,7 +91,8 @@ void pc_dimm_unplug(DeviceState *dev, MachineState *machine)
 {
 PCDIMMDevice *dimm = PC_DIMM(dev);
 PCDIMMDeviceClass *ddc = PC_DIMM_GET_CLASS(dimm);
-MemoryRegion *vmstate_mr = ddc->get_vmstate_memory_region(dimm);
+MemoryRegion *vmstate_mr = ddc->get_vmstate_memory_region(dimm,
+  _abort);
 MemoryRegion *mr = ddc->get_memory_region(dimm, _abort);
 
 memory_device_unplug_region(machine, mr);
@@ -229,11 +231,6 @@ static MemoryRegion 
*pc_dimm_get_memory_region(PCDIMMDevice *dimm, Error **errp)
 return host_memory_backend_get_memory(dimm->hostmem);
 }
 
-static MemoryRegion *pc_dimm_get_vmstate_memory_region(PCDIMMDevice *dimm)
-{
-return host_memory_backend_get_memory(dimm->hostmem);
-}
-
 static uint64_t pc_dimm_md_get_addr(const MemoryDeviceState *md)
 {
 const PCDIMMDevice *dimm = PC_DIMM(md);
@@ -298,7 +295,7 @@ static void pc_dimm_class_init(ObjectClass *oc, void *data)
 dc->desc = "DIMM memory module";
 
 ddc->get_memory_region = pc_dimm_get_memory_region;
-ddc->get_vmstate_memory_region = pc_dimm_get_vmstate_memory_region;
+ddc->get_vmstate_memory_region = pc_dimm_get_memory_region;
 
 mdc->get_addr = pc_dimm_md_get_addr;
 /* for a dimm plugged_size == region_size */
diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h
index cf71247630..5679a80465 100644
--- a/include/hw/mem/pc-dimm.h
+++ b/include/hw/mem/pc-dimm.h
@@ -73,7 +73,8 @@ typedef struct PCDIMMDeviceClass {
 /* public */
 void (*realize)(PCDIMMDevice *dimm, Error **errp);
 MemoryRegion *(*get_memory_region)(PCDIMMDevice *dimm, Error **errp);
-MemoryRegion *(*get_vmstate_memory_region)(PCDIMMDevice *dimm);
+MemoryRegion *(*get_vmstate_memory_region)(PCDIMMDevice *dimm,
+   Error **errp);
 } PCDIMMDeviceClass;
 
 void pc_dimm_plug(DeviceState *dev, MachineState *machine, uint64_t align,
-- 
2.17.1