Re: [Qemu-devel] [PATCH v3 16/23] pc87312: Drop unused members of PC87312State

2014-09-29 Thread Kevin Wolf 
Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben:
 Signed-off-by: Markus Armbruster arm...@redhat.com

Reviewed-by: Kevin Wolf kw...@redhat.com

Re: [Qemu-devel] [PATCH v3 16/23] pc87312: Drop unused members of PC87312State

2014-09-20 Thread Max Reitz 

On 16.09.2014 20:12, Markus Armbruster wrote:

Signed-off-by: Markus Armbruster arm...@redhat.com
---
  include/hw/isa/pc87312.h | 3 ---
  1 file changed, 3 deletions(-)


Reviewed-by: Max Reitz mre...@redhat.com

Re: [Qemu-devel] [PATCH v3 16/23] pc87312: Drop unused members of PC87312State

2014-09-17 Thread Benoît Canet 
On Tue, Sep 16, 2014 at 08:12:21PM +0200, Markus Armbruster wrote:
 Signed-off-by: Markus Armbruster arm...@redhat.com
 ---
  include/hw/isa/pc87312.h | 3 ---
  1 file changed, 3 deletions(-)
 
 diff --git a/include/hw/isa/pc87312.h b/include/hw/isa/pc87312.h
 index befc8bd..bf74470 100644
 --- a/include/hw/isa/pc87312.h
 +++ b/include/hw/isa/pc87312.h
 @@ -47,13 +47,10 @@ typedef struct PC87312State {
  
  struct {
  ISADevice *dev;
 -BlockDriverState *drive[2];
 -uint32_t base;
  } fdc;
  
  struct {
  ISADevice *dev;
 -uint32_t base;
  } ide;
  
  MemoryRegion io;
 -- 
 1.9.3
 
Reviewed-by: Benoit Canet benoit.ca...@nodalink.com

[Qemu-devel] [PATCH v3 16/23] pc87312: Drop unused members of PC87312State

2014-09-16 Thread Markus Armbruster 
Signed-off-by: Markus Armbruster arm...@redhat.com
---
 include/hw/isa/pc87312.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/include/hw/isa/pc87312.h b/include/hw/isa/pc87312.h
index befc8bd..bf74470 100644
--- a/include/hw/isa/pc87312.h
+++ b/include/hw/isa/pc87312.h
@@ -47,13 +47,10 @@ typedef struct PC87312State {
 
 struct {
 ISADevice *dev;
-BlockDriverState *drive[2];
-uint32_t base;
 } fdc;
 
 struct {
 ISADevice *dev;
-uint32_t base;
 } ide;
 
 MemoryRegion io;
-- 
1.9.3