Re: [Qemu-devel] [PATCH v4 0/2] block: allow flush on devices with open tray
Am 19.09.2016 um 22:58 hat Max Reitz geschrieben: > On 19.09.2016 18:44, John Snow wrote: > > Final re-send for wording. > > > > The move to blk_flush altered the behavior of migration and flushing > > nodes that are not reachable via the guest, but are still reachable > > via QEMU and may or may not need to be flushed. > > > > This is likely the simplest solution for now until we nail down our > > policy a bit more. > > > > This is intended for 2.6.2 and/or 2.7.1, to fix problems with libvirt > > et al being unable to migrate QEMU when the CDROM tray is open. > > > > v4: > > Commit message update. > > > > v3: > > Trying to take a hint from Kevin, reinstating bdrv_flush_all. > > If it's not what we want, we can try moving back to v2, > > acknowledging that a nicer solution in the future: > > (A) Can skip flushing on devices that just don't need it, and > > (B) Optionally institutes some sort of flush-on-eject policy. > > > > > > > > For convenience, this branch is available at: > > https://github.com/jnsnow/qemu.git branch atapi-tray-migfix > > https://github.com/jnsnow/qemu/tree/atapi-tray-migfix > > > > This version is tagged atapi-tray-migfix-v4: > > https://github.com/jnsnow/qemu/releases/tag/atapi-tray-migfix-v4 > > > > John Snow (2): > > block: reintroduce bdrv_flush_all > > qemu: use bdrv_flush_all for vm_stop et al > > > > block/io.c| 25 + > > cpus.c| 4 ++-- > > include/block/block.h | 1 + > > 3 files changed, 28 insertions(+), 2 deletions(-) > > Reviewed-by: Max Reitz Begs the question: Who is supposed to merge this? Stefan/Fam, who are formally responsible for block/io.c? Or one of us because it's more about managing block devices? Kevin pgpk4QTCQiLc3.pgp Description: PGP signature
Re: [Qemu-devel] [PATCH v4 0/2] block: allow flush on devices with open tray
On 19.09.2016 23:21, John Snow wrote: > > > On 09/19/2016 04:58 PM, Max Reitz wrote: >> On 19.09.2016 18:44, John Snow wrote: >>> Final re-send for wording. >>> >>> The move to blk_flush altered the behavior of migration and flushing >>> nodes that are not reachable via the guest, but are still reachable >>> via QEMU and may or may not need to be flushed. >>> >>> This is likely the simplest solution for now until we nail down our >>> policy a bit more. >>> >>> This is intended for 2.6.2 and/or 2.7.1, to fix problems with libvirt >>> et al being unable to migrate QEMU when the CDROM tray is open. >>> >>> v4: >>> Commit message update. >>> >>> v3: >>> Trying to take a hint from Kevin, reinstating bdrv_flush_all. >>> If it's not what we want, we can try moving back to v2, >>> acknowledging that a nicer solution in the future: >>> (A) Can skip flushing on devices that just don't need it, and >>> (B) Optionally institutes some sort of flush-on-eject policy. >>> >>> >>> >>> >>> For convenience, this branch is available at: >>> https://github.com/jnsnow/qemu.git branch atapi-tray-migfix >>> https://github.com/jnsnow/qemu/tree/atapi-tray-migfix >>> >>> This version is tagged atapi-tray-migfix-v4: >>> https://github.com/jnsnow/qemu/releases/tag/atapi-tray-migfix-v4 >>> >>> John Snow (2): >>> block: reintroduce bdrv_flush_all >>> qemu: use bdrv_flush_all for vm_stop et al >>> >>> block/io.c| 25 + >>> cpus.c| 4 ++-- >>> include/block/block.h | 1 + >>> 3 files changed, 28 insertions(+), 2 deletions(-) >> >> Reviewed-by: Max Reitz >> > > http://i.imgur.com/DNltmfT.jpg http://bit.ly/2cLX1rm signature.asc Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH v4 0/2] block: allow flush on devices with open tray
On 09/19/2016 04:58 PM, Max Reitz wrote: On 19.09.2016 18:44, John Snow wrote: Final re-send for wording. The move to blk_flush altered the behavior of migration and flushing nodes that are not reachable via the guest, but are still reachable via QEMU and may or may not need to be flushed. This is likely the simplest solution for now until we nail down our policy a bit more. This is intended for 2.6.2 and/or 2.7.1, to fix problems with libvirt et al being unable to migrate QEMU when the CDROM tray is open. v4: Commit message update. v3: Trying to take a hint from Kevin, reinstating bdrv_flush_all. If it's not what we want, we can try moving back to v2, acknowledging that a nicer solution in the future: (A) Can skip flushing on devices that just don't need it, and (B) Optionally institutes some sort of flush-on-eject policy. For convenience, this branch is available at: https://github.com/jnsnow/qemu.git branch atapi-tray-migfix https://github.com/jnsnow/qemu/tree/atapi-tray-migfix This version is tagged atapi-tray-migfix-v4: https://github.com/jnsnow/qemu/releases/tag/atapi-tray-migfix-v4 John Snow (2): block: reintroduce bdrv_flush_all qemu: use bdrv_flush_all for vm_stop et al block/io.c| 25 + cpus.c| 4 ++-- include/block/block.h | 1 + 3 files changed, 28 insertions(+), 2 deletions(-) Reviewed-by: Max Reitz http://i.imgur.com/DNltmfT.jpg
Re: [Qemu-devel] [PATCH v4 0/2] block: allow flush on devices with open tray
On 19.09.2016 18:44, John Snow wrote: > Final re-send for wording. > > The move to blk_flush altered the behavior of migration and flushing > nodes that are not reachable via the guest, but are still reachable > via QEMU and may or may not need to be flushed. > > This is likely the simplest solution for now until we nail down our > policy a bit more. > > This is intended for 2.6.2 and/or 2.7.1, to fix problems with libvirt > et al being unable to migrate QEMU when the CDROM tray is open. > > v4: > Commit message update. > > v3: > Trying to take a hint from Kevin, reinstating bdrv_flush_all. > If it's not what we want, we can try moving back to v2, > acknowledging that a nicer solution in the future: > (A) Can skip flushing on devices that just don't need it, and > (B) Optionally institutes some sort of flush-on-eject policy. > > > > For convenience, this branch is available at: > https://github.com/jnsnow/qemu.git branch atapi-tray-migfix > https://github.com/jnsnow/qemu/tree/atapi-tray-migfix > > This version is tagged atapi-tray-migfix-v4: > https://github.com/jnsnow/qemu/releases/tag/atapi-tray-migfix-v4 > > John Snow (2): > block: reintroduce bdrv_flush_all > qemu: use bdrv_flush_all for vm_stop et al > > block/io.c| 25 + > cpus.c| 4 ++-- > include/block/block.h | 1 + > 3 files changed, 28 insertions(+), 2 deletions(-) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH v4 0/2] block: allow flush on devices with open tray
On 09/19/2016 02:15 PM, no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote: Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. lies and slander! Subject: [Qemu-devel] [PATCH v4 0/2] block: allow flush on devices with open tray Message-id: 1474303471-12509-1-git-send-email-js...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash set -e git submodule update --init dtc make J=8 docker-test-quick@centos6 make J=8 docker-test-mingw@fedora === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 647d07e qemu: use bdrv_flush_all for vm_stop et al 5989f9b block: reintroduce bdrv_flush_all === OUTPUT BEGIN === Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc' Cloning into 'dtc'... Submodule path 'dtc': checked out '65cc4d2748a2c2e6f27f1cf39e07a5dbabd80ebf' BUILD centos6 ARCHIVE qemu.tgz ARCHIVE dtc.tgz COPY RUNNER RUN test-quick in centos6 No C++ compiler available; disabling C++ specific optional code Install prefix/tmp/qemu-test/src/tests/docker/install BIOS directory/tmp/qemu-test/src/tests/docker/install/share/qemu binary directory /tmp/qemu-test/src/tests/docker/install/bin library directory /tmp/qemu-test/src/tests/docker/install/lib module directory /tmp/qemu-test/src/tests/docker/install/lib/qemu libexec directory /tmp/qemu-test/src/tests/docker/install/libexec include directory /tmp/qemu-test/src/tests/docker/install/include config directory /tmp/qemu-test/src/tests/docker/install/etc local state directory /tmp/qemu-test/src/tests/docker/install/var Manual directory /tmp/qemu-test/src/tests/docker/install/share/man ELF interp prefix /usr/gnemul/qemu-%M Source path /tmp/qemu-test/src C compilercc Host C compiler cc C++ compiler Objective-C compiler cc ARFLAGS rv CFLAGS-O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -g QEMU_CFLAGS -I/usr/include/pixman-1-fPIE -DPIE -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wendif-labels -Wmissing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition -Wtype-limits -fstack-protector-all LDFLAGS -Wl,--warn-common -Wl,-z,relro -Wl,-z,now -pie -m64 -g make make install install pythonpython -B smbd /usr/sbin/smbd module supportno host CPU x86_64 host big endian no target list x86_64-softmmu aarch64-softmmu tcg debug enabled no gprof enabled no sparse enabledno strip binariesyes profiler no static build no pixmansystem SDL support yes (1.2.14) GTK support no GTK GL supportno VTE support no TLS priority NORMAL GNUTLS supportno GNUTLS rndno libgcrypt no libgcrypt kdf no nettleno nettle kdfno libtasn1 no curses supportno virgl support no curl support no mingw32 support no Audio drivers oss Block whitelist (rw) Block whitelist (ro) VirtFS supportno VNC support yes VNC SASL support no VNC JPEG support no VNC PNG support no xen support no brlapi supportno bluez supportno Documentation no PIE yes vde support no netmap supportno Linux AIO support no ATTR/XATTR support yes Install blobs yes KVM support yes RDMA support no TCG interpreter no fdt support yes preadv supportyes fdatasync yes madvise yes posix_madvise yes uuid support no libcap-ng support no vhost-net support yes vhost-scsi support yes vhost-vsock support yes Trace backendslog spice support no rbd support no xfsctl supportno smartcard support no libusbno usb net redir no OpenGL supportno OpenGL dmabufsno libiscsi support no libnfs supportno build guest agent yes QGA VSS support no QGA w32 disk info no QGA MSI support no seccomp support no coroutine backend ucontext coroutine poolyes GlusterFS support no Archipelago support no gcov gcov gcov enabled no TPM support yes libssh2 support no TPM passthrough yes QOM debugging yes vhdx no lzo support no snappy supportno bzip2 support no NUMA host support no tcmalloc support no jemalloc support no avx2 optimization no replication support yes GEN x86_64-softmmu/config-devices.mak.tmp GEN aarch64-softmmu/config-devices.mak.tmp GEN config-host.h GEN qemu-options.def GE
Re: [Qemu-devel] [PATCH v4 0/2] block: allow flush on devices with open tray
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH v4 0/2] block: allow flush on devices with open tray Message-id: 1474303471-12509-1-git-send-email-js...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash set -e git submodule update --init dtc make J=8 docker-test-quick@centos6 make J=8 docker-test-mingw@fedora === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 647d07e qemu: use bdrv_flush_all for vm_stop et al 5989f9b block: reintroduce bdrv_flush_all === OUTPUT BEGIN === Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc' Cloning into 'dtc'... Submodule path 'dtc': checked out '65cc4d2748a2c2e6f27f1cf39e07a5dbabd80ebf' BUILD centos6 ARCHIVE qemu.tgz ARCHIVE dtc.tgz COPY RUNNER RUN test-quick in centos6 No C++ compiler available; disabling C++ specific optional code Install prefix/tmp/qemu-test/src/tests/docker/install BIOS directory/tmp/qemu-test/src/tests/docker/install/share/qemu binary directory /tmp/qemu-test/src/tests/docker/install/bin library directory /tmp/qemu-test/src/tests/docker/install/lib module directory /tmp/qemu-test/src/tests/docker/install/lib/qemu libexec directory /tmp/qemu-test/src/tests/docker/install/libexec include directory /tmp/qemu-test/src/tests/docker/install/include config directory /tmp/qemu-test/src/tests/docker/install/etc local state directory /tmp/qemu-test/src/tests/docker/install/var Manual directory /tmp/qemu-test/src/tests/docker/install/share/man ELF interp prefix /usr/gnemul/qemu-%M Source path /tmp/qemu-test/src C compilercc Host C compiler cc C++ compiler Objective-C compiler cc ARFLAGS rv CFLAGS-O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -g QEMU_CFLAGS -I/usr/include/pixman-1-fPIE -DPIE -m64 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wendif-labels -Wmissing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition -Wtype-limits -fstack-protector-all LDFLAGS -Wl,--warn-common -Wl,-z,relro -Wl,-z,now -pie -m64 -g make make install install pythonpython -B smbd /usr/sbin/smbd module supportno host CPU x86_64 host big endian no target list x86_64-softmmu aarch64-softmmu tcg debug enabled no gprof enabled no sparse enabledno strip binariesyes profiler no static build no pixmansystem SDL support yes (1.2.14) GTK support no GTK GL supportno VTE support no TLS priority NORMAL GNUTLS supportno GNUTLS rndno libgcrypt no libgcrypt kdf no nettleno nettle kdfno libtasn1 no curses supportno virgl support no curl support no mingw32 support no Audio drivers oss Block whitelist (rw) Block whitelist (ro) VirtFS supportno VNC support yes VNC SASL support no VNC JPEG support no VNC PNG support no xen support no brlapi supportno bluez supportno Documentation no PIE yes vde support no netmap supportno Linux AIO support no ATTR/XATTR support yes Install blobs yes KVM support yes RDMA support no TCG interpreter no fdt support yes preadv supportyes fdatasync yes madvise yes posix_madvise yes uuid support no libcap-ng support no vhost-net support yes vhost-scsi support yes vhost-vsock support yes Trace backendslog spice support no rbd support no xfsctl supportno smartcard support no libusbno usb net redir no OpenGL supportno OpenGL dmabufsno libiscsi support no libnfs supportno build guest agent yes QGA VSS support no QGA w32 disk info no QGA MSI support no seccomp support no coroutine backend ucontext coroutine poolyes GlusterFS support no Archipelago support no gcov gcov gcov enabled no TPM support yes libssh2 support no TPM passthrough yes QOM debugging yes vhdx no lzo support no snappy supportno bzip2 support no NUMA host support no tcmalloc support no jemalloc support no avx2 optimization no replication support yes GEN x86_64-softmmu/config-devices.mak.tmp GEN aarch64-softmmu/config-devices.mak.tmp GEN config-host.h GEN qemu-options.def GEN qmp-commands.h GEN qapi-types.h GEN qapi-visit.h GEN qapi-event.h GEN x86_
[Qemu-devel] [PATCH v4 0/2] block: allow flush on devices with open tray
Final re-send for wording. The move to blk_flush altered the behavior of migration and flushing nodes that are not reachable via the guest, but are still reachable via QEMU and may or may not need to be flushed. This is likely the simplest solution for now until we nail down our policy a bit more. This is intended for 2.6.2 and/or 2.7.1, to fix problems with libvirt et al being unable to migrate QEMU when the CDROM tray is open. v4: Commit message update. v3: Trying to take a hint from Kevin, reinstating bdrv_flush_all. If it's not what we want, we can try moving back to v2, acknowledging that a nicer solution in the future: (A) Can skip flushing on devices that just don't need it, and (B) Optionally institutes some sort of flush-on-eject policy. For convenience, this branch is available at: https://github.com/jnsnow/qemu.git branch atapi-tray-migfix https://github.com/jnsnow/qemu/tree/atapi-tray-migfix This version is tagged atapi-tray-migfix-v4: https://github.com/jnsnow/qemu/releases/tag/atapi-tray-migfix-v4 John Snow (2): block: reintroduce bdrv_flush_all qemu: use bdrv_flush_all for vm_stop et al block/io.c| 25 + cpus.c| 4 ++-- include/block/block.h | 1 + 3 files changed, 28 insertions(+), 2 deletions(-) -- 2.7.4