Re: [Qemu-devel] [PATCH v4 1/6] tests: fix memory leak in virtio-scsi-test

2016-10-14 Thread Greg Kurz 
On Fri, 14 Oct 2016 10:58:50 +0200
Laurent Vivier  wrote:

> vs is allocated in qvirtio_scsi_pci_init() and never freed.
> 
> Signed-off-by: Laurent Vivier 
> ---

Reviewed-by: Greg Kurz 

>  tests/virtio-scsi-test.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/virtio-scsi-test.c b/tests/virtio-scsi-test.c
> index 79088bb..94d75b1 100644
> --- a/tests/virtio-scsi-test.c
> +++ b/tests/virtio-scsi-test.c
> @@ -64,6 +64,7 @@ static void qvirtio_scsi_pci_free(QVirtIOSCSI *vs)
>  qvirtio_pci_device_disable(container_of(vs->dev, QVirtioPCIDevice, 
> vdev));
>  g_free(vs->dev);
>  qpci_free_pc(vs->bus);
> +g_free(vs);
>  }
>  
>  static uint64_t qvirtio_scsi_alloc(QVirtIOSCSI *vs, size_t alloc_size,

[Qemu-devel] [PATCH v4 1/6] tests: fix memory leak in virtio-scsi-test

2016-10-14 Thread Laurent Vivier 
vs is allocated in qvirtio_scsi_pci_init() and never freed.

Signed-off-by: Laurent Vivier 
---
 tests/virtio-scsi-test.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/virtio-scsi-test.c b/tests/virtio-scsi-test.c
index 79088bb..94d75b1 100644
--- a/tests/virtio-scsi-test.c
+++ b/tests/virtio-scsi-test.c
@@ -64,6 +64,7 @@ static void qvirtio_scsi_pci_free(QVirtIOSCSI *vs)
 qvirtio_pci_device_disable(container_of(vs->dev, QVirtioPCIDevice, vdev));
 g_free(vs->dev);
 qpci_free_pc(vs->bus);
+g_free(vs);
 }
 
 static uint64_t qvirtio_scsi_alloc(QVirtIOSCSI *vs, size_t alloc_size,
-- 
2.7.4