Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling
On Fri, 9 Jun 2017 11:13:50 +0200 Pradeep Jagadeeshwrote: > On 6/9/2017 11:07 AM, Greg Kurz wrote: > > GEN qmp-commands.h > > /tmp/qemu-test/src/qapi-schema.json:85: No such file or directory: > > qapi/fsdev.json > > Makefile:438: recipe for target 'qmp-commands.h' failed > > > > Please fix that. > Ho ok, I will have a look. > How are you trying to compile, using "make docker" options? From the QEMU source tree I do: mkdir build cd build ../configure make docker-test-mingw@fedora > > > Thanks > Pradeep > pgpYui2ARcT8F.pgp Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling
On 6/9/2017 11:07 AM, Greg Kurz wrote: GEN qmp-commands.h /tmp/qemu-test/src/qapi-schema.json:85: No such file or directory: qapi/fsdev.json Makefile:438: recipe for target 'qmp-commands.h' failed Please fix that. Ho ok, I will have a look. How are you trying to compile, using "make docker" options? Thanks Pradeep
Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling
On Fri, 9 Jun 2017 10:31:58 +0200 Pradeep Jagadeeshwrote: > On 6/8/2017 6:49 PM, Greg Kurz wrote: > > On Thu, 18 May 2017 15:30:06 +0200 > > Pradeep Jagadeesh wrote: > > > >> On 5/17/2017 7:09 PM, Eric Blake wrote: > >>> On 05/17/2017 11:29 AM, Greg Kurz wrote: > >>> > > > > First point: is fsdev a Linux-only feature, or can it be compiled on > > BSD? If it is Linux-only, then compiling a stub for Windows will still > > leave BSD broken, and your #ifdef is wrong. Fixing compilation on mingw > > is nice, but not the only platform to worry about. > > > > fsdev compilation currently depends on CONFIG_VIRTFS which is a > Linux-only > feature for the moment. There was a tentative to support it on Windows > hosts > two years ago but it stayed at the RFC stage. > > But even on Linux hosts, the current fsdev implementation also depends on > the target supporting PCI and VIRTIO. We have a fsdev/qemu-fsdev-dummy.c > file to put stubs so that we don't pull all the code for such targets. > > Maybe this could be reused for the above stubs as well ? > >>> > >>> That helps. The stub should live in qemu-fsdev-dummy.c (where it > >>> shouldn't need any #ifdef, because that file is only compiled when the > >>> condition is false), and... > >>> > > > Second point: if fsdev is indeed a platform-specific feature, then we > > don't want to advertise the QMP commands that are useless when running > > on a platform that doesn't support it. Anywhere you have to add a stub > > for compilation means you ALSO need to patch monitor.c to unregister the > > command from being advertised as a valid QMP command. (If you used > > #ifdef __LINUX__ to guard the working version, and #ifndef __LINUX__ to > > declare the stub, then the monitor.c needs an #ifndef section within > > qmp_unregister_commands_hack() to tell QMP to not advertise the stubs.) > > > >>> > >>> monitor.c should wrap the unregister under #ifndef CONFIG_VIRTFS (rather > >>> than a particular platform name). > >> I did unregister the functions as mentioned above in monitor.c. But it > >> does not address the issue when I run "make docker-test-mingw@fedora". > > > > What issue is this ? > > > > I cannot even run this with your unmodified series (please note that I > > always build out-of-tree). > The issue is when I cross build the qemu, I was facing the compilation > issue. Even it failed in patchew. So, I had to add the dummy functions > in monitor.c and qmp.c. > I see no dummy functions in monitor.c ... As said above, I cannot even reach that point with my out-of-tree build setup: GEN qmp-commands.h /tmp/qemu-test/src/qapi-schema.json:85: No such file or directory: qapi/fsdev.json Makefile:438: recipe for target 'qmp-commands.h' failed Please fix that. > -Pradeep > >> I think the VIRTFS is still enabled. > >> Only having dummy functions even in qmp.c addresses the issue. > >> > >> Regards, > >> Pradeep > >>> > >> > >> > > > pgp8LixlXYvmd.pgp Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling
On 6/8/2017 6:49 PM, Greg Kurz wrote: On Thu, 18 May 2017 15:30:06 +0200 Pradeep Jagadeeshwrote: On 5/17/2017 7:09 PM, Eric Blake wrote: On 05/17/2017 11:29 AM, Greg Kurz wrote: First point: is fsdev a Linux-only feature, or can it be compiled on BSD? If it is Linux-only, then compiling a stub for Windows will still leave BSD broken, and your #ifdef is wrong. Fixing compilation on mingw is nice, but not the only platform to worry about. fsdev compilation currently depends on CONFIG_VIRTFS which is a Linux-only feature for the moment. There was a tentative to support it on Windows hosts two years ago but it stayed at the RFC stage. But even on Linux hosts, the current fsdev implementation also depends on the target supporting PCI and VIRTIO. We have a fsdev/qemu-fsdev-dummy.c file to put stubs so that we don't pull all the code for such targets. Maybe this could be reused for the above stubs as well ? That helps. The stub should live in qemu-fsdev-dummy.c (where it shouldn't need any #ifdef, because that file is only compiled when the condition is false), and... Second point: if fsdev is indeed a platform-specific feature, then we don't want to advertise the QMP commands that are useless when running on a platform that doesn't support it. Anywhere you have to add a stub for compilation means you ALSO need to patch monitor.c to unregister the command from being advertised as a valid QMP command. (If you used #ifdef __LINUX__ to guard the working version, and #ifndef __LINUX__ to declare the stub, then the monitor.c needs an #ifndef section within qmp_unregister_commands_hack() to tell QMP to not advertise the stubs.) monitor.c should wrap the unregister under #ifndef CONFIG_VIRTFS (rather than a particular platform name). I did unregister the functions as mentioned above in monitor.c. But it does not address the issue when I run "make docker-test-mingw@fedora". What issue is this ? I cannot even run this with your unmodified series (please note that I always build out-of-tree). The issue is when I cross build the qemu, I was facing the compilation issue. Even it failed in patchew. So, I had to add the dummy functions in monitor.c and qmp.c. -Pradeep I think the VIRTFS is still enabled. Only having dummy functions even in qmp.c addresses the issue. Regards, Pradeep
Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling
On Thu, 18 May 2017 15:30:06 +0200 Pradeep Jagadeeshwrote: > On 5/17/2017 7:09 PM, Eric Blake wrote: > > On 05/17/2017 11:29 AM, Greg Kurz wrote: > > > >>> > >>> First point: is fsdev a Linux-only feature, or can it be compiled on > >>> BSD? If it is Linux-only, then compiling a stub for Windows will still > >>> leave BSD broken, and your #ifdef is wrong. Fixing compilation on mingw > >>> is nice, but not the only platform to worry about. > >>> > >> > >> fsdev compilation currently depends on CONFIG_VIRTFS which is a Linux-only > >> feature for the moment. There was a tentative to support it on Windows > >> hosts > >> two years ago but it stayed at the RFC stage. > >> > >> But even on Linux hosts, the current fsdev implementation also depends on > >> the target supporting PCI and VIRTIO. We have a fsdev/qemu-fsdev-dummy.c > >> file to put stubs so that we don't pull all the code for such targets. > >> > >> Maybe this could be reused for the above stubs as well ? > > > > That helps. The stub should live in qemu-fsdev-dummy.c (where it > > shouldn't need any #ifdef, because that file is only compiled when the > > condition is false), and... > > > >> > >>> Second point: if fsdev is indeed a platform-specific feature, then we > >>> don't want to advertise the QMP commands that are useless when running > >>> on a platform that doesn't support it. Anywhere you have to add a stub > >>> for compilation means you ALSO need to patch monitor.c to unregister the > >>> command from being advertised as a valid QMP command. (If you used > >>> #ifdef __LINUX__ to guard the working version, and #ifndef __LINUX__ to > >>> declare the stub, then the monitor.c needs an #ifndef section within > >>> qmp_unregister_commands_hack() to tell QMP to not advertise the stubs.) > > > > monitor.c should wrap the unregister under #ifndef CONFIG_VIRTFS (rather > > than a particular platform name). > I did unregister the functions as mentioned above in monitor.c. But it > does not address the issue when I run "make docker-test-mingw@fedora". What issue is this ? I cannot even run this with your unmodified series (please note that I always build out-of-tree). > I think the VIRTFS is still enabled. > Only having dummy functions even in qmp.c addresses the issue. > > Regards, > Pradeep > > > > pgpP0McT6cVbe.pgp Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling
On 5/17/2017 7:09 PM, Eric Blake wrote: On 05/17/2017 11:29 AM, Greg Kurz wrote: First point: is fsdev a Linux-only feature, or can it be compiled on BSD? If it is Linux-only, then compiling a stub for Windows will still leave BSD broken, and your #ifdef is wrong. Fixing compilation on mingw is nice, but not the only platform to worry about. fsdev compilation currently depends on CONFIG_VIRTFS which is a Linux-only feature for the moment. There was a tentative to support it on Windows hosts two years ago but it stayed at the RFC stage. But even on Linux hosts, the current fsdev implementation also depends on the target supporting PCI and VIRTIO. We have a fsdev/qemu-fsdev-dummy.c file to put stubs so that we don't pull all the code for such targets. Maybe this could be reused for the above stubs as well ? That helps. The stub should live in qemu-fsdev-dummy.c (where it shouldn't need any #ifdef, because that file is only compiled when the condition is false), and... Second point: if fsdev is indeed a platform-specific feature, then we don't want to advertise the QMP commands that are useless when running on a platform that doesn't support it. Anywhere you have to add a stub for compilation means you ALSO need to patch monitor.c to unregister the command from being advertised as a valid QMP command. (If you used #ifdef __LINUX__ to guard the working version, and #ifndef __LINUX__ to declare the stub, then the monitor.c needs an #ifndef section within qmp_unregister_commands_hack() to tell QMP to not advertise the stubs.) monitor.c should wrap the unregister under #ifndef CONFIG_VIRTFS (rather than a particular platform name). I did unregister the functions as mentioned above in monitor.c. But it does not address the issue when I run "make docker-test-mingw@fedora". I think the VIRTFS is still enabled. Only having dummy functions even in qmp.c addresses the issue. Regards, Pradeep
Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling
On 05/17/2017 11:29 AM, Greg Kurz wrote: >> >> First point: is fsdev a Linux-only feature, or can it be compiled on >> BSD? If it is Linux-only, then compiling a stub for Windows will still >> leave BSD broken, and your #ifdef is wrong. Fixing compilation on mingw >> is nice, but not the only platform to worry about. >> > > fsdev compilation currently depends on CONFIG_VIRTFS which is a Linux-only > feature for the moment. There was a tentative to support it on Windows hosts > two years ago but it stayed at the RFC stage. > > But even on Linux hosts, the current fsdev implementation also depends on > the target supporting PCI and VIRTIO. We have a fsdev/qemu-fsdev-dummy.c > file to put stubs so that we don't pull all the code for such targets. > > Maybe this could be reused for the above stubs as well ? That helps. The stub should live in qemu-fsdev-dummy.c (where it shouldn't need any #ifdef, because that file is only compiled when the condition is false), and... > >> Second point: if fsdev is indeed a platform-specific feature, then we >> don't want to advertise the QMP commands that are useless when running >> on a platform that doesn't support it. Anywhere you have to add a stub >> for compilation means you ALSO need to patch monitor.c to unregister the >> command from being advertised as a valid QMP command. (If you used >> #ifdef __LINUX__ to guard the working version, and #ifndef __LINUX__ to >> declare the stub, then the monitor.c needs an #ifndef section within >> qmp_unregister_commands_hack() to tell QMP to not advertise the stubs.) monitor.c should wrap the unregister under #ifndef CONFIG_VIRTFS (rather than a particular platform name). -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org signature.asc Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling
On Wed, 17 May 2017 10:28:33 -0500 Eric Blakewrote: > On 05/17/2017 09:53 AM, Pradeep Jagadeesh wrote: > > >>> +#ifdef _WIN64 > >>> + > >>> +void qmp_fsdev_set_io_throttle(IOThrottle *arg, Error **errp) > >>> +{ > >>> + return; > >>> +} > >>> + > >>> +IOThrottleList *qmp_query_fsdev_io_throttle(Error **errp) > >>> +{ > >>> +abort(); > >>> +} > >>> + > >>> +#endif > >> > >> I think you're missing an addition to monitor.c > >> qmp_unregister_commands_hack() if you intend for this command to be > >> available only on non-windows platforms (and is your #ifdef the correct > >> name, or is this a Linux-only feature rather than a non-windows feature). > > I had to add this one here because, I was getting some error when I > > cross compile for Windows. But I do not have any idea about, do I need > > to add in monitor.c or not. > > First point: is fsdev a Linux-only feature, or can it be compiled on > BSD? If it is Linux-only, then compiling a stub for Windows will still > leave BSD broken, and your #ifdef is wrong. Fixing compilation on mingw > is nice, but not the only platform to worry about. > fsdev compilation currently depends on CONFIG_VIRTFS which is a Linux-only feature for the moment. There was a tentative to support it on Windows hosts two years ago but it stayed at the RFC stage. But even on Linux hosts, the current fsdev implementation also depends on the target supporting PCI and VIRTIO. We have a fsdev/qemu-fsdev-dummy.c file to put stubs so that we don't pull all the code for such targets. Maybe this could be reused for the above stubs as well ? > Second point: if fsdev is indeed a platform-specific feature, then we > don't want to advertise the QMP commands that are useless when running > on a platform that doesn't support it. Anywhere you have to add a stub > for compilation means you ALSO need to patch monitor.c to unregister the > command from being advertised as a valid QMP command. (If you used > #ifdef __LINUX__ to guard the working version, and #ifndef __LINUX__ to > declare the stub, then the monitor.c needs an #ifndef section within > qmp_unregister_commands_hack() to tell QMP to not advertise the stubs.) > pgpb1VkvTR2t8.pgp Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling
On 05/17/2017 09:53 AM, Pradeep Jagadeesh wrote: >>> +#ifdef _WIN64 >>> + >>> +void qmp_fsdev_set_io_throttle(IOThrottle *arg, Error **errp) >>> +{ >>> + return; >>> +} >>> + >>> +IOThrottleList *qmp_query_fsdev_io_throttle(Error **errp) >>> +{ >>> +abort(); >>> +} >>> + >>> +#endif >> >> I think you're missing an addition to monitor.c >> qmp_unregister_commands_hack() if you intend for this command to be >> available only on non-windows platforms (and is your #ifdef the correct >> name, or is this a Linux-only feature rather than a non-windows feature). > I had to add this one here because, I was getting some error when I > cross compile for Windows. But I do not have any idea about, do I need > to add in monitor.c or not. First point: is fsdev a Linux-only feature, or can it be compiled on BSD? If it is Linux-only, then compiling a stub for Windows will still leave BSD broken, and your #ifdef is wrong. Fixing compilation on mingw is nice, but not the only platform to worry about. Second point: if fsdev is indeed a platform-specific feature, then we don't want to advertise the QMP commands that are useless when running on a platform that doesn't support it. Anywhere you have to add a stub for compilation means you ALSO need to patch monitor.c to unregister the command from being advertised as a valid QMP command. (If you used #ifdef __LINUX__ to guard the working version, and #ifndef __LINUX__ to declare the stub, then the monitor.c needs an #ifndef section within qmp_unregister_commands_hack() to tell QMP to not advertise the stubs.) -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org signature.asc Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling
On 5/10/2017 10:00 PM, Eric Blake wrote: On 05/10/2017 03:41 AM, Pradeep Jagadeesh wrote: This patch enables qmp interfaces for the fsdev devices. This provides two interfaces one for querying info of all the fsdev devices. The second one to set the IO limits for the required fsdev device. Signed-off-by: Pradeep Jagadeesh--- +++ b/qmp.c @@ -130,6 +130,21 @@ void qmp_cpu_add(int64_t id, Error **errp) } } +#ifdef _WIN64 + +void qmp_fsdev_set_io_throttle(IOThrottle *arg, Error **errp) +{ + return; +} + +IOThrottleList *qmp_query_fsdev_io_throttle(Error **errp) +{ +abort(); +} + +#endif I think you're missing an addition to monitor.c qmp_unregister_commands_hack() if you intend for this command to be available only on non-windows platforms (and is your #ifdef the correct name, or is this a Linux-only feature rather than a non-windows feature). I had to add this one here because, I was getting some error when I cross compile for Windows. But I do not have any idea about, do I need to add in monitor.c or not. Regards, Pradeep
Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling
On 05/10/2017 03:41 AM, Pradeep Jagadeesh wrote: > This patch enables qmp interfaces for the fsdev > devices. This provides two interfaces one > for querying info of all the fsdev devices. The second one > to set the IO limits for the required fsdev device. > > Signed-off-by: Pradeep Jagadeesh> --- > +++ b/qmp.c > @@ -130,6 +130,21 @@ void qmp_cpu_add(int64_t id, Error **errp) > } > } > > +#ifdef _WIN64 > + > +void qmp_fsdev_set_io_throttle(IOThrottle *arg, Error **errp) > +{ > + return; > +} > + > +IOThrottleList *qmp_query_fsdev_io_throttle(Error **errp) > +{ > +abort(); > +} > + > +#endif I think you're missing an addition to monitor.c qmp_unregister_commands_hack() if you intend for this command to be available only on non-windows platforms (and is your #ifdef the correct name, or is this a Linux-only feature rather than a non-windows feature). -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org signature.asc Description: OpenPGP digital signature
[Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling
This patch enables qmp interfaces for the fsdev devices. This provides two interfaces one for querying info of all the fsdev devices. The second one to set the IO limits for the required fsdev device. Signed-off-by: Pradeep Jagadeesh--- Makefile| 3 ++ fsdev/qemu-fsdev-dummy.c| 10 ++ fsdev/qemu-fsdev-throttle.c | 75 fsdev/qemu-fsdev-throttle.h | 12 +++ fsdev/qemu-fsdev.c | 37 hmp-commands-info.hx| 19 ++ hmp-commands.hx | 19 ++ hmp.c | 67 hmp.h | 4 +++ qapi-schema.json| 3 ++ qapi/fsdev.json | 84 + qmp.c | 15 12 files changed, 348 insertions(+) create mode 100644 qapi/fsdev.json diff --git a/Makefile b/Makefile index 31d41a7..7b928d9 100644 --- a/Makefile +++ b/Makefile @@ -414,6 +414,9 @@ qapi-modules = $(SRC_PATH)/qapi-schema.json $(SRC_PATH)/qapi/common.json \ $(SRC_PATH)/qapi/event.json $(SRC_PATH)/qapi/introspect.json \ $(SRC_PATH)/qapi/crypto.json $(SRC_PATH)/qapi/rocker.json \ $(SRC_PATH)/qapi/trace.json +ifdef CONFIG_VIRTFS +qapi-modules += $(SRC_PATH)/qapi/fsdev.json +endif qapi-types.c qapi-types.h :\ $(qapi-modules) $(SRC_PATH)/scripts/qapi-types.py $(qapi-py) diff --git a/fsdev/qemu-fsdev-dummy.c b/fsdev/qemu-fsdev-dummy.c index 6dc0fbc..f33305d 100644 --- a/fsdev/qemu-fsdev-dummy.c +++ b/fsdev/qemu-fsdev-dummy.c @@ -19,3 +19,13 @@ int qemu_fsdev_add(QemuOpts *opts) { return 0; } + +void qmp_fsdev_set_io_throttle(IOThrottle *arg, Error **errp) +{ + return; +} + +IOThrottleList *qmp_query_fsdev_io_throttle(Error **errp) +{ +abort(); +} diff --git a/fsdev/qemu-fsdev-throttle.c b/fsdev/qemu-fsdev-throttle.c index db386a7..ccbdfbd 100644 --- a/fsdev/qemu-fsdev-throttle.c +++ b/fsdev/qemu-fsdev-throttle.c @@ -29,6 +29,81 @@ static void fsdev_throttle_write_timer_cb(void *opaque) qemu_co_enter_next(>throttled_reqs[true]); } +void fsdev_set_io_throttle(IOThrottle *arg, FsThrottle *fst, Error **errp) +{ +ThrottleConfig cfg; + +qmp_set_io_throttle(, arg); + +if (throttle_is_valid(, errp)) { +fst->cfg = cfg; +fsdev_throttle_init(fst); +} +} + +void fsdev_get_io_throttle(FsThrottle *fst, IOThrottle **fs9pcfg, + char *fsdevice, Error **errp) +{ + +ThrottleConfig cfg = fst->cfg; +IOThrottle *fscfg = g_malloc0(sizeof(*fscfg)); + +fscfg->has_id = true; +fscfg->id = g_strdup(fsdevice); +fscfg->bps = cfg.buckets[THROTTLE_BPS_TOTAL].avg; +fscfg->bps_rd = cfg.buckets[THROTTLE_BPS_READ].avg; +fscfg->bps_wr = cfg.buckets[THROTTLE_BPS_WRITE].avg; + +fscfg->iops = cfg.buckets[THROTTLE_OPS_TOTAL].avg; +fscfg->iops_rd = cfg.buckets[THROTTLE_OPS_READ].avg; +fscfg->iops_wr = cfg.buckets[THROTTLE_OPS_WRITE].avg; + +fscfg->has_bps_max = cfg.buckets[THROTTLE_BPS_TOTAL].max; +fscfg->bps_max = cfg.buckets[THROTTLE_BPS_TOTAL].max; +fscfg->has_bps_rd_max = cfg.buckets[THROTTLE_BPS_READ].max; +fscfg->bps_rd_max = cfg.buckets[THROTTLE_BPS_READ].max; +fscfg->has_bps_wr_max = cfg.buckets[THROTTLE_BPS_WRITE].max; +fscfg->bps_wr_max = cfg.buckets[THROTTLE_BPS_WRITE].max; + +fscfg->has_iops_max= cfg.buckets[THROTTLE_OPS_TOTAL].max; +fscfg->iops_max= cfg.buckets[THROTTLE_OPS_TOTAL].max; +fscfg->has_iops_rd_max = cfg.buckets[THROTTLE_OPS_READ].max; +fscfg->iops_rd_max = cfg.buckets[THROTTLE_OPS_READ].max; +fscfg->has_iops_wr_max = cfg.buckets[THROTTLE_OPS_WRITE].max; +fscfg->iops_wr_max = cfg.buckets[THROTTLE_OPS_WRITE].max; + +fscfg->has_bps_max_length = fscfg->has_bps_max; +fscfg->bps_max_length = + cfg.buckets[THROTTLE_BPS_TOTAL].burst_length; +fscfg->has_bps_rd_max_length = fscfg->has_bps_rd_max; +fscfg->bps_rd_max_length = + cfg.buckets[THROTTLE_BPS_READ].burst_length; +fscfg->has_bps_wr_max_length = fscfg->has_bps_wr_max; +fscfg->bps_wr_max_length = + cfg.buckets[THROTTLE_BPS_WRITE].burst_length; + +fscfg->has_iops_max_length= fscfg->has_iops_max; +fscfg->iops_max_length= + cfg.buckets[THROTTLE_OPS_TOTAL].burst_length; +fscfg->has_iops_rd_max_length = fscfg->has_iops_rd_max; +fscfg->iops_rd_max_length = + cfg.buckets[THROTTLE_OPS_READ].burst_length; +fscfg->has_iops_wr_max_length = fscfg->has_iops_wr_max; +fscfg->iops_wr_max_length = + cfg.buckets[THROTTLE_OPS_WRITE].burst_length; + +fscfg->bps_max_length = cfg.buckets[THROTTLE_BPS_TOTAL].burst_length; +fscfg->bps_rd_max_length = cfg.buckets[THROTTLE_BPS_READ].burst_length; +fscfg->bps_wr_max_length =