Re: [Qemu-devel] [PATCH v5 0/4] monitor: suggest running "help" for command errors

2015-06-16 Thread Markus Armbruster
Applied to my (badly named) qapi-next branch, thanks!



Re: [Qemu-devel] [PATCH v5 0/4] monitor: suggest running "help" for command errors

2015-06-11 Thread Luiz Capitulino
On Mon, 08 Jun 2015 10:53:23 +0200
Markus Armbruster  wrote:

> Copying HMP maintainer Luiz.
> 
> Series
> Reviewed-by: Markus Armbruster 
> 
> Bandan, thanks for your patience.
> 
> Luiz, my monitor/QMP queue is currently empty, but if it fills up before
> you get around to doing a monitor/HMP pull request, I'm happy to take
> this series along, if it gets your Acked-by.

I'd be immensely grateful if you pick this series along with the
other ones, as we've spoken in pvt. Thanks a lot Markus for your
help!

Acked-by: Luiz Capitulino 




Re: [Qemu-devel] [PATCH v5 0/4] monitor: suggest running "help" for command errors

2015-06-08 Thread Markus Armbruster
Copying HMP maintainer Luiz.

Series
Reviewed-by: Markus Armbruster 

Bandan, thanks for your patience.

Luiz, my monitor/QMP queue is currently empty, but if it fills up before
you get around to doing a monitor/HMP pull request, I'm happy to take
this series along, if it gets your Acked-by.



[Qemu-devel] [PATCH v5 0/4] monitor: suggest running "help" for command errors

2015-06-03 Thread Bandan Das
v5:
Move "monitor: remove debug prints" to first in the series
Minor fixes to comments and commit messages

v4:
Better name for cmdline index pointer [1/4]
Change comment for monitor_parse_command as suggested in review [1/4]
Fix potential compilation failure in debug print [1/4]
New - Fix failure path for argument type "S" [3/4]
New - Remove debug prints [4/4]

v3:
Track the current location directly in the command line [1/2]
Fix potential qdict leak [1/2]
Document char **endp [1/2]
Rebase on top of changes and add reviewed-by [2/2]

v2:
Split up the command name and arguments parsing into
separate functions. [1/2]
Skip checking for failures with commands that use the .cmd_new
interface or the async interface since they are scheduled
for removal [2/2]

Bandan Das (4):
  monitor: remove debug prints
  monitor: cleanup parsing of cmd name and cmd arguments
  monitor: Point to "help" command on syntax error
  monitor: Fix failure path for "S" argument

 monitor.c | 122 +++---
 1 file changed, 61 insertions(+), 61 deletions(-)

-- 
2.1.0