Re: [Qemu-devel] [PATCH v5 1/5] test-keyval: fix leaks

[Markus Armbruster]

Markus Armbruster  writes:

> Eric Blake  writes:
>
>> On 05/03/2017 05:38 PM, Marc-André Lureau wrote:
>>> Spotted by ASAN.
>>> 
>>> Signed-off-by: Marc-André Lureau 
>>> ---
>>>  tests/test-keyval.c | 4 
>>>  1 file changed, 4 insertions(+)
>>
>> Reviewed-by: Eric blake 
>
> This is in qapi-next already.  I'm adding the R-by now.

Actually, I'm replacing the commit in my tree by this one, because that
results in a simpler, cleaner commit message: I don't have to note the
tweaks I applied in my tree, and you in your v5.  Thanks!

Re: [Qemu-devel] [PATCH v5 1/5] test-keyval: fix leaks

[Markus Armbruster]

Eric Blake  writes:

> On 05/03/2017 05:38 PM, Marc-André Lureau wrote:
>> Spotted by ASAN.
>> 
>> Signed-off-by: Marc-André Lureau 
>> ---
>>  tests/test-keyval.c | 4 
>>  1 file changed, 4 insertions(+)
>
> Reviewed-by: Eric blake 

This is in qapi-next already.  I'm adding the R-by now.

Re: [Qemu-devel] [PATCH v5 1/5] test-keyval: fix leaks

[Eric Blake]

On 05/03/2017 05:38 PM, Marc-André Lureau wrote:
> Spotted by ASAN.
> 
> Signed-off-by: Marc-André Lureau 
> ---
>  tests/test-keyval.c | 4 
>  1 file changed, 4 insertions(+)

Reviewed-by: Eric blake 

> 
> diff --git a/tests/test-keyval.c b/tests/test-keyval.c
> index ba19560a22..c556b1b117 100644
> --- a/tests/test-keyval.c
> +++ b/tests/test-keyval.c
> @@ -628,6 +628,7 @@ static void test_keyval_visit_alternate(void)
>  visit_type_AltNumStr(v, "a", , _abort);
>  g_assert_cmpint(ans->type, ==, QTYPE_QSTRING);
>  g_assert_cmpstr(ans->u.s, ==, "1");
> +qapi_free_AltNumStr(ans);
>  visit_type_AltNumInt(v, "a", , );
>  error_free_or_abort();
>  visit_end_struct(v, NULL);
> @@ -651,9 +652,12 @@ static void test_keyval_visit_any(void)
>  g_assert(qlist);
>  qstr = qobject_to_qstring(qlist_pop(qlist));
>  g_assert_cmpstr(qstring_get_str(qstr), ==, "null");
> +QDECREF(qstr);
>  qstr = qobject_to_qstring(qlist_pop(qlist));
>  g_assert_cmpstr(qstring_get_str(qstr), ==, "1");
>  g_assert(qlist_empty(qlist));
> +QDECREF(qstr);
> +qobject_decref(any);
>  visit_check_struct(v, _abort);
>  visit_end_struct(v, NULL);
>  visit_free(v);
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.   +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



signature.asc
Description: OpenPGP digital signature

[Qemu-devel] [PATCH v5 1/5] test-keyval: fix leaks

[Marc-André Lureau]

Spotted by ASAN.

Signed-off-by: Marc-André Lureau 
---
 tests/test-keyval.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/tests/test-keyval.c b/tests/test-keyval.c
index ba19560a22..c556b1b117 100644
--- a/tests/test-keyval.c
+++ b/tests/test-keyval.c
@@ -628,6 +628,7 @@ static void test_keyval_visit_alternate(void)
 visit_type_AltNumStr(v, "a", , _abort);
 g_assert_cmpint(ans->type, ==, QTYPE_QSTRING);
 g_assert_cmpstr(ans->u.s, ==, "1");
+qapi_free_AltNumStr(ans);
 visit_type_AltNumInt(v, "a", , );
 error_free_or_abort();
 visit_end_struct(v, NULL);
@@ -651,9 +652,12 @@ static void test_keyval_visit_any(void)
 g_assert(qlist);
 qstr = qobject_to_qstring(qlist_pop(qlist));
 g_assert_cmpstr(qstring_get_str(qstr), ==, "null");
+QDECREF(qstr);
 qstr = qobject_to_qstring(qlist_pop(qlist));
 g_assert_cmpstr(qstring_get_str(qstr), ==, "1");
 g_assert(qlist_empty(qlist));
+QDECREF(qstr);
+qobject_decref(any);
 visit_check_struct(v, _abort);
 visit_end_struct(v, NULL);
 visit_free(v);
-- 
2.12.0.191.gc5d8de91d