Re: [Qemu-devel] [PATCH v5 5/5] dump: fix memory_mapping_filter leak

[Michael Tokarev]

04.05.2017 01:38, Marc-André Lureau wrote:
> Spotted by ASAN.

Applied to -trivial. Thanks!

/mjt

Re: [Qemu-devel] [PATCH v5 5/5] dump: fix memory_mapping_filter leak

[Marc-André Lureau]

On Fri, May 26, 2017 at 3:03 PM Marc-André Lureau <
marcandre.lur...@gmail.com> wrote:

> Hi
>
> On Thu, May 4, 2017 at 2:42 AM Marc-André Lureau <
> marcandre.lur...@redhat.com> wrote:
>
>> Spotted by ASAN.
>>
>> Signed-off-by: Marc-André Lureau 
>> ---
>>  memory_mapping.c | 1 +
>>
>
> No maintainer for this file, Wen, Paolo?
>

CC qemu-trivial

thanks


>
>
>
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/memory_mapping.c b/memory_mapping.c
>> index 6a39d71da2..a5d38552a6 100644
>> --- a/memory_mapping.c
>> +++ b/memory_mapping.c
>> @@ -337,6 +337,7 @@ void memory_mapping_filter(MemoryMappingList *list,
>> int64_t begin,
>>  if (cur->phys_addr >= begin + length ||
>>  cur->phys_addr + cur->length <= begin) {
>>  QTAILQ_REMOVE(>head, cur, next);
>> +g_free(cur);
>>  list->num--;
>>  continue;
>>  }
>> --
>> 2.12.0.191.gc5d8de91d
>>
>>
>> --
> Marc-André Lureau
>
-- 
Marc-André Lureau

Re: [Qemu-devel] [PATCH v5 5/5] dump: fix memory_mapping_filter leak

[Marc-André Lureau]

Hi

On Thu, May 4, 2017 at 2:42 AM Marc-André Lureau <
marcandre.lur...@redhat.com> wrote:

> Spotted by ASAN.
>
> Signed-off-by: Marc-André Lureau 
> ---
>  memory_mapping.c | 1 +
>

No maintainer for this file, Wen, Paolo?



>  1 file changed, 1 insertion(+)
>
> diff --git a/memory_mapping.c b/memory_mapping.c
> index 6a39d71da2..a5d38552a6 100644
> --- a/memory_mapping.c
> +++ b/memory_mapping.c
> @@ -337,6 +337,7 @@ void memory_mapping_filter(MemoryMappingList *list,
> int64_t begin,
>  if (cur->phys_addr >= begin + length ||
>  cur->phys_addr + cur->length <= begin) {
>  QTAILQ_REMOVE(>head, cur, next);
> +g_free(cur);
>  list->num--;
>  continue;
>  }
> --
> 2.12.0.191.gc5d8de91d
>
>
> --
Marc-André Lureau

[Qemu-devel] [PATCH v5 5/5] dump: fix memory_mapping_filter leak

[Marc-André Lureau]

Spotted by ASAN.

Signed-off-by: Marc-André Lureau 
---
 memory_mapping.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/memory_mapping.c b/memory_mapping.c
index 6a39d71da2..a5d38552a6 100644
--- a/memory_mapping.c
+++ b/memory_mapping.c
@@ -337,6 +337,7 @@ void memory_mapping_filter(MemoryMappingList *list, int64_t 
begin,
 if (cur->phys_addr >= begin + length ||
 cur->phys_addr + cur->length <= begin) {
 QTAILQ_REMOVE(>head, cur, next);
+g_free(cur);
 list->num--;
 continue;
 }
-- 
2.12.0.191.gc5d8de91d