Re: [Qemu-devel] [PATCH v7 0/3] block: Introduce null drivers
On Mon, Sep 15, 2014 at 11:47:02AM -0600, Eric Blake wrote: On 09/11/2014 12:09 AM, Fam Zheng wrote: v7: Add Benoît's rev-by line in patch 2. Improved help text in patch 1. (Benoît) v6: Don't inherit from BlockdevOptionsFile. (Stefan) Use .bdrv_co_readv instead of .bdrv_read. (Kevin) Sort items in qapi schema definitions in patch 2 3. Fam Zheng (3): block: Introduce null drivers qapi: Sort BlockdevDriver enum data list qapi: Sort items in BlockdevOptions definition Series: Reviewed-by: Eric Blake ebl...@redhat.com In order for Reviewed-by to get picked up by my scripts, it needs to be in the first column. This prevents false positives like quoted commit messages from polluting the Reviewed-by tags. In the future, please reply to the cover letter with Reviewed-by in the first column. It is not necessary to say Series:. Thanks, Stefan pgpCPNDgpjP2t.pgp Description: PGP signature
Re: [Qemu-devel] [PATCH v7 0/3] block: Introduce null drivers
On 09/16/2014 04:30 AM, Stefan Hajnoczi wrote: On Mon, Sep 15, 2014 at 11:47:02AM -0600, Eric Blake wrote: On 09/11/2014 12:09 AM, Fam Zheng wrote: v7: Add Benoît's rev-by line in patch 2. Improved help text in patch 1. (Benoît) v6: Don't inherit from BlockdevOptionsFile. (Stefan) Use .bdrv_co_readv instead of .bdrv_read. (Kevin) Sort items in qapi schema definitions in patch 2 3. Fam Zheng (3): block: Introduce null drivers qapi: Sort BlockdevDriver enum data list qapi: Sort items in BlockdevOptions definition Series: Reviewed-by: Eric Blake ebl...@redhat.com In order for Reviewed-by to get picked up by my scripts, it needs to be in the first column. This prevents false positives like quoted commit messages from polluting the Reviewed-by tags. In the future, please reply to the cover letter with Reviewed-by in the first column. It is not necessary to say Series:. Sure, will do. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH v7 0/3] block: Introduce null drivers
On Thu, Sep 11, 2014 at 02:09:55PM +0800, Fam Zheng wrote: v7: Add Benoît's rev-by line in patch 2. Improved help text in patch 1. (Benoît) v6: Don't inherit from BlockdevOptionsFile. (Stefan) Use .bdrv_co_readv instead of .bdrv_read. (Kevin) Sort items in qapi schema definitions in patch 2 3. Fam Zheng (3): block: Introduce null drivers qapi: Sort BlockdevDriver enum data list qapi: Sort items in BlockdevOptions definition block/Makefile.objs | 1 + block/null.c | 178 +++ qapi/block-core.json | 57 +++-- 3 files changed, 215 insertions(+), 21 deletions(-) create mode 100644 block/null.c -- 1.9.3 Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan pgpZ8CjpcA9gA.pgp Description: PGP signature
Re: [Qemu-devel] [PATCH v7 0/3] block: Introduce null drivers
The Thursday 11 Sep 2014 à 14:09:55 (+0800), Fam Zheng wrote : v7: Add Benoît's rev-by line in patch 2. Improved help text in patch 1. (Benoît) v6: Don't inherit from BlockdevOptionsFile. (Stefan) Use .bdrv_co_readv instead of .bdrv_read. (Kevin) Sort items in qapi schema definitions in patch 2 3. Fam Zheng (3): block: Introduce null drivers qapi: Sort BlockdevDriver enum data list qapi: Sort items in BlockdevOptions definition block/Makefile.objs | 1 + block/null.c | 178 +++ qapi/block-core.json | 57 +++-- 3 files changed, 215 insertions(+), 21 deletions(-) create mode 100644 block/null.c -- 1.9.3 I don't think I will be able to break it further. Reviewed-by: Benoît Canet benoit.ca...@nodalink.com
Re: [Qemu-devel] [PATCH v7 0/3] block: Introduce null drivers
On 09/11/2014 12:09 AM, Fam Zheng wrote: v7: Add Benoît's rev-by line in patch 2. Improved help text in patch 1. (Benoît) v6: Don't inherit from BlockdevOptionsFile. (Stefan) Use .bdrv_co_readv instead of .bdrv_read. (Kevin) Sort items in qapi schema definitions in patch 2 3. Fam Zheng (3): block: Introduce null drivers qapi: Sort BlockdevDriver enum data list qapi: Sort items in BlockdevOptions definition Series: Reviewed-by: Eric Blake ebl...@redhat.com block/Makefile.objs | 1 + block/null.c | 178 +++ qapi/block-core.json | 57 +++-- 3 files changed, 215 insertions(+), 21 deletions(-) create mode 100644 block/null.c -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signature
[Qemu-devel] [PATCH v7 0/3] block: Introduce null drivers
v7: Add Benoît's rev-by line in patch 2. Improved help text in patch 1. (Benoît) v6: Don't inherit from BlockdevOptionsFile. (Stefan) Use .bdrv_co_readv instead of .bdrv_read. (Kevin) Sort items in qapi schema definitions in patch 2 3. Fam Zheng (3): block: Introduce null drivers qapi: Sort BlockdevDriver enum data list qapi: Sort items in BlockdevOptions definition block/Makefile.objs | 1 + block/null.c | 178 +++ qapi/block-core.json | 57 +++-- 3 files changed, 215 insertions(+), 21 deletions(-) create mode 100644 block/null.c -- 1.9.3
