Re: [Qemu-devel] [PATCHv5 4/5] qemu-doc: deprecate query-cpus

[Cornelia Huck]

On Tue, 27 Feb 2018 20:06:55 +0100
Cornelia Huck  wrote:

> On Tue, 27 Feb 2018 14:41:38 +0100
> Viktor Mihajlovski  wrote:
> 
> > On 19.02.2018 15:57, Cornelia Huck wrote:  
> > > On Fri, 16 Feb 2018 17:08:40 +0100
> > > Viktor Mihajlovski  wrote:
> > > 
> > >> Start the deprecation period for QAPI query-cpus (replaced by
> > >> query-cpus-fast) beginning with 2.12.0.
> > >>
> > >> Signed-off-by: Viktor Mihajlovski 
> > >> Reviewed-by: Eric Blake 
> > >> ---
> > >>  qapi-schema.json | 4 
> > >>  qemu-doc.texi| 4 
> > >>  2 files changed, 8 insertions(+)
> > > 
> > > We need to remember updating the deprecation notes in the wiki as well.
> > > 
> > > Reviewed-by: Cornelia Huck 
> > > 
> > Let me know whether you plan on doing that or I should take a crack at it.
> >   
> 
> If I haven't managed to update it by softfreeze, feel free to do so :)

OK, added to the 2.12 changelog.

Re: [Qemu-devel] [PATCHv5 4/5] qemu-doc: deprecate query-cpus

[Cornelia Huck]

On Tue, 27 Feb 2018 14:41:38 +0100
Viktor Mihajlovski  wrote:

> On 19.02.2018 15:57, Cornelia Huck wrote:
> > On Fri, 16 Feb 2018 17:08:40 +0100
> > Viktor Mihajlovski  wrote:
> >   
> >> Start the deprecation period for QAPI query-cpus (replaced by
> >> query-cpus-fast) beginning with 2.12.0.
> >>
> >> Signed-off-by: Viktor Mihajlovski 
> >> Reviewed-by: Eric Blake 
> >> ---
> >>  qapi-schema.json | 4 
> >>  qemu-doc.texi| 4 
> >>  2 files changed, 8 insertions(+)  
> > 
> > We need to remember updating the deprecation notes in the wiki as well.
> > 
> > Reviewed-by: Cornelia Huck 
> >   
> Let me know whether you plan on doing that or I should take a crack at it.
> 

If I haven't managed to update it by softfreeze, feel free to do so :)

Re: [Qemu-devel] [PATCHv5 4/5] qemu-doc: deprecate query-cpus

[Viktor Mihajlovski]

On 19.02.2018 15:57, Cornelia Huck wrote:
> On Fri, 16 Feb 2018 17:08:40 +0100
> Viktor Mihajlovski  wrote:
> 
>> Start the deprecation period for QAPI query-cpus (replaced by
>> query-cpus-fast) beginning with 2.12.0.
>>
>> Signed-off-by: Viktor Mihajlovski 
>> Reviewed-by: Eric Blake 
>> ---
>>  qapi-schema.json | 4 
>>  qemu-doc.texi| 4 
>>  2 files changed, 8 insertions(+)
> 
> We need to remember updating the deprecation notes in the wiki as well.
> 
> Reviewed-by: Cornelia Huck 
> 
Let me know whether you plan on doing that or I should take a crack at it.

-- 
Regards,
 Viktor Mihajlovski

Re: [Qemu-devel] [PATCHv5 4/5] qemu-doc: deprecate query-cpus

[Cornelia Huck]

On Fri, 16 Feb 2018 17:08:40 +0100
Viktor Mihajlovski  wrote:

> Start the deprecation period for QAPI query-cpus (replaced by
> query-cpus-fast) beginning with 2.12.0.
> 
> Signed-off-by: Viktor Mihajlovski 
> Reviewed-by: Eric Blake 
> ---
>  qapi-schema.json | 4 
>  qemu-doc.texi| 4 
>  2 files changed, 8 insertions(+)

We need to remember updating the deprecation notes in the wiki as well.

Reviewed-by: Cornelia Huck 

[Qemu-devel] [PATCHv5 4/5] qemu-doc: deprecate query-cpus

[Viktor Mihajlovski]

Start the deprecation period for QAPI query-cpus (replaced by
query-cpus-fast) beginning with 2.12.0.

Signed-off-by: Viktor Mihajlovski 
Reviewed-by: Eric Blake 
---
 qapi-schema.json | 4 
 qemu-doc.texi| 4 
 2 files changed, 8 insertions(+)

diff --git a/qapi-schema.json b/qapi-schema.json
index e6ca63f..cd98a94 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -587,6 +587,10 @@
 #   ]
 #}
 #
+# Notes: This interface is deprecated (since 2.12.0), and it is strongly
+#recommended that you avoid using it. Use @query-cpus-fast to
+#obtain information about virtual CPUs.
+#
 ##
 { 'command': 'query-cpus', 'returns': ['CpuInfo'] }
 
diff --git a/qemu-doc.texi b/qemu-doc.texi
index 137f581..221f565 100644
--- a/qemu-doc.texi
+++ b/qemu-doc.texi
@@ -2764,6 +2764,10 @@ by the ``convert -l snapshot_param'' argument instead.
 "autoload" parameter is now ignored. All bitmaps are automatically loaded
 from qcow2 images.
 
+@subsection query-cpus (since 2.12.0)
+
+The ``query-cpus'' command is replaced by the ``query-cpus-fast'' command.
+
 @section System emulator human monitor commands
 
 @subsection host_net_add (since 2.10.0)
-- 
1.9.1