Re: [Qemu-devel] [PULL 0/4] Ide patches
On 19 January 2018 at 22:31, John Snow wrote: > The following changes since commit b384cd95eb9c6f73ad84ed1bb0717a26e29cc78f: > > Merge remote-tracking branch > 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-01-19 > 16:35:25 +) > > are available in the Git repository at: > > https://github.com/jnsnow/qemu.git tags/ide-pull-request > > for you to fetch changes up to 3161906df88a471b09c38fff9a618ff83beea0c3: > > hw/ide: Remove duplicated definitions from ahci_internal.h (2018-01-19 > 16:04:57 -0500) > > > > -- Applied, thanks. -- PMM
[Qemu-devel] [PULL 0/4] Ide patches
The following changes since commit b384cd95eb9c6f73ad84ed1bb0717a26e29cc78f: Merge remote-tracking branch 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-01-19 16:35:25 +) are available in the Git repository at: https://github.com/jnsnow/qemu.git tags/ide-pull-request for you to fetch changes up to 3161906df88a471b09c38fff9a618ff83beea0c3: hw/ide: Remove duplicated definitions from ahci_internal.h (2018-01-19 16:04:57 -0500) Anton Nefedov (3): ide: pass IDEState to trim AIO callback ide: move ide_sect_range_ok() up ide: abort TRIM operation for invalid range John Snow (1): hw/ide: Remove duplicated definitions from ahci_internal.h hw/ide/ahci_internal.h | 4 hw/ide/core.c | 53 +++--- include/hw/ide/ahci.h | 6 -- 3 files changed, 33 insertions(+), 30 deletions(-) -- 2.14.3
Re: [Qemu-devel] [PULL 0/4] Ide patches
On 18 July 2017 at 17:12, John Snow wrote: > The following changes since commit 368e708b4c95501574ab11632c7a0b8bb3ddc7e8: > > Merge remote-tracking branch > 'remotes/ehabkost/tags/x86-and-machine-pull-request' into staging (2017-07-18 > 15:24:11 +0100) > > are available in the git repository at: > > https://github.com/jnsnow/qemu.git tags/ide-pull-request > > for you to fetch changes up to ff0ca962345ecdb87c331888a806cde49936fd9f: > > tests/ahci-test: Be mean with RAM (2017-07-18 11:47:57 -0400) > > > > > > Dr. David Alan Gilbert (1): > tests/ahci-test: Be mean with RAM > > John Snow (3): > ahci: add ahci_get_num_ports > ahci: Isolate public AHCI interface > ahci: split public and private interface Applied, thanks. -- PMM
Re: [Qemu-devel] [PULL 0/4] Ide patches
On 07/18/2017 05:27 PM, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Subject: [Qemu-devel] [PULL 0/4] Ide patches > Message-id: 20170718161230.21917-1-js...@redhat.com > Type: series > > === TEST SCRIPT BEGIN === > #!/bin/bash > > BASE=base > n=1 > total=$(git log --oneline $BASE.. | wc -l) > failed=0 > > git config --local diff.renamelimit 0 > git config --local diff.renames True > > commits="$(git log --format=%H --reverse $BASE..)" > for c in $commits; do > echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." > if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; > then > failed=1 > echo > fi > n=$((n+1)) > done > > exit $failed > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > Switched to a new branch 'test' > 02dcdb3 tests/ahci-test: Be mean with RAM > e94eb50 ahci: split public and private interface > cb2c639 ahci: Isolate public AHCI interface > d77a741 ahci: add ahci_get_num_ports > > === OUTPUT BEGIN === > Checking PATCH 1/4: ahci: add ahci_get_num_ports... > Checking PATCH 2/4: ahci: Isolate public AHCI interface... > ERROR: spaces required around that '/' (ctx:VxV) > #221: FILE: include/hw/ide/ahci_public.h:88: > +uint32_t regs[ALLWINNER_AHCI_MMIO_SIZE/4]; >^ > > total: 1 errors, 0 warnings, 189 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > Checking PATCH 3/4: ahci: split public and private interface... > ERROR: spaces required around that '/' (ctx:VxV) > #800: FILE: include/hw/ide/ahci.h:88: > +uint32_t regs[ALLWINNER_AHCI_MMIO_SIZE/4]; >^ > > total: 1 errors, 0 warnings, 760 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > Checking PATCH 4/4: tests/ahci-test: Be mean with RAM... > === OUTPUT END === > > Test command exited with code: 1 > > > --- > Email generated automatically by Patchew [http://patchew.org/]. > Please send your feedback to patchew-de...@freelists.org > IMO, false positive on code movement, but I could fix this up if desired. --js
Re: [Qemu-devel] [PULL 0/4] Ide patches
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 0/4] Ide patches Message-id: 20170718161230.21917-1-js...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 02dcdb3 tests/ahci-test: Be mean with RAM e94eb50 ahci: split public and private interface cb2c639 ahci: Isolate public AHCI interface d77a741 ahci: add ahci_get_num_ports === OUTPUT BEGIN === Checking PATCH 1/4: ahci: add ahci_get_num_ports... Checking PATCH 2/4: ahci: Isolate public AHCI interface... ERROR: spaces required around that '/' (ctx:VxV) #221: FILE: include/hw/ide/ahci_public.h:88: +uint32_t regs[ALLWINNER_AHCI_MMIO_SIZE/4]; ^ total: 1 errors, 0 warnings, 189 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 3/4: ahci: split public and private interface... ERROR: spaces required around that '/' (ctx:VxV) #800: FILE: include/hw/ide/ahci.h:88: +uint32_t regs[ALLWINNER_AHCI_MMIO_SIZE/4]; ^ total: 1 errors, 0 warnings, 760 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 4/4: tests/ahci-test: Be mean with RAM... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@freelists.org
[Qemu-devel] [PULL 0/4] Ide patches
The following changes since commit 368e708b4c95501574ab11632c7a0b8bb3ddc7e8: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-and-machine-pull-request' into staging (2017-07-18 15:24:11 +0100) are available in the git repository at: https://github.com/jnsnow/qemu.git tags/ide-pull-request for you to fetch changes up to ff0ca962345ecdb87c331888a806cde49936fd9f: tests/ahci-test: Be mean with RAM (2017-07-18 11:47:57 -0400) Dr. David Alan Gilbert (1): tests/ahci-test: Be mean with RAM John Snow (3): ahci: add ahci_get_num_ports ahci: Isolate public AHCI interface ahci: split public and private interface hw/i386/pc_q35.c | 4 +- hw/ide/ahci.c | 10 +- hw/ide/ahci_internal.h | 359 + hw/ide/ich.c | 2 +- hw/mips/boston.c | 4 +- include/hw/ide/ahci.h | 320 +-- tests/ahci-test.c | 8 +- 7 files changed, 380 insertions(+), 327 deletions(-) create mode 100644 hw/ide/ahci_internal.h -- 2.9.4
Re: [Qemu-devel] [PULL 0/4] IDE patches
On 29 September 2016 at 13:15, John Snow wrote: > The following changes since commit c640f2849ee8775fe1bbd7a2772610aa77816f9f: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2016-09-28 23:02:56 +0100) > > are available in the git repository at: > > https://github.com/jnsnow/qemu.git tags/ide-pull-request > > for you to fetch changes up to ca44141d5fb801dd5903102acefd0f2d8e8bb6a1: > > ide: Fix memory leak in ide_register_restart_cb() (2016-09-29 15:50:29 > -0400) > > > > Applied, thanks. -- PMM
[Qemu-devel] [PULL 0/4] IDE patches
The following changes since commit c640f2849ee8775fe1bbd7a2772610aa77816f9f: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2016-09-28 23:02:56 +0100) are available in the git repository at: https://github.com/jnsnow/qemu.git tags/ide-pull-request for you to fetch changes up to ca44141d5fb801dd5903102acefd0f2d8e8bb6a1: ide: Fix memory leak in ide_register_restart_cb() (2016-09-29 15:50:29 -0400) Ashijeet Acharya (1): ide: Fix memory leak in ide_register_restart_cb() John Snow (2): ide: fix DMA register transitions ahci: clear aiocb in ncq_cb Thomas Huth (1): MAINTAINERS: Add some more headers to the IDE section MAINTAINERS | 1 + hw/ide/ahci.c | 1 + hw/ide/core.c | 4 ++-- hw/ide/qdev.c | 11 +++ include/hw/ide/internal.h | 1 + 5 files changed, 16 insertions(+), 2 deletions(-) -- 2.7.4
Re: [Qemu-devel] [PULL 0/4] Ide patches
On 18 July 2016 at 23:57, John Snow wrote: > The following changes since commit 3913d3707e3debfbf0d2d014a1a793394993b088: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.7-20160718' > into staging (2016-07-18 11:24:15 +0100) > > are available in the git repository at: > > https://github.com/jnsnow/qemu.git tags/ide-pull-request > > for you to fetch changes up to 3ff2f67a7c24183fcbcfe1332e5223ac6f96438c: > > block: ignore flush requests when storage is clean (2016-07-18 18:19:01 > -0400) > > > > > > Evgeny Yakovlev (4): > ide: refactor retry_unit set and clear into separate function > ide: set retry_unit for PIO and FLUSH requests > tests: in IDE and AHCI tests perform DMA write before flushing > block: ignore flush requests when storage is clean Applied, thanks. -- PMM
[Qemu-devel] [PULL 0/4] Ide patches
The following changes since commit 3913d3707e3debfbf0d2d014a1a793394993b088: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.7-20160718' into staging (2016-07-18 11:24:15 +0100) are available in the git repository at: https://github.com/jnsnow/qemu.git tags/ide-pull-request for you to fetch changes up to 3ff2f67a7c24183fcbcfe1332e5223ac6f96438c: block: ignore flush requests when storage is clean (2016-07-18 18:19:01 -0400) Evgeny Yakovlev (4): ide: refactor retry_unit set and clear into separate function ide: set retry_unit for PIO and FLUSH requests tests: in IDE and AHCI tests perform DMA write before flushing block: ignore flush requests when storage is clean block.c| 3 +++ block/io.c | 21 hw/ide/core.c | 24 +- include/block/block_int.h | 5 tests/ahci-test.c | 40 ++ tests/ide-test.c | 43 tests/qemu-iotests/026.out | 50 -- tests/qemu-iotests/026.out.nocache | 50 -- tests/qemu-iotests/071.out | 8 -- tests/qemu-iotests/089.out | 2 -- tests/qemu-iotests/141.out | 4 +-- tests/qemu-iotests/144.out | 2 +- 12 files changed, 128 insertions(+), 124 deletions(-) -- 2.7.4
Re: [Qemu-devel] [PULL 0/4] Ide patches
On 13 April 2016 at 00:36, John Snow wrote: > The following changes since commit d44122ecd0fa62d20762bdd8f214f077cb8e011b: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2016-04-12 17:47:15 +0100) > > are available in the git repository at: > > https://github.com/jnsnow/qemu.git tags/ide-pull-request > > for you to fetch changes up to 502356eeeb5fd2bdd92b2d5156e511626c1c3814: > > ide: really restart pending and in-flight atapi dma (2016-04-12 18:48:15 > -0400) > > > > Applied, thanks. -- PMM
[Qemu-devel] [PULL 0/4] Ide patches
The following changes since commit d44122ecd0fa62d20762bdd8f214f077cb8e011b: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2016-04-12 17:47:15 +0100) are available in the git repository at: https://github.com/jnsnow/qemu.git tags/ide-pull-request for you to fetch changes up to 502356eeeb5fd2bdd92b2d5156e511626c1c3814: ide: really restart pending and in-flight atapi dma (2016-04-12 18:48:15 -0400) Anthony PERARD (1): xen: Fix IDE unplug Pavel Butsykin (3): ide: don't lose pending dma state ide: restart atapi dma by re-evaluating command packet ide: really restart pending and in-flight atapi dma hw/ide/atapi.c| 26 -- hw/ide/core.c | 39 --- hw/ide/internal.h | 35 +++ hw/ide/macio.c| 2 ++ hw/ide/pci.c | 4 hw/ide/piix.c | 1 + 6 files changed, 70 insertions(+), 37 deletions(-) -- 2.4.11
Re: [Qemu-devel] [PULL 0/4] Ide patches
On 25 November 2015 at 20:25, John Snow wrote: > The following changes since commit 4b6eda626fdb8bf90472c6868d502a2ac09abeeb: > > Merge remote-tracking branch 'remotes/lalrae/tags/mips-20151124' into > staging (2015-11-24 17:05:06 +) > > are available in the git repository at: > > https://github.com/jnsnow/qemu.git tags/ide-pull-request > > for you to fetch changes up to 9c73517ca56d6611371376bd298b4b20f3ad6140: > > ide-test: fix timeouts (2015-11-25 11:37:34 -0500) > > > > > > Alberto Garcia (2): > atapi: Account for failed and invalid operations in cd_read_sector() > atapi: Fix code indentation > > John Snow (2): > ide-test: cdrom_pio_impl fixup > ide-test: fix timeouts > > hw/ide/atapi.c | 8 +--- > tests/ide-test.c | 32 +++- > 2 files changed, 28 insertions(+), 12 deletions(-) Applied, thanks. -- PMM
[Qemu-devel] [PULL 0/4] Ide patches
The following changes since commit 4b6eda626fdb8bf90472c6868d502a2ac09abeeb: Merge remote-tracking branch 'remotes/lalrae/tags/mips-20151124' into staging (2015-11-24 17:05:06 +) are available in the git repository at: https://github.com/jnsnow/qemu.git tags/ide-pull-request for you to fetch changes up to 9c73517ca56d6611371376bd298b4b20f3ad6140: ide-test: fix timeouts (2015-11-25 11:37:34 -0500) Alberto Garcia (2): atapi: Account for failed and invalid operations in cd_read_sector() atapi: Fix code indentation John Snow (2): ide-test: cdrom_pio_impl fixup ide-test: fix timeouts hw/ide/atapi.c | 8 +--- tests/ide-test.c | 32 +++- 2 files changed, 28 insertions(+), 12 deletions(-) -- 2.4.3
