Re: [Qemu-devel] [PULL 00/11] RCU, KVM, memory API, crypto, Coverity fixes for 2.4.0-rc1

2015-07-16 Thread Peter Maydell
On 16 July 2015 at 17:55, Paolo Bonzini pbonz...@redhat.com wrote:
 The following changes since commit 6169b60285fe1ff730d840a49527e721bfb30899:

   Update version for v2.4.0-rc0 release (2015-07-09 17:56:56 +0100)

 are available in the git repository at:

   git://github.com/bonzini/qemu.git tags/for-upstream

 for you to fetch changes up to 4a8775ab71d2186fc1cd585ea80c000409965cde:

   crypto: avoid undefined behavior in nettle calls (2015-07-16 18:54:21 +0200)

 
 * rcu_register_thread fixes.
 * MIPS-KVM fixes.
 * Coverity fixes.
 * Nettle function prototype fixes.
 * Memory API refcount fix.


I get a pile of assertions on OSX running rcutorture:

GTESTER tests/rcutorture
Assertion failed: (rcu_reader.depth == 0), function
rcu_unregister_thread, file /Users/pm215/srcAssertion failed:
(rcu_reader.de/qemu/util/rcu.c, line 304.
pth == 0), function rcu_unregister_thread, file
/Users/pm215/src/qemu/util/rcu.c, line 304.
Assertion failed: (rcu_reader.depth == 0), function
rcu_unregister_thread, file /Users/pm215/src/qemu/util/rcu.c, line
304.
Assertion failed: (rcu_reader.depth == 0), function
rcu_unregister_thread, file /Users/pm215/src/qemu/util/rcu.c, line
304.
Assertion failed: (rcu_reader.depth == 0), function
rcu_unregister_thread, file /Users/pm215/src/qemu/util/rcu.c, line
304.
Assertion failed: (rcu_reader.depth == 0), function
rcu_unregister_thread, file /Users/pm215/srcAssertion failed:
(rcu_reader.de/qemu/util/rcu.c, line 304.
pth == 0), function rcu_unregister_thread, file
/Users/pm215/src/qemu/util/rcu.c, line 304.
GTester: last random seed: R02S9b5149dbb406809df60686a3e8223c26
Assertion failed: (rcu_reader.depth == 0), function
rcu_unregister_thread, file /Users/pm215/src/qemu/util/rcu.c, line
304.
Assertion failed: (rcu_reader.depth == 0), function
rcu_unregister_thread, file /Users/pm215/src/qemu/util/rcu.c, line
304.
Assertion failed: (rcu_reader.depth == 0), function
rcu_unregister_thread, file /Users/pm215/src/qemu/util/rcu.c, line
304.
Assertion failed: (rcu_reader.deAssertion failed: (rcu_reader.depth ==
0), function rcu_unregistpth == 0), function rcu_unregister_thread,
file /Users/pm215/srcer_thread, file /Users/pm215/src/qemu/util/rcu.c,
line 304.
/qemu/util/rcu.c, line 304.
GTester: last random seed: R02Sb915fd85eca48d367fd186bdfd39d8c7
make: *** [check-tests/rcutorture] Error 1

-- PMM



[Qemu-devel] [PULL 00/11] RCU, KVM, memory API, crypto, Coverity fixes for 2.4.0-rc1

2015-07-16 Thread Paolo Bonzini
The following changes since commit 6169b60285fe1ff730d840a49527e721bfb30899:

  Update version for v2.4.0-rc0 release (2015-07-09 17:56:56 +0100)

are available in the git repository at:

  git://github.com/bonzini/qemu.git tags/for-upstream

for you to fetch changes up to 4a8775ab71d2186fc1cd585ea80c000409965cde:

  crypto: avoid undefined behavior in nettle calls (2015-07-16 18:54:21 +0200)


* rcu_register_thread fixes.
* MIPS-KVM fixes.
* Coverity fixes.
* Nettle function prototype fixes.
* Memory API refcount fix.


Dr. David Alan Gilbert (1):
  RDMA: Fix error exits

Gonglei (2):
  ppc/spapr_drc: fix memory leak
  arm/xlnx-zynqmp: fix memory leak

James Hogan (2):
  mips/kvm: Fix Big endian 32-bit register access
  mips/kvm: Sign extend registers written to KVM

Paolo Bonzini (4):
  rcu: automatically unregister threads when they exit
  rcu: actually register threads that have RCU read-side critical sections
  rcu: detect missing rcu_register_thread()
  memory: fix refcount leak in memory_region_present

Radim Krčmář (2):
  crypto: fix build with nettle = 3.0.0
  crypto: avoid undefined behavior in nettle calls

 configure  |  4 +++-
 cpus.c |  6 ++
 crypto/cipher-nettle.c | 51 --
 hw/arm/xlnx-zynqmp.c   |  2 ++
 hw/ppc/spapr_drc.c |  1 +
 include/qemu/rcu.h |  4 +++-
 iothread.c |  3 +++
 memory.c   | 44 +++
 migration/migration.c  |  3 +++
 migration/rdma.c   |  8 
 target-mips/kvm.c  | 21 +++--
 tests/rcutorture.c | 10 --
 tests/test-rcu-list.c  |  2 ++
 util/rcu.c | 49 +++-
 14 files changed, 151 insertions(+), 57 deletions(-)
-- 
2.4.3




Re: [Qemu-devel] [PULL 00/11] RCU, KVM, memory API, crypto, Coverity fixes for 2.4.0-rc1

2015-07-16 Thread Peter Maydell
On 16 July 2015 at 18:44, Peter Maydell peter.mayd...@linaro.org wrote:
 On 16 July 2015 at 17:55, Paolo Bonzini pbonz...@redhat.com wrote:
 The following changes since commit 6169b60285fe1ff730d840a49527e721bfb30899:

   Update version for v2.4.0-rc0 release (2015-07-09 17:56:56 +0100)

 are available in the git repository at:

   git://github.com/bonzini/qemu.git tags/for-upstream

 for you to fetch changes up to 4a8775ab71d2186fc1cd585ea80c000409965cde:

   crypto: avoid undefined behavior in nettle calls (2015-07-16 18:54:21 
 +0200)

 
 * rcu_register_thread fixes.
 * MIPS-KVM fixes.
 * Coverity fixes.
 * Nettle function prototype fixes.
 * Memory API refcount fix.


 I get a pile of assertions on OSX running rcutorture:

This version of the pull also failed rcutorture on x86-64
linux host, though not with assertions -- looks like it
just exited nonzero.

thanks
-- PMM