Re: [Qemu-devel] [Qemu-block] [PATCH 06/10] qemu-iotests: turn owner variable into a comment

2017-11-17 Thread Eric Blake 
On 11/17/2017 07:18 AM, Cleber Rosa wrote:
> 
> 
> On 11/17/2017 02:19 AM, Paolo Bonzini wrote:
>> On 16/11/2017 18:38, Cleber Rosa wrote:
>>> This variables has no real use.  To avoid pretending it does, while
>>> still keeping the information, let's turn it into a comment.
>>>
>>> The format chosen is the one already being used on tests 149 and 194.
>>
>> I would just delete it...
>>
>> Paolo
>>
> 
> I'm fine with both, but I feel this is like putting info on ChangeLogs
> in the days of GIT.  Unless other people object, I'll remove them in v2.

I'm also in the 'please delete it; git history is good enough' camp.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.   +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



signature.asc
Description: OpenPGP digital signature

Re: [Qemu-devel] [Qemu-block] [PATCH 06/10] qemu-iotests: turn owner variable into a comment

2017-11-17 Thread Cleber Rosa 


On 11/17/2017 02:19 AM, Paolo Bonzini wrote:
> On 16/11/2017 18:38, Cleber Rosa wrote:
>> This variables has no real use.  To avoid pretending it does, while
>> still keeping the information, let's turn it into a comment.
>>
>> The format chosen is the one already being used on tests 149 and 194.
> 
> I would just delete it...
> 
> Paolo
> 

I'm fine with both, but I feel this is like putting info on ChangeLogs
in the days of GIT.  Unless other people object, I'll remove them in v2.

- Cleber.

>> Signed-off-by: Cleber Rosa 
>> ---
>>  tests/qemu-iotests/001 | 5 ++---
>>  tests/qemu-iotests/002 | 5 ++---
>>  tests/qemu-iotests/003 | 5 ++---
>>  tests/qemu-iotests/004 | 5 ++---
>>  tests/qemu-iotests/005 | 5 ++---
>>  tests/qemu-iotests/007 | 5 ++---
>>  tests/qemu-iotests/008 | 5 ++---
>>  tests/qemu-iotests/009 | 5 ++---
>>  tests/qemu-iotests/010 | 5 ++---
>>  tests/qemu-iotests/011 | 5 ++---
>>  tests/qemu-iotests/012 | 5 ++---
>>  tests/qemu-iotests/013 | 5 ++---
>>  tests/qemu-iotests/014 | 5 ++---
>>  tests/qemu-iotests/015 | 5 ++---
>>  tests/qemu-iotests/017 | 5 ++---
>>  tests/qemu-iotests/018 | 5 ++---
>>  tests/qemu-iotests/019 | 5 ++---
>>  tests/qemu-iotests/020 | 5 ++---
>>  tests/qemu-iotests/021 | 5 ++---
>>  tests/qemu-iotests/022 | 5 ++---
>>  tests/qemu-iotests/023 | 5 ++---
>>  tests/qemu-iotests/024 | 5 ++---
>>  tests/qemu-iotests/025 | 5 ++---
>>  tests/qemu-iotests/026 | 5 ++---
>>  tests/qemu-iotests/027 | 5 ++---
>>  tests/qemu-iotests/028 | 5 ++---
>>  tests/qemu-iotests/029 | 5 ++---
>>  tests/qemu-iotests/031 | 5 ++---
>>  tests/qemu-iotests/032 | 5 ++---
>>  tests/qemu-iotests/033 | 5 ++---
>>  tests/qemu-iotests/034 | 5 ++---
>>  tests/qemu-iotests/035 | 5 ++---
>>  tests/qemu-iotests/036 | 5 ++---
>>  tests/qemu-iotests/037 | 5 ++---
>>  tests/qemu-iotests/038 | 5 ++---
>>  tests/qemu-iotests/039 | 5 ++---
>>  tests/qemu-iotests/040 | 1 +
>>  tests/qemu-iotests/042 | 5 ++---
>>  tests/qemu-iotests/043 | 5 ++---
>>  tests/qemu-iotests/046 | 5 ++---
>>  tests/qemu-iotests/047 | 5 ++---
>>  tests/qemu-iotests/048 | 4 ++--
>>  tests/qemu-iotests/049 | 5 ++---
>>  tests/qemu-iotests/050 | 5 ++---
>>  tests/qemu-iotests/051 | 5 ++---
>>  tests/qemu-iotests/052 | 5 ++---
>>  tests/qemu-iotests/053 | 5 ++---
>>  tests/qemu-iotests/054 | 5 ++---
>>  tests/qemu-iotests/058 | 5 ++---
>>  tests/qemu-iotests/059 | 5 ++---
>>  tests/qemu-iotests/060 | 5 ++---
>>  tests/qemu-iotests/061 | 5 ++---
>>  tests/qemu-iotests/062 | 5 ++---
>>  tests/qemu-iotests/063 | 5 ++---
>>  tests/qemu-iotests/064 | 5 ++---
>>  tests/qemu-iotests/066 | 5 ++---
>>  tests/qemu-iotests/067 | 5 ++---
>>  tests/qemu-iotests/068 | 5 ++---
>>  tests/qemu-iotests/069 | 5 ++---
>>  tests/qemu-iotests/070 | 5 ++---
>>  tests/qemu-iotests/071 | 5 ++---
>>  tests/qemu-iotests/072 | 5 ++---
>>  tests/qemu-iotests/073 | 5 ++---
>>  tests/qemu-iotests/074 | 3 +--
>>  tests/qemu-iotests/075 | 5 ++---
>>  tests/qemu-iotests/076 | 5 ++---
>>  tests/qemu-iotests/077 | 5 ++---
>>  tests/qemu-iotests/078 | 5 ++---
>>  tests/qemu-iotests/079 | 5 ++---
>>  tests/qemu-iotests/080 | 5 ++---
>>  tests/qemu-iotests/081 | 5 ++---
>>  tests/qemu-iotests/082 | 5 ++---
>>  tests/qemu-iotests/083 | 5 ++---
>>  tests/qemu-iotests/084 | 5 ++---
>>  tests/qemu-iotests/085 | 5 ++---
>>  tests/qemu-iotests/086 | 5 ++---
>>  tests/qemu-iotests/087 | 5 ++---
>>  tests/qemu-iotests/088 | 5 ++---
>>  tests/qemu-iotests/089 | 5 ++---
>>  tests/qemu-iotests/090 | 5 ++---
>>  tests/qemu-iotests/091 | 5 ++---
>>  tests/qemu-iotests/092 | 5 ++---
>>  tests/qemu-iotests/094 | 5 ++---
>>  tests/qemu-iotests/095 | 4 ++--
>>  tests/qemu-iotests/097 | 5 ++---
>>  tests/qemu-iotests/098 | 5 ++---
>>  tests/qemu-iotests/099 | 5 ++---
>>  tests/qemu-iotests/101 | 5 ++---
>>  tests/qemu-iotests/102 | 5 ++---
>>  tests/qemu-iotests/103 | 5 ++---
>>  tests/qemu-iotests/104 | 5 ++---
>>  tests/qemu-iotests/105 | 5 ++---
>>  tests/qemu-iotests/106 | 5 ++---
>>  tests/qemu-iotests/107 | 5 ++---
>>  tests/qemu-iotests/108 | 5 ++---
>>  tests/qemu-iotests/109 | 5 ++---
>>  tests/qemu-iotests/110 | 5 ++---
>>  tests/qemu-iotests/111 | 5 ++---
>>  tests/qemu-iotests/112 | 5 ++---
>>  tests/qemu-iotests/113 | 5 ++---
>>  tests/qemu-iotests/114 | 5 ++---
>>  tests/qemu-iotests/115 | 5 ++---
>>  tests/qemu-iotests/116 | 5 ++---
>>  tests/qemu-iotests/117 | 5 ++---
>>  tests/qemu-iotests/119 | 5 ++---
>>  tests/qemu-iotests/120 | 5 ++---
>>  tests/qemu-iotests/121 | 5 ++---
>>  tests/qemu-iotests/122 | 5 ++---
>>  tests/qemu-iotests/123 | 5 ++---
>>  tests/qemu-iotests/125 | 5 ++---
>>  tests/qemu-iotests/126 | 5 ++---
>>  tests/qemu-iotests/127 | 5 ++---
>>  tests/qemu-iotests/128 | 5 ++---
>>  tests/qemu-iotests/130 | 5 ++---
>>  tests/qemu-iotests/131 | 5 ++---
>>  tests/qemu-iotests/133 | 5 ++---
>>  tests/qemu-iotests/134 | 5 ++---
>>  tests/qemu-iotests/135 | 5 ++---
>>  tests/qemu-iotests/137 | 5 ++---
>>  tests/qemu-iotests/138 | 5 ++---
>>

Re: [Qemu-devel] [Qemu-block] [PATCH 06/10] qemu-iotests: turn owner variable into a comment

2017-11-16 Thread Paolo Bonzini 
On 16/11/2017 18:38, Cleber Rosa wrote:
> This variables has no real use.  To avoid pretending it does, while
> still keeping the information, let's turn it into a comment.
> 
> The format chosen is the one already being used on tests 149 and 194.

I would just delete it...

Paolo

> Signed-off-by: Cleber Rosa 
> ---
>  tests/qemu-iotests/001 | 5 ++---
>  tests/qemu-iotests/002 | 5 ++---
>  tests/qemu-iotests/003 | 5 ++---
>  tests/qemu-iotests/004 | 5 ++---
>  tests/qemu-iotests/005 | 5 ++---
>  tests/qemu-iotests/007 | 5 ++---
>  tests/qemu-iotests/008 | 5 ++---
>  tests/qemu-iotests/009 | 5 ++---
>  tests/qemu-iotests/010 | 5 ++---
>  tests/qemu-iotests/011 | 5 ++---
>  tests/qemu-iotests/012 | 5 ++---
>  tests/qemu-iotests/013 | 5 ++---
>  tests/qemu-iotests/014 | 5 ++---
>  tests/qemu-iotests/015 | 5 ++---
>  tests/qemu-iotests/017 | 5 ++---
>  tests/qemu-iotests/018 | 5 ++---
>  tests/qemu-iotests/019 | 5 ++---
>  tests/qemu-iotests/020 | 5 ++---
>  tests/qemu-iotests/021 | 5 ++---
>  tests/qemu-iotests/022 | 5 ++---
>  tests/qemu-iotests/023 | 5 ++---
>  tests/qemu-iotests/024 | 5 ++---
>  tests/qemu-iotests/025 | 5 ++---
>  tests/qemu-iotests/026 | 5 ++---
>  tests/qemu-iotests/027 | 5 ++---
>  tests/qemu-iotests/028 | 5 ++---
>  tests/qemu-iotests/029 | 5 ++---
>  tests/qemu-iotests/031 | 5 ++---
>  tests/qemu-iotests/032 | 5 ++---
>  tests/qemu-iotests/033 | 5 ++---
>  tests/qemu-iotests/034 | 5 ++---
>  tests/qemu-iotests/035 | 5 ++---
>  tests/qemu-iotests/036 | 5 ++---
>  tests/qemu-iotests/037 | 5 ++---
>  tests/qemu-iotests/038 | 5 ++---
>  tests/qemu-iotests/039 | 5 ++---
>  tests/qemu-iotests/040 | 1 +
>  tests/qemu-iotests/042 | 5 ++---
>  tests/qemu-iotests/043 | 5 ++---
>  tests/qemu-iotests/046 | 5 ++---
>  tests/qemu-iotests/047 | 5 ++---
>  tests/qemu-iotests/048 | 4 ++--
>  tests/qemu-iotests/049 | 5 ++---
>  tests/qemu-iotests/050 | 5 ++---
>  tests/qemu-iotests/051 | 5 ++---
>  tests/qemu-iotests/052 | 5 ++---
>  tests/qemu-iotests/053 | 5 ++---
>  tests/qemu-iotests/054 | 5 ++---
>  tests/qemu-iotests/058 | 5 ++---
>  tests/qemu-iotests/059 | 5 ++---
>  tests/qemu-iotests/060 | 5 ++---
>  tests/qemu-iotests/061 | 5 ++---
>  tests/qemu-iotests/062 | 5 ++---
>  tests/qemu-iotests/063 | 5 ++---
>  tests/qemu-iotests/064 | 5 ++---
>  tests/qemu-iotests/066 | 5 ++---
>  tests/qemu-iotests/067 | 5 ++---
>  tests/qemu-iotests/068 | 5 ++---
>  tests/qemu-iotests/069 | 5 ++---
>  tests/qemu-iotests/070 | 5 ++---
>  tests/qemu-iotests/071 | 5 ++---
>  tests/qemu-iotests/072 | 5 ++---
>  tests/qemu-iotests/073 | 5 ++---
>  tests/qemu-iotests/074 | 3 +--
>  tests/qemu-iotests/075 | 5 ++---
>  tests/qemu-iotests/076 | 5 ++---
>  tests/qemu-iotests/077 | 5 ++---
>  tests/qemu-iotests/078 | 5 ++---
>  tests/qemu-iotests/079 | 5 ++---
>  tests/qemu-iotests/080 | 5 ++---
>  tests/qemu-iotests/081 | 5 ++---
>  tests/qemu-iotests/082 | 5 ++---
>  tests/qemu-iotests/083 | 5 ++---
>  tests/qemu-iotests/084 | 5 ++---
>  tests/qemu-iotests/085 | 5 ++---
>  tests/qemu-iotests/086 | 5 ++---
>  tests/qemu-iotests/087 | 5 ++---
>  tests/qemu-iotests/088 | 5 ++---
>  tests/qemu-iotests/089 | 5 ++---
>  tests/qemu-iotests/090 | 5 ++---
>  tests/qemu-iotests/091 | 5 ++---
>  tests/qemu-iotests/092 | 5 ++---
>  tests/qemu-iotests/094 | 5 ++---
>  tests/qemu-iotests/095 | 4 ++--
>  tests/qemu-iotests/097 | 5 ++---
>  tests/qemu-iotests/098 | 5 ++---
>  tests/qemu-iotests/099 | 5 ++---
>  tests/qemu-iotests/101 | 5 ++---
>  tests/qemu-iotests/102 | 5 ++---
>  tests/qemu-iotests/103 | 5 ++---
>  tests/qemu-iotests/104 | 5 ++---
>  tests/qemu-iotests/105 | 5 ++---
>  tests/qemu-iotests/106 | 5 ++---
>  tests/qemu-iotests/107 | 5 ++---
>  tests/qemu-iotests/108 | 5 ++---
>  tests/qemu-iotests/109 | 5 ++---
>  tests/qemu-iotests/110 | 5 ++---
>  tests/qemu-iotests/111 | 5 ++---
>  tests/qemu-iotests/112 | 5 ++---
>  tests/qemu-iotests/113 | 5 ++---
>  tests/qemu-iotests/114 | 5 ++---
>  tests/qemu-iotests/115 | 5 ++---
>  tests/qemu-iotests/116 | 5 ++---
>  tests/qemu-iotests/117 | 5 ++---
>  tests/qemu-iotests/119 | 5 ++---
>  tests/qemu-iotests/120 | 5 ++---
>  tests/qemu-iotests/121 | 5 ++---
>  tests/qemu-iotests/122 | 5 ++---
>  tests/qemu-iotests/123 | 5 ++---
>  tests/qemu-iotests/125 | 5 ++---
>  tests/qemu-iotests/126 | 5 ++---
>  tests/qemu-iotests/127 | 5 ++---
>  tests/qemu-iotests/128 | 5 ++---
>  tests/qemu-iotests/130 | 5 ++---
>  tests/qemu-iotests/131 | 5 ++---
>  tests/qemu-iotests/133 | 5 ++---
>  tests/qemu-iotests/134 | 5 ++---
>  tests/qemu-iotests/135 | 5 ++---
>  tests/qemu-iotests/137 | 5 ++---
>  tests/qemu-iotests/138 | 5 ++---
>  tests/qemu-iotests/140 | 5 ++---
>  tests/qemu-iotests/141 | 5 ++---
>  tests/qemu-iotests/142 | 5 ++---
>  tests/qemu-iotests/143 | 5 ++---
>  tests/qemu-iotests/144 | 5 ++---
>  tests/qemu-iotests/145 | 5 ++---
>  tests/qemu-iotests/146 | 5 ++---
>  tests/qemu-iotests/150 | 5 ++---
>  tests/qemu-iotests/153 | 5 ++---
>  tests/qemu-iotests/154