Re: [Qemu-devel] [Qemu-block] [QEMU] [PATCH v5 0/8] Add Qemu to SeaBIOS LCHS interface
Hi, [ just back from summer vacation, wading through my backlog ... ] > > I feel like it would be up to Gerd as the general SeaBIOS point of contact? > > > > ...ah, who is offline for vacation. > > We're in freeze right now anyway, so I would think that Gerd and/or > Kevin can work out who ought to stage this for a PR when the tree opens > again. As this touches alot of block code I've expected it to go via block tree, therefore I've added my reviewed-by to indicate the fw_cfg / seabios side of things is fine from my point of view. seabios patches are reviewed and ready. Merging via Phil's fw_cfg tree would make sense too, but Phil probably wants an ack from the block layer guys in that case. cheers, Gerd
Re: [Qemu-devel] [Qemu-block] [QEMU] [PATCH v5 0/8] Add Qemu to SeaBIOS LCHS interface
On 07/25/19 02:50, John Snow wrote: > > > On 7/24/19 8:47 PM, John Snow wrote: >> >> >> On 7/19/19 6:10 AM, Sam Eiderman wrote: >>> Well, this patch introduces 3 command line parameters (“lcyls”, “lheads”, >>> “lsecs”) >>> to “scsi-hd” “ide-hd” and “virtio-pci-blk” so this somehow has something to >>> do with >>> block. >>> >>> This patch also adds fw_cfg interface to send these parameters to SeaBIOS. >>> >>> "scripts/get_maintainer.pl -f hw/nvram/fw_cfg.c” gives >>> >>> "Philippe Mathieu-Daudé" (supporter:Firmware >>> configur...) >>> Laszlo Ersek (reviewer:Firmware configur...) >>> Gerd Hoffmann (reviewer:Firmware configur…) >>> >>> And this was already Reviewed-by Gerd. >>> >>> How should I proceed? >>> >>> Sam >>> >> >> I feel like it would be up to Gerd as the general SeaBIOS point of contact? >> > > ...ah, who is offline for vacation. > > We're in freeze right now anyway, so I would think that Gerd and/or > Kevin can work out who ought to stage this for a PR when the tree opens > again. > I think the sole patch in the series that modifies "hw/nvram/fw_cfg.c" is [Qemu-devel] [QEMU] [PATCH v5 7/8] bootdevice: FW_CFG interface for LCHS values http://mid.mail-archive.com/20190626123948.10199-8-shmuel.eiderman@oracle.com and neither Phil nor myself seem to be CC'd on it (I've found the message in my list folder only). Regarding fw_cfg, I only review Phil's fw_cfg patches (so that whenever he posts patches, he can count on my review); other than that, I generally skip fw_cfg patches. And, I totally don't have a tree for collecting such patches. Now, while Phil does: T: git https://github.com/philmd/qemu.git fw_cfg-next I still don't think that tree would be the best for queueing this series, given the diffstat: bootdevice.c | 148 +--- hw/block/virtio-blk.c| 6 + hw/ide/qdev.c| 7 +- hw/nvram/fw_cfg.c| 14 +- hw/scsi/scsi-bus.c | 15 ++ hw/scsi/scsi-disk.c | 14 ++ include/hw/block/block.h | 22 +- include/hw/scsi/scsi.h | 1 + include/sysemu/sysemu.h | 4 + tests/Makefile.include | 2 +- tests/hd-geo-test.c | 582 +++ 11 files changed, 774 insertions(+), 41 deletions(-) Just my two cents. Thanks Laszlo
Re: [Qemu-devel] [Qemu-block] [QEMU] [PATCH v5 0/8] Add Qemu to SeaBIOS LCHS interface
On 7/24/19 8:47 PM, John Snow wrote: > > > On 7/19/19 6:10 AM, Sam Eiderman wrote: >> Well, this patch introduces 3 command line parameters (“lcyls”, “lheads”, >> “lsecs”) >> to “scsi-hd” “ide-hd” and “virtio-pci-blk” so this somehow has something to >> do with >> block. >> >> This patch also adds fw_cfg interface to send these parameters to SeaBIOS. >> >> "scripts/get_maintainer.pl -f hw/nvram/fw_cfg.c” gives >> >> "Philippe Mathieu-Daudé" (supporter:Firmware configur...) >> Laszlo Ersek (reviewer:Firmware configur...) >> Gerd Hoffmann (reviewer:Firmware configur…) >> >> And this was already Reviewed-by Gerd. >> >> How should I proceed? >> >> Sam >> > > I feel like it would be up to Gerd as the general SeaBIOS point of contact? > ...ah, who is offline for vacation. We're in freeze right now anyway, so I would think that Gerd and/or Kevin can work out who ought to stage this for a PR when the tree opens again.
Re: [Qemu-devel] [Qemu-block] [QEMU] [PATCH v5 0/8] Add Qemu to SeaBIOS LCHS interface
On 7/19/19 6:10 AM, Sam Eiderman wrote: > Well, this patch introduces 3 command line parameters (“lcyls”, “lheads”, > “lsecs”) > to “scsi-hd” “ide-hd” and “virtio-pci-blk” so this somehow has something to > do with > block. > > This patch also adds fw_cfg interface to send these parameters to SeaBIOS. > > "scripts/get_maintainer.pl -f hw/nvram/fw_cfg.c” gives > > "Philippe Mathieu-Daudé" (supporter:Firmware configur...) > Laszlo Ersek (reviewer:Firmware configur...) > Gerd Hoffmann (reviewer:Firmware configur…) > > And this was already Reviewed-by Gerd. > > How should I proceed? > > Sam > I feel like it would be up to Gerd as the general SeaBIOS point of contact? --js
