Re: [Qemu-devel] [Qemu-trivial] [PATCH v1 1/3] char/serial: cosmetic fixes.
03.06.2013 09:12, peter.crosthwa...@xilinx.com wrote: From: Peter Crosthwaite peter.crosthwa...@xilinx.com Some cosmetic fixes to char/serial fixing some checkpatch errors. These are all cosmetic fixes indeed. I weren't sure we're applying stylistic changes by its own. But apparently people don't object so I don't see why not, either, except that I don't really want to open a can of worms with other stylistic patches to come ;) Applied all 3 to the trivial patches queue. Thank you! /mjt
Re: [Qemu-devel] [Qemu-trivial] [PATCH v1 1/3] char/serial: cosmetic fixes.
10.06.2013 19:17, Michael Tokarev пишет: 03.06.2013 09:12, peter.crosthwa...@xilinx.com wrote: From: Peter Crosthwaite peter.crosthwa...@xilinx.com Some cosmetic fixes to char/serial fixing some checkpatch errors. These are all cosmetic fixes indeed. I weren't sure we're applying stylistic changes by its own. But apparently people don't object so I don't see why not, either, except that I don't really want to open a can of worms with other stylistic patches to come ;) Applied all 3 to the trivial patches queue. Actually I didn't apply these. Since patch 2/3 weren't sent to -trivial, and 3/3 does not apply without it, I'm not sure I want to apply either of these. Maybe all 3 should be sent to the same tree? Should I pick the 2/3 too, which wasn't submitted to -trivial? Thank you! /mjt
Re: [Qemu-devel] [Qemu-trivial] [PATCH v1 1/3] char/serial: cosmetic fixes.
Hi Michael, On Tue, Jun 11, 2013 at 1:29 AM, Michael Tokarev m...@tls.msk.ru wrote: 10.06.2013 19:17, Michael Tokarev пишет: 03.06.2013 09:12, peter.crosthwa...@xilinx.com wrote: From: Peter Crosthwaite peter.crosthwa...@xilinx.com Some cosmetic fixes to char/serial fixing some checkpatch errors. These are all cosmetic fixes indeed. I weren't sure we're applying stylistic changes by its own. But apparently people don't object so I don't see why not, either, except that I don't really want to open a can of worms with other stylistic patches to come ;) Applied all 3 to the trivial patches queue. Actually I didn't apply these. Since patch 2/3 weren't sent to -trivial, and 3/3 does not apply without it, I'm not sure I want to apply either of these. Maybe all 3 should be sent to the same tree? Should I pick the 2/3 too, which wasn't submitted to -trivial? Im happy for you to take all three as they have had a week of list time and 2/3 is cleanup only with no functional change. It's borderline as to whether its trivial. Regards, Peter Thank you! /mjt