Re: [Qemu-devel] [RFC PATCH 12/15] input: mouse: add qemu_input_is_absolute()

2013-12-02 Thread John Baboval
Perhaps this should just return the mask instead of a boolean? It would 
be nice at some point to handle a USB HID style device that can send 
both relative and absolute events, for example.


Though perhaps that would be better as future work, since this is a nice 
drop-in replacement for the old call.


On 11/28/2013 09:30 AM, Gerd Hoffmann wrote:

Same as kbd_mouse_is_absolute(), but using new input core.

Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
  include/ui/input.h | 1 +
  ui/input.c | 8 
  2 files changed, 9 insertions(+)

diff --git a/include/ui/input.h b/include/ui/input.h
index 0d79342..43b9afc 100644
--- a/include/ui/input.h
+++ b/include/ui/input.h
@@ -39,6 +39,7 @@ void qemu_input_queue_btn(QemuConsole *src, InputButton btn, 
bool down);
  void qemu_input_update_buttons(QemuConsole *src, uint32_t *button_map,
 uint32_t button_old, uint32_t button_new);
  
+bool qemu_input_is_absolute(void);

  int qemu_input_scale_axis(int value, int size_in, int size_out);
  InputEvent *qemu_input_event_new_move(InputEventKind kind,
InputAxis axis, int value);
diff --git a/ui/input.c b/ui/input.c
index abfe3a3..719c427 100644
--- a/ui/input.c
+++ b/ui/input.c
@@ -167,6 +167,14 @@ void qemu_input_update_buttons(QemuConsole *src, uint32_t 
*button_map,
  }
  }
  
+bool qemu_input_is_absolute(void)

+{
+QemuInputHandlerState *s;
+
+s = qemu_input_find_handler(INPUT_EVENT_MASK_REL | INPUT_EVENT_MASK_ABS);
+return (s != NULL)  (s-handler-mask  INPUT_EVENT_MASK_ABS);
+}
+
  int qemu_input_scale_axis(int value, int size_in, int size_out)
  {
  if (size_in  2) {





[Qemu-devel] [RFC PATCH 12/15] input: mouse: add qemu_input_is_absolute()

2013-11-28 Thread Gerd Hoffmann
Same as kbd_mouse_is_absolute(), but using new input core.

Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
 include/ui/input.h | 1 +
 ui/input.c | 8 
 2 files changed, 9 insertions(+)

diff --git a/include/ui/input.h b/include/ui/input.h
index 0d79342..43b9afc 100644
--- a/include/ui/input.h
+++ b/include/ui/input.h
@@ -39,6 +39,7 @@ void qemu_input_queue_btn(QemuConsole *src, InputButton btn, 
bool down);
 void qemu_input_update_buttons(QemuConsole *src, uint32_t *button_map,
uint32_t button_old, uint32_t button_new);
 
+bool qemu_input_is_absolute(void);
 int qemu_input_scale_axis(int value, int size_in, int size_out);
 InputEvent *qemu_input_event_new_move(InputEventKind kind,
   InputAxis axis, int value);
diff --git a/ui/input.c b/ui/input.c
index abfe3a3..719c427 100644
--- a/ui/input.c
+++ b/ui/input.c
@@ -167,6 +167,14 @@ void qemu_input_update_buttons(QemuConsole *src, uint32_t 
*button_map,
 }
 }
 
+bool qemu_input_is_absolute(void)
+{
+QemuInputHandlerState *s;
+
+s = qemu_input_find_handler(INPUT_EVENT_MASK_REL | INPUT_EVENT_MASK_ABS);
+return (s != NULL)  (s-handler-mask  INPUT_EVENT_MASK_ABS);
+}
+
 int qemu_input_scale_axis(int value, int size_in, int size_out)
 {
 if (size_in  2) {
-- 
1.8.3.1