Re: [Qemu-devel] [RFC v3 0/2] use sizes.h macros for power-of-two sizes
Il 23/10/2013 14:16, Antony Pavlov ha scritto: On Tue, 24 Sep 2013 08:32:10 +0400 Antony Pavlov antonynpav...@gmail.com wrote: ping-ping On Fri, 13 Sep 2013 11:33:24 +0400 Antony Pavlov antonynpav...@gmail.com wrote: ping Changes since v2: * commit messages: drop ALL 'Reviewed-by' tags. Drop Aurelien Jarno's tag because the patchseries was completely reworked, so it need additional review. Changes since v1: * include/sizes.h - include/qemu/sizes.h * fix copyright header; * fix formatting: drop tabs; * use the BIT() macro, so it's easy-to-read the constants column; also the BIT() macro casts constant to UL; * rebase on updated master; * take into account the mips_malta: support up to 2GiB RAM commit. [RFC v3 1/2] include/qemu: introduce sizes.h [RFC v3 2/2] hw/mips: use sizes.h macros The sizes.h macros is a easy-to-read method of power-of-two memory sizes representation. The sizes.h macros are actively used in linux kernel and other projects, so let's use them in QEMU too. -- Best regards, Antony Pavlov This unfortunately will miss 1.7. Please repost after 1.7 is released, without the RFC in the subject -- just use PATCH instead. Paolo
Re: [Qemu-devel] [RFC v3 0/2] use sizes.h macros for power-of-two sizes
On Tue, 24 Sep 2013 08:32:10 +0400 Antony Pavlov antonynpav...@gmail.com wrote: ping-ping On Fri, 13 Sep 2013 11:33:24 +0400 Antony Pavlov antonynpav...@gmail.com wrote: ping Changes since v2: * commit messages: drop ALL 'Reviewed-by' tags. Drop Aurelien Jarno's tag because the patchseries was completely reworked, so it need additional review. Changes since v1: * include/sizes.h - include/qemu/sizes.h * fix copyright header; * fix formatting: drop tabs; * use the BIT() macro, so it's easy-to-read the constants column; also the BIT() macro casts constant to UL; * rebase on updated master; * take into account the mips_malta: support up to 2GiB RAM commit. [RFC v3 1/2] include/qemu: introduce sizes.h [RFC v3 2/2] hw/mips: use sizes.h macros The sizes.h macros is a easy-to-read method of power-of-two memory sizes representation. The sizes.h macros are actively used in linux kernel and other projects, so let's use them in QEMU too. -- Best regards, Antony Pavlov -- -- Best regards, Antony Pavlov
Re: [Qemu-devel] [RFC v3 0/2] use sizes.h macros for power-of-two sizes
On Fri, 13 Sep 2013 11:33:24 +0400 Antony Pavlov antonynpav...@gmail.com wrote: ping Changes since v2: * commit messages: drop ALL 'Reviewed-by' tags. Drop Aurelien Jarno's tag because the patchseries was completely reworked, so it need additional review. Changes since v1: * include/sizes.h - include/qemu/sizes.h * fix copyright header; * fix formatting: drop tabs; * use the BIT() macro, so it's easy-to-read the constants column; also the BIT() macro casts constant to UL; * rebase on updated master; * take into account the mips_malta: support up to 2GiB RAM commit. [RFC v3 1/2] include/qemu: introduce sizes.h [RFC v3 2/2] hw/mips: use sizes.h macros The sizes.h macros is a easy-to-read method of power-of-two memory sizes representation. The sizes.h macros are actively used in linux kernel and other projects, so let's use them in QEMU too. -- Best regards, Antony Pavlov
Re: [Qemu-devel] [RFC v3 0/2] use sizes.h macros for power-of-two sizes
On 09/13/2013 12:33 AM, Antony Pavlov wrote: Changes since v2: * commit messages: drop ALL 'Reviewed-by' tags. Drop Aurelien Jarno's tag because the patchseries was completely reworked, so it need additional review. Changes since v1: * include/sizes.h - include/qemu/sizes.h * fix copyright header; * fix formatting: drop tabs; * use the BIT() macro, so it's easy-to-read the constants column; also the BIT() macro casts constant to UL; * rebase on updated master; * take into account the mips_malta: support up to 2GiB RAM commit. [RFC v3 1/2] include/qemu: introduce sizes.h [RFC v3 2/2] hw/mips: use sizes.h macros The sizes.h macros is a easy-to-read method of power-of-two memory sizes representation. The sizes.h macros are actively used in linux kernel and other projects, so let's use them in QEMU too. Seems reasonable. I'd have said why bother with some of the multiples, except for the crossover with the linux kernel. Reviewed-by: Richard Henderson r...@twiddle.net r~
[Qemu-devel] [RFC v3 0/2] use sizes.h macros for power-of-two sizes
Changes since v2: * commit messages: drop ALL 'Reviewed-by' tags. Drop Aurelien Jarno's tag because the patchseries was completely reworked, so it need additional review. Changes since v1: * include/sizes.h - include/qemu/sizes.h * fix copyright header; * fix formatting: drop tabs; * use the BIT() macro, so it's easy-to-read the constants column; also the BIT() macro casts constant to UL; * rebase on updated master; * take into account the mips_malta: support up to 2GiB RAM commit. [RFC v3 1/2] include/qemu: introduce sizes.h [RFC v3 2/2] hw/mips: use sizes.h macros The sizes.h macros is a easy-to-read method of power-of-two memory sizes representation. The sizes.h macros are actively used in linux kernel and other projects, so let's use them in QEMU too.
