Re: [Qemu-devel] [v2 0/4] Fix long vm downtime during live migration

[Amit Shah]

On (Wed) 21 Oct 2015 [09:00:31], Li, Liang Z wrote:
> > > Some cleanup operations take long time during the pause and copy 
> > > stage, especially with the KVM patch 3ea3b7fa9af067, do these 
> > > operations after the completion of live migration can help to reduce 
> > > VM
> > downtime.
> > >
> > > Ony the first patch changes the behavior, the rest 3 patches are for 
> > > code cleanup.
> > >
> > > Changes:
> > >   * Remove qemu_savevm_sate_cancel() in migrate_fd_cleanup()
> > >   * Add 2 more patches for code clean up
> > 
> > Reviewed-by: Paolo Bonzini 
> 
> Resend this mail.

Hi Liang,

I'm looking at this patchset; I did take a look at it in the past and
I couldn't map everything; I need more time to look at everything
here.

Definitely a more detailed commit log or comments would've helped.

But there's already a reviewed-by from Paolo, so I fully expect this
patch to be merged in 2.5.

Amit

Re: [Qemu-devel] [v2 0/4] Fix long vm downtime during live migration

[Li, Liang Z]

Hi Amit, 

I am very glad that you are looking at this patchset.  Looking forward to your 
comments. :)


Liang

> -Original Message-
> From: Amit Shah [mailto:amit.s...@redhat.com]
> Sent: Monday, October 26, 2015 2:10 PM
> To: Li, Liang Z
> Cc: 'qemu-devel@nongnu.org'; 'quint...@redhat.com'; 'qemu-
> bl...@nongnu.org'; Wang, Yong Y; 'qemu-sta...@nongnu.org';
> 'stefa...@redhat.com'; Zhang, Yang Z; 'Paolo Bonzini'
> Subject: Re: [Qemu-devel] [v2 0/4] Fix long vm downtime during live migration
> 
> On (Wed) 21 Oct 2015 [09:00:31], Li, Liang Z wrote:
> > > > Some cleanup operations take long time during the pause and copy
> > > > stage, especially with the KVM patch 3ea3b7fa9af067, do these
> > > > operations after the completion of live migration can help to
> > > > reduce VM
> > > downtime.
> > > >
> > > > Ony the first patch changes the behavior, the rest 3 patches are
> > > > for code cleanup.
> > > >
> > > > Changes:
> > > >   * Remove qemu_savevm_sate_cancel() in migrate_fd_cleanup()
> > > >   * Add 2 more patches for code clean up
> > >
> > > Reviewed-by: Paolo Bonzini <pbonz...@redhat.com>
> >
> > Resend this mail.
> 
> Hi Liang,
> 
> I'm looking at this patchset; I did take a look at it in the past and I 
> couldn't map
> everything; I need more time to look at everything here.
> 
> Definitely a more detailed commit log or comments would've helped.
> 
> But there's already a reviewed-by from Paolo, so I fully expect this patch to 
> be
> merged in 2.5.
> 
>   Amit

Re: [Qemu-devel] [v2 0/4] Fix long vm downtime during live migration

[Li, Liang Z]

> > Some cleanup operations take long time during the pause and copy 
> > stage, especially with the KVM patch 3ea3b7fa9af067, do these 
> > operations after the completion of live migration can help to reduce 
> > VM
> downtime.
> >
> > Ony the first patch changes the behavior, the rest 3 patches are for 
> > code cleanup.
> >
> > Changes:
> >   * Remove qemu_savevm_sate_cancel() in migrate_fd_cleanup()
> >   * Add 2 more patches for code clean up
> 
> Reviewed-by: Paolo Bonzini 

Resend this mail.

Hi Juan & Amit,

Could you help to review this serial of patches  and give some comments when 
you have time? 

The link to the thread is: 
https://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg01516.html

Liang

Re: [Qemu-devel] [v2 0/4] Fix long vm downtime during live migration

[Li, Liang Z]

> > Some cleanup operations take long time during the pause and copy
> > stage, especially with the KVM patch 3ea3b7fa9af067, do these
> > operations after the completion of live migration can help to reduce VM
> downtime.
> >
> > Ony the first patch changes the behavior, the rest 3 patches are for
> > code cleanup.
> >
> > Changes:
> >   * Remove qemu_savevm_sate_cancel() in migrate_fd_cleanup()
> >   * Add 2 more patches for code clean up
> 
> Reviewed-by: Paolo Bonzini 

Hi Juan & Amit,

Could you help to review this serial of patches  and give some comments when 
you have time? 

The link to the thread is: 
https://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg01516.html

Liang

Re: [Qemu-devel] [v2 0/4] Fix long vm downtime during live migration

[Paolo Bonzini]

On 13/08/2015 07:46, Liang Li wrote:
 Some cleanup operations take long time during the pause and copy stage,
 especially with the KVM patch 3ea3b7fa9af067, do these operations after
 the completion of live migration can help to reduce VM downtime.
 
 Ony the first patch changes the behavior, the rest 3 patches are for code
 cleanup.
 
 Changes:
   * Remove qemu_savevm_sate_cancel() in migrate_fd_cleanup()
   * Add 2 more patches for code clean up

Reviewed-by: Paolo Bonzini pbonz...@redhat.com

[Qemu-devel] [v2 0/4] Fix long vm downtime during live migration

[Liang Li]

Some cleanup operations take long time during the pause and copy stage,
especially with the KVM patch 3ea3b7fa9af067, do these operations after
the completion of live migration can help to reduce VM downtime.

Ony the first patch changes the behavior, the rest 3 patches are for code
cleanup.

Changes:
  * Remove qemu_savevm_sate_cancel() in migrate_fd_cleanup()
  * Add 2 more patches for code clean up

Liang Li (4):
  migration: do cleanup operation after completion
  migration: rename qemu_savevm_state_cancel
  migration: rename cancel to cleanup in SaveVMHandles
  migration: code clean up

 include/migration/vmstate.h |  2 +-
 include/sysemu/sysemu.h |  2 +-
 migration/block.c   | 10 ++
 migration/migration.c   | 14 +++---
 migration/ram.c | 10 ++
 migration/savevm.c  | 10 +-
 trace-events|  2 +-
 7 files changed, 19 insertions(+), 31 deletions(-)

-- 
1.9.1