[Qemu-devel] Re: [PATCH] blockdev: check dinfo ptr before using
Am 08.12.2010 17:05, schrieb Ryan Harper: If a user decides to punish a guest by revoking its block device via drive_del, and subsequently also attempts to remove the pci device backing it, and the device is using blockdev_auto_del() then we get a segfault when we attempt to access dinfo-auto_del.[1] The fix is to check if drive_get_by_blockdev() actually returns a valid dinfo pointer or not. 1. (qemu) pci_add auto storage file=images/test01.raw,if=virtio,id=block1,snapshot=on (qemu) drive_del block1 (qemu) pci_del 5 *segfault* Signed-off-by: Ryan Harper ry...@us.ibm.com Thanks, applied to the block branch. Kevin
[Qemu-devel] Re: [PATCH] blockdev: check dinfo ptr before using
On Wed, 8 Dec 2010 10:05:00 -0600 Ryan Harper ry...@us.ibm.com wrote: If a user decides to punish a guest by revoking its block device via drive_del, and subsequently also attempts to remove the pci device backing it, and the device is using blockdev_auto_del() then we get a segfault when we attempt to access dinfo-auto_del.[1] The fix is to check if drive_get_by_blockdev() actually returns a valid dinfo pointer or not. 1. (qemu) pci_add auto storage file=images/test01.raw,if=virtio,id=block1,snapshot=on (qemu) drive_del block1 (qemu) pci_del 5 *segfault* Signed-off-by: Ryan Harper ry...@us.ibm.com Fixes my test case: Tested-by: Luiz Capitulino lcapitul...@redhat.com
