[Qemu-devel] Re: [PATCH 0/4] monitor: Convert do_set_link() to QObject, QError
On Wed, Mar 24, 2010 at 04:20:53PM -0300, Luiz Capitulino wrote: > On Tue, 23 Mar 2010 11:27:54 +0100 > Markus Armbruster wrote: > > > PATCH 3/4 changes syntax of set_link's second argument from up|down to > > on|off. I feel that the argument needs to be boolean in QMP, and this > > is the simplest way to get it. > > > > Alternatives I could try if the syntax change is unwanted: > > > > * Use the old string argument in QMP. Easy. > > > > * Don't convert set_link, create a new command with a boolean > > argument. > > > > * Create a argument parser for up|down. > > I like your approach. Daniel do you use set_link in libvirt already? > I've grepped around I didn't found any reference for it. We don't currently use it, but plan to in the not too distant future. Regards, Daniel -- |: Red Hat, Engineering, London-o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org-o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
[Qemu-devel] Re: [PATCH 0/4] monitor: Convert do_set_link() to QObject, QError
On Tue, 23 Mar 2010 11:27:54 +0100 Markus Armbruster wrote: > PATCH 3/4 changes syntax of set_link's second argument from up|down to > on|off. I feel that the argument needs to be boolean in QMP, and this > is the simplest way to get it. > > Alternatives I could try if the syntax change is unwanted: > > * Use the old string argument in QMP. Easy. > > * Don't convert set_link, create a new command with a boolean > argument. > > * Create a argument parser for up|down. I like your approach. Daniel do you use set_link in libvirt already? I've grepped around I didn't found any reference for it. > > Markus Armbruster (4): > monitor: Rename argument type 'b' to 'f' > monitor: New argument type 'b' > monitor: Use argument type 'b' for set_link > monitor: Convert do_set_link() to QObject, QError > > monitor.c | 39 +++ > net.c | 17 ++--- > net.h |2 +- > qemu-monitor.hx | 13 +++-- > 4 files changed, 49 insertions(+), 22 deletions(-) >
