Re: [Qemu-devel] qemu-ga : Guest Agent : Windows 2008 : Unknown command guest-fsfreeze-freeze

2012-08-21 Thread Luiz Capitulino
On Mon, 20 Aug 2012 14:34:34 -0500
Michael Roth mdr...@linux.vnet.ibm.com wrote:

 On Mon, Aug 20, 2012 at 10:54:29AM -0300, Luiz Capitulino wrote:
  On Fri, 17 Aug 2012 10:11:29 -0700 (PDT)
  desi babu vdesib...@yahoo.com wrote:
  
   Guest-Agent : Windows 2008 Error : Relase 1.1.90
   
   error : internal error unable to execute QEMU command 
   'guest-fsfreeze-freeze': this feature or command is not currently 
   supported.
  
  That's correct, fsfreze is not supported on Windows.
  
   Guest-info shows the command is available.  Is there any information 
   available on the list of commands supported inside Windows 
   ? Appreciate if you have any pointers.
  
  That's a qemu-ga bug. CC'ing Michael to check if he has a fix in mind for 
  this.
  
 
 I've been thinking about this one for a while. It's considered expected
 behavior, but I realize it sucks for discoverability. I doubt we want to
 do platform-specific QAPI schema definitions, so the only option I can
 think of is some kind of [de-]registration mechanism where we can mark
 commands as being not available for a particular build/platform in the
 cases where we stub out command implementations.

Yes, I guess the first idea I had is similar. I thought about adding
PlatformOps and let win32 and posix register the commands they
implement. Then, qmp_guest_info() could check if the in-use PlatformOps
supports the command before adding it to the supported list.

 I think we can expose this to existing clients by no longer listing commands
 marked as unsupported in the list provided by the guest-info command. It
 should just work. Can probably do it for 1.3. For now, clients will
 have to catch it in the error-handling path.

Agreed it's 1.3 material.



Re: [Qemu-devel] qemu-ga : Guest Agent : Windows 2008 : Unknown command guest-fsfreeze-freeze

2012-08-20 Thread Luiz Capitulino
On Fri, 17 Aug 2012 10:11:29 -0700 (PDT)
desi babu vdesib...@yahoo.com wrote:

 Guest-Agent : Windows 2008 Error : Relase 1.1.90
 
 error : internal error unable to execute QEMU command 
 'guest-fsfreeze-freeze': this feature or command is not currently supported.

That's correct, fsfreze is not supported on Windows.

 Guest-info shows the command is available.  Is there any information 
 available on the list of commands supported inside Windows ? Appreciate if 
 you have any pointers.

That's a qemu-ga bug. CC'ing Michael to check if he has a fix in mind for this.



Re: [Qemu-devel] qemu-ga : Guest Agent : Windows 2008 : Unknown command guest-fsfreeze-freeze

2012-08-20 Thread Michael Roth
On Mon, Aug 20, 2012 at 10:54:29AM -0300, Luiz Capitulino wrote:
 On Fri, 17 Aug 2012 10:11:29 -0700 (PDT)
 desi babu vdesib...@yahoo.com wrote:
 
  Guest-Agent : Windows 2008 Error : Relase 1.1.90
  
  error : internal error unable to execute QEMU command 
  'guest-fsfreeze-freeze': this feature or command is not currently supported.
 
 That's correct, fsfreze is not supported on Windows.
 
  Guest-info shows the command is available.  Is there any information 
  available on the list of commands supported inside Windows ? Appreciate if 
  you have any pointers.
 
 That's a qemu-ga bug. CC'ing Michael to check if he has a fix in mind for 
 this.
 

I've been thinking about this one for a while. It's considered expected
behavior, but I realize it sucks for discoverability. I doubt we want to
do platform-specific QAPI schema definitions, so the only option I can
think of is some kind of [de-]registration mechanism where we can mark
commands as being not available for a particular build/platform in the
cases where we stub out command implementations.

I think we can expose this to existing clients by no longer listing commands
marked as unsupported in the list provided by the guest-info command. It
should just work. Can probably do it for 1.3. For now, clients will
have to catch it in the error-handling path.



[Qemu-devel] qemu-ga : Guest Agent : Windows 2008 : Unknown command guest-fsfreeze-freeze

2012-08-17 Thread desi babu
Guest-Agent : Windows 2008 Error : Relase 1.1.90

error : internal error unable to execute QEMU command 'guest-fsfreeze-freeze': 
this feature or command is not currently supported.

Guest-info shows the command is available.  Is there any information available 
on the list of commands supported inside Windows ? Appreciate if you have any 
pointers.

/Suresh Mandava

-- data  
Environment : Windows Server 2008 R2
Guest Agent Version : 1.1.90 compiled from latest qemu source 1.2.0rc0

Libvirt : XML for VM. 

channel type='unix'
       source mode='bind' 
path='/var/lib/libvirt/qemu/va-2008-ga-libvirt.0.sock'/
       target type='virtio' name='org.qemu.guest_agent.0'/
       address type='virtio-serial' controller='0' bus='0' port='1'/
/channel
channel type='unix'
       source mode='bind' 
path='/var/lib/libvirt/qemu/va-2008-ga-cloud.0.sock'/
       target type='virtio' name='org.qemu.guest_agent.1'/
       address type='virtio-serial' controller='0' bus='0' port='2'/
 /channel

Test Case Success  1: 
echo {'execute':'guest-info'} |socat stdio,ignoreeof 
unix-connect:/var/lib/libvirt/qemu/va-2008-ga-cloud.0.sock

Result : 
{return: {version: 1.1.90, supported_commands: [{enabled: true, 
name: guest-network-get-interfaces}, {enabled: true, name: 
guest-suspend-hybrid}, {enabled: true, name: guest-suspend-ram}, 
{enabled: true, name: guest-suspend-disk}, {enabled: true, name: 
guest-fstrim}, {enabled: true, name: guest-fsfreeze-thaw}, {enabled: 
true, name: guest-fsfreeze-freeze}, {enabled: true, name: 
guest-fsfreeze-status}, {enabled: true, name: guest-file-flush}, 
{enabled: true, name: guest-file-seek}, {enabled: true, name: 
guest-file-write}, {enabled: true, name: guest-file-read}, {enabled: 
true, name: guest-file-close}, {enabled: true, name: 
guest-file-open}, {enabled: true, name: guest-shutdown}, {enabled: 
true, name: guest-info}, {enabled: true, name: guest-ping}, 
{enabled: true, name: guest-sync}, {enabled: true, name: 
guest-sync-delimited}]}}

Test case Failure  2 : 
virsh snapshot-create $myvm --no-metadata --disk-only --quiesce --atomic
internal error unable to execute QEMU command 'guest-fsfreeze-freeze': this 
feature or command is not currently supported

Please let me know if you need any data.
--