Re: [RFC PATCH v3 cxl-2.0-doe 1/2] Basic PCIe DOE support
On Tue, 9 Mar 2021 16:03:55 -0500 Chris Browy wrote: Hi Chris, various specific comments inline but a few important ones to watch for next version. 1) Always read the final patch you are sending out. Last minute rebases can result in picking up a bunch of unrelated stuff like here. That basically gives a grumpy maintainer a reason not to read your patch. If I had maintainer hat on I'd have kicked this back to you unread. 2) Please add proper descriptions for each patch - I know it's an RFC but it feels like it is getting there so good to get that element in shape as well. 3) Split the patch up. Some stuff in here will be coming in via other paths (headers are picked up by a script in some cases). 4) To my eye far too much debug in here for code at this level of maturity. From actual code point of view looks pretty good to me. Drop CMA until you have it implemented - right now it's just unwanted noise in this patch. Thanks, Jonathan > --- > MAINTAINERS | 49 +-- > hw/pci/meson.build| 1 + > hw/pci/pci.c | 13 +- > hw/pci/pcie_doe.c | 416 ++ > include/hw/pci/pci_ids.h | 5 +- > include/hw/pci/pcie.h | 1 + > include/hw/pci/pcie_doe.h | 142 > include/hw/pci/pcie_regs.h| 4 + > include/standard-headers/linux/pci_regs.h | 3 +- > 9 files changed, 591 insertions(+), 43 deletions(-) > create mode 100644 hw/pci/pcie_doe.c > create mode 100644 include/hw/pci/pcie_doe.h > > diff --git a/MAINTAINERS b/MAINTAINERS > index f9097ed9e7..8c5a9690a5 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -87,7 +87,7 @@ S390 general architecture support > M: Cornelia Huck > M: Thomas Huth > S: Supported > -F: default-configs/*/s390x-softmmu.mak > +F: default-configs/s390x-softmmu.mak > F: gdb-xml/s390*.xml > F: hw/char/sclp*.[hc] > F: hw/char/terminal3270.c > @@ -188,15 +188,6 @@ F: include/hw/cris/ > F: tests/tcg/cris/ > F: disas/cris.c > > -Hexagon TCG CPUs > -M: Taylor Simpson > -S: Supported > -F: target/hexagon/ > -F: linux-user/hexagon/ > -F: tests/tcg/hexagon/ > -F: disas/hexagon.c > -F: default-configs/targets/hexagon-linux-user.mak > - > HPPA (PA-RISC) TCG CPUs > M: Richard Henderson > S: Maintained > @@ -239,7 +230,7 @@ R: Jiaxun Yang > R: Aleksandar Rikalo > S: Odd Fixes > F: target/mips/ > -F: default-configs/*/*mips* > +F: default-configs/*mips* > F: disas/mips.c > F: docs/system/cpu-models-mips.rst.inc > F: hw/intc/mips_gic.c > @@ -263,7 +254,7 @@ S: Maintained > F: target/moxie/ > F: disas/moxie.c > F: hw/moxie/ > -F: default-configs/*/moxie-softmmu.mak > +F: default-configs/moxie-softmmu.mak > > NiosII TCG CPUs > M: Chris Wulff > @@ -272,7 +263,7 @@ S: Maintained > F: target/nios2/ > F: hw/nios2/ > F: disas/nios2.c > -F: default-configs/*/nios2-softmmu.mak > +F: default-configs/nios2-softmmu.mak > > OpenRISC TCG CPUs > M: Stafford Horne > @@ -367,7 +358,7 @@ F: hw/xtensa/ > F: tests/tcg/xtensa/ > F: disas/xtensa.c > F: include/hw/xtensa/xtensa-isa.h > -F: default-configs/*/xtensa*.mak > +F: default-configs/xtensa*.mak > > TriCore TCG CPUs > M: Bastian Koppelmann > @@ -1038,7 +1029,7 @@ AVR MCUs > M: Michael Rolnik > R: Sarah Harris > S: Maintained > -F: default-configs/*/avr-softmmu.mak > +F: default-configs/avr-softmmu.mak > F: hw/avr/ > F: include/hw/char/avr_usart.h > F: hw/char/avr_usart.c > @@ -1067,7 +1058,7 @@ HP B160L > M: Richard Henderson > R: Helge Deller > S: Odd Fixes > -F: default-configs/*/hppa-softmmu.mak > +F: default-configs/hppa-softmmu.mak > F: hw/hppa/ > F: pc-bios/hppa-firmware.img > > @@ -1183,7 +1174,6 @@ F: hw/intc/loongson_liointc.c > F: hw/mips/loongson3_bootp.c > F: hw/mips/loongson3_bootp.h > F: hw/mips/loongson3_virt.c > -F: tests/acceptance/machine_mips_loongson3v.py > > Boston > M: Paul Burton > @@ -1373,15 +1363,6 @@ F: include/hw/misc/mchp_pfsoc_dmc.h > F: include/hw/misc/mchp_pfsoc_ioscb.h > F: include/hw/misc/mchp_pfsoc_sysreg.h > > -SiFive Machines > -M: Alistair Francis > -M: Bin Meng > -M: Palmer Dabbelt > -L: qemu-ri...@nongnu.org > -S: Supported > -F: hw/*/*sifive*.c > -F: include/hw/*/*sifive*.h > - > RX Machines > --- > rx-gdbsim > @@ -1468,7 +1449,7 @@ F: hw/s390x/ > F: include/hw/s390x/ > F: hw/watchdog/wdt_diag288.c > F: include/hw/watchdog/wdt_diag288.h > -F: default-configs/*/s390x-softmmu.mak > +F: default-configs/s390x-softmmu.mak > F: tests/acceptance/machine_s390_ccw_virtio.py > T: git https://gitlab.com/cohuck/qemu.git s390-next > T: git https://github.com/borntraeger/qemu.git s390-next > @@ -1681,6 +1662,13 @@ F: docs/pci* > F: docs/specs/*pci* > F: default-configs/pci.mak > > +PCIE DOE > +M: Huai-Cheng Kuo > +M: Chris Browy > +S: Supported > +F: include/hw/pci/pcie_doe.h > +F: hw/pci/pcie_doe.c > + >
[RFC PATCH v3 cxl-2.0-doe 1/2] Basic PCIe DOE support
--- MAINTAINERS | 49 +-- hw/pci/meson.build| 1 + hw/pci/pci.c | 13 +- hw/pci/pcie_doe.c | 416 ++ include/hw/pci/pci_ids.h | 5 +- include/hw/pci/pcie.h | 1 + include/hw/pci/pcie_doe.h | 142 include/hw/pci/pcie_regs.h| 4 + include/standard-headers/linux/pci_regs.h | 3 +- 9 files changed, 591 insertions(+), 43 deletions(-) create mode 100644 hw/pci/pcie_doe.c create mode 100644 include/hw/pci/pcie_doe.h diff --git a/MAINTAINERS b/MAINTAINERS index f9097ed9e7..8c5a9690a5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -87,7 +87,7 @@ S390 general architecture support M: Cornelia Huck M: Thomas Huth S: Supported -F: default-configs/*/s390x-softmmu.mak +F: default-configs/s390x-softmmu.mak F: gdb-xml/s390*.xml F: hw/char/sclp*.[hc] F: hw/char/terminal3270.c @@ -188,15 +188,6 @@ F: include/hw/cris/ F: tests/tcg/cris/ F: disas/cris.c -Hexagon TCG CPUs -M: Taylor Simpson -S: Supported -F: target/hexagon/ -F: linux-user/hexagon/ -F: tests/tcg/hexagon/ -F: disas/hexagon.c -F: default-configs/targets/hexagon-linux-user.mak - HPPA (PA-RISC) TCG CPUs M: Richard Henderson S: Maintained @@ -239,7 +230,7 @@ R: Jiaxun Yang R: Aleksandar Rikalo S: Odd Fixes F: target/mips/ -F: default-configs/*/*mips* +F: default-configs/*mips* F: disas/mips.c F: docs/system/cpu-models-mips.rst.inc F: hw/intc/mips_gic.c @@ -263,7 +254,7 @@ S: Maintained F: target/moxie/ F: disas/moxie.c F: hw/moxie/ -F: default-configs/*/moxie-softmmu.mak +F: default-configs/moxie-softmmu.mak NiosII TCG CPUs M: Chris Wulff @@ -272,7 +263,7 @@ S: Maintained F: target/nios2/ F: hw/nios2/ F: disas/nios2.c -F: default-configs/*/nios2-softmmu.mak +F: default-configs/nios2-softmmu.mak OpenRISC TCG CPUs M: Stafford Horne @@ -367,7 +358,7 @@ F: hw/xtensa/ F: tests/tcg/xtensa/ F: disas/xtensa.c F: include/hw/xtensa/xtensa-isa.h -F: default-configs/*/xtensa*.mak +F: default-configs/xtensa*.mak TriCore TCG CPUs M: Bastian Koppelmann @@ -1038,7 +1029,7 @@ AVR MCUs M: Michael Rolnik R: Sarah Harris S: Maintained -F: default-configs/*/avr-softmmu.mak +F: default-configs/avr-softmmu.mak F: hw/avr/ F: include/hw/char/avr_usart.h F: hw/char/avr_usart.c @@ -1067,7 +1058,7 @@ HP B160L M: Richard Henderson R: Helge Deller S: Odd Fixes -F: default-configs/*/hppa-softmmu.mak +F: default-configs/hppa-softmmu.mak F: hw/hppa/ F: pc-bios/hppa-firmware.img @@ -1183,7 +1174,6 @@ F: hw/intc/loongson_liointc.c F: hw/mips/loongson3_bootp.c F: hw/mips/loongson3_bootp.h F: hw/mips/loongson3_virt.c -F: tests/acceptance/machine_mips_loongson3v.py Boston M: Paul Burton @@ -1373,15 +1363,6 @@ F: include/hw/misc/mchp_pfsoc_dmc.h F: include/hw/misc/mchp_pfsoc_ioscb.h F: include/hw/misc/mchp_pfsoc_sysreg.h -SiFive Machines -M: Alistair Francis -M: Bin Meng -M: Palmer Dabbelt -L: qemu-ri...@nongnu.org -S: Supported -F: hw/*/*sifive*.c -F: include/hw/*/*sifive*.h - RX Machines --- rx-gdbsim @@ -1468,7 +1449,7 @@ F: hw/s390x/ F: include/hw/s390x/ F: hw/watchdog/wdt_diag288.c F: include/hw/watchdog/wdt_diag288.h -F: default-configs/*/s390x-softmmu.mak +F: default-configs/s390x-softmmu.mak F: tests/acceptance/machine_s390_ccw_virtio.py T: git https://gitlab.com/cohuck/qemu.git s390-next T: git https://github.com/borntraeger/qemu.git s390-next @@ -1681,6 +1662,13 @@ F: docs/pci* F: docs/specs/*pci* F: default-configs/pci.mak +PCIE DOE +M: Huai-Cheng Kuo +M: Chris Browy +S: Supported +F: include/hw/pci/pcie_doe.h +F: hw/pci/pcie_doe.c + ACPI/SMBIOS M: Michael S. Tsirkin M: Igor Mammedov @@ -1764,7 +1752,6 @@ F: hw/ssi/xilinx_* SD (Secure Card) M: Philippe Mathieu-Daudé -M: Bin Meng L: qemu-bl...@nongnu.org S: Odd Fixes F: include/hw/sd/sd* @@ -1859,7 +1846,6 @@ F: fsdev/ F: docs/interop/virtfs-proxy-helper.rst F: tests/qtest/virtio-9p-test.c T: git https://gitlab.com/gkurz/qemu.git 9p-next -T: git https://github.com/cschoenebeck/qemu.git 9p.next virtio-blk M: Stefan Hajnoczi @@ -2904,13 +2890,13 @@ F: accel/tcg/user-exec*.c BSD user S: Orphan F: bsd-user/ -F: default-configs/targets/*-bsd-user.mak +F: default-configs/*-bsd-user.mak Linux user M: Laurent Vivier S: Maintained F: linux-user/ -F: default-configs/targets/*linux-user.mak +F: default-configs/*-linux-user.mak F: scripts/qemu-binfmt-conf.sh F: scripts/update-syscalltbl.sh F: scripts/update-mips-syscall-args.sh @@ -2930,7 +2916,6 @@ S: Maintained F: docs/devel/tcg-plugins.rst F: plugins/ F: tests/plugin/ -F: tests/acceptance/tcg_plugins.py F: contrib/plugins/ AArch64 TCG target diff --git a/hw/pci/meson.build b/hw/pci/meson.build index 5c4bbac817..115e50222f 100644 --- a/hw/pci/meson.build +++ b/hw/pci/meson.build @@ -12,6 +12,7 @@ pci_ss.add(files( # allow plugging PCIe devices
