Re: [v3 2/6] system/dirtylimit: Drop the reduplicative check

2023-11-02 Thread Juan Quintela
Hyman Huang  wrote:
> Checking if dirty limit is in service is done by the
> dirtylimit_query_all function, drop the reduplicative
> check in the qmp_query_vcpu_dirty_limit function.
>
> Signed-off-by: Hyman Huang 
> Reviewed-by: Fabiano Rosas 
> Message-Id: 
> <31384f768279027560ab952ebc2bbff1ddb62531.1697815117.git.yong.hu...@smartx.com>

Reviewed-by: Juan Quintela 
queued.




[v3 2/6] system/dirtylimit: Drop the reduplicative check

2023-11-01 Thread Hyman Huang
Checking if dirty limit is in service is done by the
dirtylimit_query_all function, drop the reduplicative
check in the qmp_query_vcpu_dirty_limit function.

Signed-off-by: Hyman Huang 
Reviewed-by: Fabiano Rosas 
Message-Id: 
<31384f768279027560ab952ebc2bbff1ddb62531.1697815117.git.yong.hu...@smartx.com>
---
 system/dirtylimit.c | 4 
 1 file changed, 4 deletions(-)

diff --git a/system/dirtylimit.c b/system/dirtylimit.c
index 3666c4cb7c..495c7a7082 100644
--- a/system/dirtylimit.c
+++ b/system/dirtylimit.c
@@ -652,10 +652,6 @@ static struct DirtyLimitInfoList 
*dirtylimit_query_all(void)
 
 struct DirtyLimitInfoList *qmp_query_vcpu_dirty_limit(Error **errp)
 {
-if (!dirtylimit_in_service()) {
-return NULL;
-}
-
 return dirtylimit_query_all();
 }
 
-- 
2.39.1