Re: Bug: object-add qmp command that used to work fails now
On 3/31/21 3:26 PM, Lukas Straub wrote: >> Per docs/system/removed-features.rst, the change was intentional: >> >>> ``object-add`` option ``props`` (removed in 6.0) >>> >>> >>> Specify the properties for the object as top-level arguments instead. >> >> although it is unfortunate that you didn't notice the change during the >> deprecation cycle. >> > > Yeah, no big deal. I wasn't sure if this is intentional as the change isn't > documented on https://wiki.qemu.org/ChangeLog/6.0 I'll try and update the top "Incompatible changes" with that and anything else I see in the removed-features.rst file. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
Re: Bug: object-add qmp command that used to work fails now
On Wed, 31 Mar 2021 15:16:18 -0500
Eric Blake wrote:
> On 3/31/21 3:00 PM, Lukas Straub wrote:
> > Hi,
> > This qmp command that used to work:
> > {"execute": "object-add", "arguments": {"qom-type": "filter-mirror", "id":
> > "m0", "props": {"netdev": "hn0", "queue": "tx", "outdev": "mirror0",
> > "vnet_hdr_support": false}}}
> > now fails with the following error:
> > {"error": {"class": "GenericError", "desc": "Parameter 'netdev' is
> > missing"}}
> >
> > I haven't looked closely into it, but I think
> > 9151e59a8b6e854eb733553c6772351049ca6ab6 "qapi/qom: QAPIfy object-add"
> > is the culprint.
>
> Try getting rid of the nesting caused by props:
>
> {"execute": "object-add", "arguments": {"qom-type": "filter-mirror",
> "id": "m0", "netdev": "hn0", "queue": "tx", "outdev": "mirror0",
> "vnet_hdr_support": false}}
Okay, that works.
> Per docs/system/removed-features.rst, the change was intentional:
>
> > ``object-add`` option ``props`` (removed in 6.0)
> >
> >
> > Specify the properties for the object as top-level arguments instead.
>
> although it is unfortunate that you didn't notice the change during the
> deprecation cycle.
>
Yeah, no big deal. I wasn't sure if this is intentional as the change isn't
documented on https://wiki.qemu.org/ChangeLog/6.0
Regards,
Lukas Straub
--
pgphEZunTmqiR.pgp
Description: OpenPGP digital signature
Re: Bug: object-add qmp command that used to work fails now
On 3/31/21 3:00 PM, Lukas Straub wrote:
> Hi,
> This qmp command that used to work:
> {"execute": "object-add", "arguments": {"qom-type": "filter-mirror", "id":
> "m0", "props": {"netdev": "hn0", "queue": "tx", "outdev": "mirror0",
> "vnet_hdr_support": false}}}
> now fails with the following error:
> {"error": {"class": "GenericError", "desc": "Parameter 'netdev' is missing"}}
>
> I haven't looked closely into it, but I think
> 9151e59a8b6e854eb733553c6772351049ca6ab6 "qapi/qom: QAPIfy object-add"
> is the culprint.
Try getting rid of the nesting caused by props:
{"execute": "object-add", "arguments": {"qom-type": "filter-mirror",
"id": "m0", "netdev": "hn0", "queue": "tx", "outdev": "mirror0",
"vnet_hdr_support": false}}
Per docs/system/removed-features.rst, the change was intentional:
> ``object-add`` option ``props`` (removed in 6.0)
>
>
> Specify the properties for the object as top-level arguments instead.
although it is unfortunate that you didn't notice the change during the
deprecation cycle.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
Bug: object-add qmp command that used to work fails now
Hi,
This qmp command that used to work:
{"execute": "object-add", "arguments": {"qom-type": "filter-mirror", "id":
"m0", "props": {"netdev": "hn0", "queue": "tx", "outdev": "mirror0",
"vnet_hdr_support": false}}}
now fails with the following error:
{"error": {"class": "GenericError", "desc": "Parameter 'netdev' is missing"}}
I haven't looked closely into it, but I think
9151e59a8b6e854eb733553c6772351049ca6ab6 "qapi/qom: QAPIfy object-add"
is the culprint.
Regards,
Lukas Straub
--
pgpaJyK4c06N0.pgp
Description: OpenPGP digital signature
