RE: [PATCH] WHPX: refactor load library
> Making it easier for other people to test WHPX would be nice. Yes, we understand the concerns and I generally agree here. I am trying to connect the different teams involved here (legal, SDK here) and connect the dots for them, to see what can be done here. > But in case this is not sorted out soon, I don't see a reason to > not merge WHPX changes if they are reviewed and approved by the > main author of that code (Justin). > Justin is ready to review it, but is out for another week. Will have him review once he is back.
RE: [PATCH] WHPX: refactor load library
> Can we wait for approval from the Microsoft legal department first? > So we can start testing WHPX builds, and reduce the possibilities to > introduce regressions. > > Testing is ready, we are waiting for Microsoft to merge, see: > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.mail-archive.com%2Fqemu- > devel%40nongnu.org%2Fmsg646351.htmldata=02%7C01%7Csunilmut%40microsoft.com%7C41ce65aedecb47c7bd0d08d76857937d > %7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637092597657121219sdata=tu0zZDIzlG%2F9lEU4SJi11%2B%2FX1JdHUt6PD > 2teeYCMZ%2B8%3Dreserved=0 > Yes, we have escalated this to the right set of teams, including the legal team. We are working through the processes here internally and will update once we have something. Meanwhile, it would be good to see if we can get these patches in. > > > > Sunil, Justin, would you like to be listed as maintainers or > > designated reviewers for the WHPX code in QEMU? > > Great idea! It's a valid and good point. I am discussing this internally here and will get back.
RE: [PATCH] WHPX: refactor load library
> -Original Message-
> From: Paolo Bonzini
> Sent: Wednesday, November 13, 2019 7:00 AM
> To: Sunil Muthuswamy ; Richard Henderson
> ; Eduardo Habkost ;
> Stefan Weil
> Cc: qemu-devel@nongnu.org; Justin Terry (VM)
> Subject: Re: [PATCH] WHPX: refactor load library
>
> On 08/11/19 21:31, Sunil Muthuswamy wrote:
> >
> > +typedef enum WHPFunctionList {
> > +WINHV_PLATFORM_FNS_DEFAULT,
> > +WINHV_EMULATION_FNS_DEFAULT,
> > +} WHPFunctionList;
> >
>
> What does "default" stand for? I assume you have more changes to this
> function in the future.
>
Yes, there are more functions coming, such as for XSAVE. I used "default" to
represent
whatever is there currently, for lack of a better term.
> > + * Load the functions from the given library, using the given handle. If a
> > + * handle is provided, it is used, otherwise the library is opened. The
> > + * handle will be updated on return with the opened one.
> > + */
> > +static bool load_whp_dipatch_fns(HMODULE *handle, WHPFunctionList
> > function_list)
> > +{
>
> Typo, "dipatch" instead of "dispatch".
> >
> > +if (hLib) {
> > +FreeLibrary(hWinHvEmulation);
> > +}
>
> The argument to FreeLibrary should be hLib.
>
Thanks, will fix these in the next version.
Re: [PATCH] WHPX: refactor load library
On Wed, Nov 13, 2019 at 05:35:59PM +0100, Philippe Mathieu-Daudé wrote: > On 11/12/19 8:47 PM, Eduardo Habkost wrote: > > On Tue, Nov 12, 2019 at 06:42:00PM +, Sunil Muthuswamy wrote: > > > > > > > > > > -Original Message- > > > > From: Sunil Muthuswamy > > > > Sent: Friday, November 8, 2019 12:32 PM > > > > To: 'Paolo Bonzini' ; 'Richard Henderson' > > > > ; 'Eduardo Habkost' ; 'Stefan > > > > Weil' > > > > Cc: 'qemu-devel@nongnu.org' ; Justin Terry (VM) > > > > > > > > Subject: [PATCH] WHPX: refactor load library > > > > > > > > This refactors the load library of WHV libraries to make it more > > > > modular. It makes a helper routine that can be called on demand. > > > > This allows future expansion of load library/functions to support > > > > functionality that is depenedent on some feature being available. > > > > > > > > Signed-off-by: Sunil Muthuswamy > > > > --- > > > > > > Can I possibly get some eyes on this? > > > > I'd be glad to queue the patch if we get a Reviewed-by line from > > somebody who understands Windows and WHPX. Maybe Justin? > > Can we wait for approval from the Microsoft legal department first? > So we can start testing WHPX builds, and reduce the possibilities to > introduce regressions. > > Testing is ready, we are waiting for Microsoft to merge, see: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg646351.html Making it easier for other people to test WHPX would be nice. But in case this is not sorted out soon, I don't see a reason to not merge WHPX changes if they are reviewed and approved by the main author of that code (Justin). -- Eduardo
Re: [PATCH] WHPX: refactor load library
On 11/12/19 8:47 PM, Eduardo Habkost wrote: On Tue, Nov 12, 2019 at 06:42:00PM +, Sunil Muthuswamy wrote: -Original Message- From: Sunil Muthuswamy Sent: Friday, November 8, 2019 12:32 PM To: 'Paolo Bonzini' ; 'Richard Henderson' ; 'Eduardo Habkost' ; 'Stefan Weil' Cc: 'qemu-devel@nongnu.org' ; Justin Terry (VM) Subject: [PATCH] WHPX: refactor load library This refactors the load library of WHV libraries to make it more modular. It makes a helper routine that can be called on demand. This allows future expansion of load library/functions to support functionality that is depenedent on some feature being available. Signed-off-by: Sunil Muthuswamy --- Can I possibly get some eyes on this? I'd be glad to queue the patch if we get a Reviewed-by line from somebody who understands Windows and WHPX. Maybe Justin? Can we wait for approval from the Microsoft legal department first? So we can start testing WHPX builds, and reduce the possibilities to introduce regressions. Testing is ready, we are waiting for Microsoft to merge, see: https://www.mail-archive.com/qemu-devel@nongnu.org/msg646351.html Sunil, Justin, would you like to be listed as maintainers or designated reviewers for the WHPX code in QEMU? Great idea!
Re: [PATCH] WHPX: refactor load library
On 08/11/19 21:31, Sunil Muthuswamy wrote:
>
> +typedef enum WHPFunctionList {
> +WINHV_PLATFORM_FNS_DEFAULT,
> +WINHV_EMULATION_FNS_DEFAULT,
> +} WHPFunctionList;
>
What does "default" stand for? I assume you have more changes to this
function in the future.
> + * Load the functions from the given library, using the given handle. If a
> + * handle is provided, it is used, otherwise the library is opened. The
> + * handle will be updated on return with the opened one.
> + */
> +static bool load_whp_dipatch_fns(HMODULE *handle, WHPFunctionList
> function_list)
> +{
Typo, "dipatch" instead of "dispatch".
>
> +if (hLib) {
> +FreeLibrary(hWinHvEmulation);
> +}
The argument to FreeLibrary should be hLib.
Paolo
Re: [PATCH] WHPX: refactor load library
On Tue, Nov 12, 2019 at 06:42:00PM +, Sunil Muthuswamy wrote: > > > > -Original Message- > > From: Sunil Muthuswamy > > Sent: Friday, November 8, 2019 12:32 PM > > To: 'Paolo Bonzini' ; 'Richard Henderson' > > ; 'Eduardo Habkost' ; 'Stefan > > Weil' > > Cc: 'qemu-devel@nongnu.org' ; Justin Terry (VM) > > > > Subject: [PATCH] WHPX: refactor load library > > > > This refactors the load library of WHV libraries to make it more > > modular. It makes a helper routine that can be called on demand. > > This allows future expansion of load library/functions to support > > functionality that is depenedent on some feature being available. > > > > Signed-off-by: Sunil Muthuswamy > > --- > > Can I possibly get some eyes on this? I'd be glad to queue the patch if we get a Reviewed-by line from somebody who understands Windows and WHPX. Maybe Justin? Sunil, Justin, would you like to be listed as maintainers or designated reviewers for the WHPX code in QEMU? -- Eduardo
RE: [PATCH] WHPX: refactor load library
> -Original Message- > From: Sunil Muthuswamy > Sent: Friday, November 8, 2019 12:32 PM > To: 'Paolo Bonzini' ; 'Richard Henderson' > ; 'Eduardo Habkost' ; 'Stefan > Weil' > Cc: 'qemu-devel@nongnu.org' ; Justin Terry (VM) > > Subject: [PATCH] WHPX: refactor load library > > This refactors the load library of WHV libraries to make it more > modular. It makes a helper routine that can be called on demand. > This allows future expansion of load library/functions to support > functionality that is depenedent on some feature being available. > > Signed-off-by: Sunil Muthuswamy > --- Can I possibly get some eyes on this?
