RE: [PATCH 12/20] Hexagon HVX (target/hexagon) helper functions

2021-07-25 Thread Taylor Simpson 


> -Original Message-
> From: Richard Henderson 
> Sent: Sunday, July 25, 2021 8:22 AM
> To: Taylor Simpson ; qemu-devel@nongnu.org
> Cc: phi...@redhat.com; a...@rev.ng; Brian Cain ;
> peter.mayd...@linaro.org
> Subject: Re: [PATCH 12/20] Hexagon HVX (target/hexagon) helper functions
> 
> On 7/5/21 1:34 PM, Taylor Simpson wrote:
> > +put_user_u8(env->vstore[i].data.ub[j], va + j);
> 
> No put_user.

Yes, there's also an include of qemu.h that I'll remove.

Re: [PATCH 12/20] Hexagon HVX (target/hexagon) helper functions

2021-07-25 Thread Richard Henderson 

On 7/5/21 1:34 PM, Taylor Simpson wrote:

+put_user_u8(env->vstore[i].data.ub[j], va + j);


No put_user.


r~