RE: [RFC PATCH v3 16/34] Hexagon (target/hexagon) utility functions

2020-08-26 Thread Taylor Simpson 


> -Original Message-
> From: Richard Henderson 
> Sent: Wednesday, August 26, 2020 9:11 AM
> To: Taylor Simpson ; qemu-devel@nongnu.org
> Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi;
> aleksandar.m.m...@gmail.com; a...@rev.ng
> Subject: Re: [RFC PATCH v3 16/34] Hexagon (target/hexagon) utility functions
>
> Did you really need to reinvent qemu/int128.h?

I remember looking at qemu/int128.h briefly but can't remember why I ended up 
not using it.  I'll take another look.

Re: [RFC PATCH v3 16/34] Hexagon (target/hexagon) utility functions

2020-08-26 Thread Richard Henderson 
On 8/18/20 8:50 AM, Taylor Simpson wrote:
> +extern size16s_t cast8s_to_16s(size8s_t a);
> +extern size8s_t cast16s_to_8s(size16s_t a);
> +extern size16s_t add128(size16s_t a, size16s_t b);
> +extern size16s_t sub128(size16s_t a, size16s_t b);
> +extern size16s_t shiftr128(size16s_t a, size4u_t n);
> +extern size16s_t shiftl128(size16s_t a, size4u_t n);
> +extern size16s_t and128(size16s_t a, size16s_t b);

Did you really need to reinvent qemu/int128.h?


r~