RE: [RFC PATCH v3 17/34] Hexagon (target/hexagon/imported) arch import - macro definitions

2020-08-26 Thread Taylor Simpson


> -Original Message-
> From: Richard Henderson 
> Sent: Wednesday, August 26, 2020 9:17 AM
> To: Taylor Simpson ; qemu-devel@nongnu.org
> Cc: phi...@redhat.com; laur...@vivier.eu; riku.voi...@iki.fi;
> aleksandar.m.m...@gmail.com; a...@rev.ng
> Subject: Re: [RFC PATCH v3 17/34] Hexagon (target/hexagon/imported) arch
> import - macro definitions
>
> You might as well squash all of the patches dealing with imported files,
> because they're beyond review.  They are what they are: another project's
> files.
>
> Give that squashed patch my
>
> Acked-by: Richard Henderson 

OK

> PS: I notice that the README mentions archlib, but does not give a pointer to
> it.

Other than what we import here, it's not open source.



Re: [RFC PATCH v3 17/34] Hexagon (target/hexagon/imported) arch import - macro definitions

2020-08-26 Thread Richard Henderson
On 8/18/20 8:50 AM, Taylor Simpson wrote:
> The macro definitions specify instruction attributes that are applied
> to each instruction that references the macro. The generator will
> recursively apply attributes to each instruction that used the macro.
> 
> Signed-off-by: Taylor Simpson 
> ---
>  target/hexagon/imported/macros.def | 1529 
> 
>  1 file changed, 1529 insertions(+)
>  create mode 100755 target/hexagon/imported/macros.def


You might as well squash all of the patches dealing with imported files,
because they're beyond review.  They are what they are: another project's files.

Give that squashed patch my

Acked-by: Richard Henderson 


r~


PS: I notice that the README mentions archlib, but does not give a pointer to 
it.