Re: [PATCH] Deprecate TileGX port
On Mon, 12 Oct 2020 at 16:42, BALATON Zoltan wrote: > > On Mon, 12 Oct 2020, Peter Maydell wrote: > > Deprecate our TileGX target support: > Is that 5.2? This mail was patch of an accidental mailbomb of the list with a couple of dozen stale (already sent weeks/months back) patches that were hanging around in a directory that I ran 'git send-email *.patch' on by mistake. Please ignore it, and sorry for the confusion :-( thanks -- PMM
Re: [PATCH] Deprecate TileGX port
On Mon, 12 Oct 2020, Peter Maydell wrote:
Deprecate our TileGX target support:
* we have no active maintainer for it
* it has had essentially no contributions (other than tree-wide cleanups
and similar) since it was first added
* the Linux kernel dropped support in 2018, as has glibc
Note the deprecation in the manual, but don't try to print a warning
when QEMU runs -- printing unsuppressable messages is more obtrusive
for linux-user mode than it would be for system-emulation mode, and
it doesn't seem worth trying to invent a new suppressible-error
system for linux-user just for this.
Signed-off-by: Peter Maydell
---
We discussed dropping this target last year:
https://patchew.org/QEMU/20191012071210.13632-1-phi...@redhat.com/
and before that in 2018, when Chen told us he didn't have time
to work on tilegx any more:
https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg03955.html
Given that tilegx is no longer in upstream Linux I think it makes sense
to finally deprecate-and-drop our linux-user support for it.
docs/system/deprecated.rst | 11 +++
1 file changed, 11 insertions(+)
diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
index 3a255591c34..e9097e089bb 100644
--- a/docs/system/deprecated.rst
+++ b/docs/system/deprecated.rst
@@ -387,6 +387,17 @@ The above, converted to the current supported format::
json:{"file.driver":"rbd", "file.pool":"rbd", "file.image":"name"}
+linux-user mode CPUs
+
+
+``tilegx`` CPUs (since 5.1.0)
+'
Is that 5.2?
Regards,
BALATON Zoltan
+
+The ``tilegx`` guest CPU support (which was only implemented in
+linux-user mode) is deprecated and will be removed in a future version
+of QEMU. Support for this CPU was removed from the upstream Linux
+kernel in 2018, and has also been dropped from glibc.
+
Related binaries
Re: [PATCH] Deprecate TileGX port
On 19/06/2020 17.48, Peter Maydell wrote:
> Deprecate our TileGX target support:
> * we have no active maintainer for it
> * it has had essentially no contributions (other than tree-wide cleanups
>and similar) since it was first added
> * the Linux kernel dropped support in 2018, as has glibc
>
> Note the deprecation in the manual, but don't try to print a warning
> when QEMU runs -- printing unsuppressable messages is more obtrusive
> for linux-user mode than it would be for system-emulation mode, and
> it doesn't seem worth trying to invent a new suppressible-error
> system for linux-user just for this.
I wonder whether anybody will notice the deprecation note in the manual
only, though. If we want to find out whether there are still any users
left, I think printing an unsuppressable message would be better... or
maybe something like:
if (!getenv("QEMU_SUPPRESS_TILEGX_DEPRECATION_WARNING")) {
fprintf(stderr, "Warning: TileGX CPU support is deprecated and "
"will be removed soon!\n"
"Set QEMU_SUPPRESS_TILEGX_DEPRECATION_WARNING "
"environment variable to hide this warning.");
}
?
> diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
> index 3a255591c34..e9097e089bb 100644
> --- a/docs/system/deprecated.rst
> +++ b/docs/system/deprecated.rst
> @@ -387,6 +387,17 @@ The above, converted to the current supported format::
>
>json:{"file.driver":"rbd", "file.pool":"rbd", "file.image":"name"}
>
> +linux-user mode CPUs
> +
> +
> +``tilegx`` CPUs (since 5.1.0)
> +'
> +
> +The ``tilegx`` guest CPU support (which was only implemented in
> +linux-user mode) is deprecated and will be removed in a future version
> +of QEMU. Support for this CPU was removed from the upstream Linux
> +kernel in 2018, and has also been dropped from glibc.
Reviewed-by: Thomas Huth
Re: [PATCH] Deprecate TileGX port
Patchew URL: https://patchew.org/QEMU/20200619154831.26319-1-peter.mayd...@linaro.org/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export ARCH=x86_64 make docker-image-fedora V=1 NETWORK=1 time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1 === TEST SCRIPT END === CC qga/commands-posix.o CC qga/channel-posix.o CC qga/qapi-generated/qga-qapi-types.o /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) CC qga/qapi-generated/qga-qapi-visit.o CC qga/qapi-generated/qga-qapi-commands.o CC qga/qapi-generated/qga-qapi-init-commands.o --- GEN docs/interop/qemu-ga-ref.html GEN docs/interop/qemu-ga-ref.7 GEN docs/interop/qemu-ga-ref.txt /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKqemu-keymap LINKivshmem-client /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKivshmem-server /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKqemu-nbd /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) AS pc-bios/optionrom/multiboot.o AS pc-bios/optionrom/linuxboot.o LINKqemu-storage-daemon /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) CC pc-bios/optionrom/linuxboot_dma.o AS pc-bios/optionrom/kvmvapic.o AS pc-bios/optionrom/pvh.o LINKqemu-img CC pc-bios/optionrom/pvh_main.o /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKqemu-io BUILD pc-bios/optionrom/multiboot.img BUILD pc-bios/optionrom/linuxboot.img BUILD pc-bios/optionrom/linuxboot_dma.img /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKqemu-edid BUILD pc-bios/optionrom/kvmvapic.img BUILD pc-bios/optionrom/multiboot.raw --- BUILD pc-bios/optionrom/kvmvapic.raw LINKfsdev/virtfs-proxy-helper SIGNpc-bios/optionrom/multiboot.bin /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) SIGNpc-bios/optionrom/linuxboot.bin SIGNpc-bios/optionrom/linuxboot_dma.bin SIGNpc-bios/optionrom/kvmvapic.bin LINKscsi/qemu-pr-helper LINKqemu-bridge-helper /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKvirtiofsd /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from
Re: [PATCH] Deprecate TileGX port
On 6/19/20 5:51 PM, Daniel P. Berrangé wrote: > On Fri, Jun 19, 2020 at 04:48:31PM +0100, Peter Maydell wrote: >> Deprecate our TileGX target support: >> * we have no active maintainer for it >> * it has had essentially no contributions (other than tree-wide cleanups >>and similar) since it was first added >> * the Linux kernel dropped support in 2018, as has glibc >> >> Note the deprecation in the manual, but don't try to print a warning >> when QEMU runs -- printing unsuppressable messages is more obtrusive >> for linux-user mode than it would be for system-emulation mode, and >> it doesn't seem worth trying to invent a new suppressible-error >> system for linux-user just for this. > > Potentially we could turn it off by default in configure, so it > requires an explicit --target-list to request it, but either way, > I don't mind. This is the approach I started 2 releases back... Having a DEPRECATED_TARGET environment variable, you add your target there and warnings are displayed. It resulted not that easy, and 2 releases passed... > >> >> Signed-off-by: Peter Maydell >> --- >> We discussed dropping this target last year: >> https://patchew.org/QEMU/20191012071210.13632-1-phi...@redhat.com/ >> and before that in 2018, when Chen told us he didn't have time >> to work on tilegx any more: >> https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg03955.html >> Given that tilegx is no longer in upstream Linux I think it makes sense >> to finally deprecate-and-drop our linux-user support for it. >> >> docs/system/deprecated.rst | 11 +++ >> 1 file changed, 11 insertions(+) > > Reviewed-by: Daniel P. Berrangé > > > Regards, > Daniel >
Re: [PATCH] Deprecate TileGX port
On 6/19/20 5:48 PM, Peter Maydell wrote:
> Deprecate our TileGX target support:
> * we have no active maintainer for it
> * it has had essentially no contributions (other than tree-wide cleanups
>and similar) since it was first added
> * the Linux kernel dropped support in 2018, as has glibc
>
> Note the deprecation in the manual, but don't try to print a warning
> when QEMU runs -- printing unsuppressable messages is more obtrusive
> for linux-user mode than it would be for system-emulation mode, and
> it doesn't seem worth trying to invent a new suppressible-error
> system for linux-user just for this.
>
> Signed-off-by: Peter Maydell
> ---
> We discussed dropping this target last year:
> https://patchew.org/QEMU/20191012071210.13632-1-phi...@redhat.com/
> and before that in 2018, when Chen told us he didn't have time
> to work on tilegx any more:
> https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg03955.html
> Given that tilegx is no longer in upstream Linux I think it makes sense
> to finally deprecate-and-drop our linux-user support for it.
>
> docs/system/deprecated.rst | 11 +++
> 1 file changed, 11 insertions(+)
>
> diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
> index 3a255591c34..e9097e089bb 100644
> --- a/docs/system/deprecated.rst
> +++ b/docs/system/deprecated.rst
> @@ -387,6 +387,17 @@ The above, converted to the current supported format::
>
>json:{"file.driver":"rbd", "file.pool":"rbd", "file.image":"name"}
>
> +linux-user mode CPUs
> +
> +
> +``tilegx`` CPUs (since 5.1.0)
> +'
> +
> +The ``tilegx`` guest CPU support (which was only implemented in
> +linux-user mode) is deprecated and will be removed in a future version
> +of QEMU. Support for this CPU was removed from the upstream Linux
> +kernel in 2018, and has also been dropped from glibc.
> +
> Related binaries
>
>
Thanks for writing this down, simple and effective!
Reviewed-by: Philippe Mathieu-Daudé
Re: [PATCH] Deprecate TileGX port
On Fri, Jun 19, 2020 at 04:48:31PM +0100, Peter Maydell wrote: > Deprecate our TileGX target support: > * we have no active maintainer for it > * it has had essentially no contributions (other than tree-wide cleanups >and similar) since it was first added > * the Linux kernel dropped support in 2018, as has glibc > > Note the deprecation in the manual, but don't try to print a warning > when QEMU runs -- printing unsuppressable messages is more obtrusive > for linux-user mode than it would be for system-emulation mode, and > it doesn't seem worth trying to invent a new suppressible-error > system for linux-user just for this. Potentially we could turn it off by default in configure, so it requires an explicit --target-list to request it, but either way, I don't mind. > > Signed-off-by: Peter Maydell > --- > We discussed dropping this target last year: > https://patchew.org/QEMU/20191012071210.13632-1-phi...@redhat.com/ > and before that in 2018, when Chen told us he didn't have time > to work on tilegx any more: > https://lists.gnu.org/archive/html/qemu-devel/2018-03/msg03955.html > Given that tilegx is no longer in upstream Linux I think it makes sense > to finally deprecate-and-drop our linux-user support for it. > > docs/system/deprecated.rst | 11 +++ > 1 file changed, 11 insertions(+) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
