Re: [PATCH] target/i386/kvm: Add missing fallthrough comment
Le 11/09/2020 à 14:53, Thomas Huth a écrit : > Let's make this file compilable with -Werror=implicit-fallthrough : > Looking at the code, it seems like the fallthrough is intended here, > so we should add the corresponding "/* fallthrough */" comment here. > > Signed-off-by: Thomas Huth > --- > target/i386/kvm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target/i386/kvm.c b/target/i386/kvm.c > index 205b68bc0c..283d3305d5 100644 > --- a/target/i386/kvm.c > +++ b/target/i386/kvm.c > @@ -1568,6 +1568,7 @@ int kvm_arch_init_vcpu(CPUState *cs) > if (env->nr_dies < 2) { > break; > } > +/* fallthrough */ > case 4: > case 0xb: > case 0xd: > Applied to my trivial-patches branch. Thanks, Laurent
Re: [PATCH] target/i386/kvm: Add missing fallthrough comment
Patchew URL: https://patchew.org/QEMU/20200911125301.413081-1-th...@redhat.com/ Hi, This series failed build test on FreeBSD host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit that has the patches applied on top of "base" # branch if qemu-system-x86_64 --help >/dev/null 2>&1; then QEMU=qemu-system-x86_64 elif /usr/libexec/qemu-kvm --help >/dev/null 2>&1; then QEMU=/usr/libexec/qemu-kvm else exit 1 fi make vm-build-freebsd J=21 QEMU=$QEMU exit 0 === TEST SCRIPT END === The full log is available at http://patchew.org/logs/20200911125301.413081-1-th...@redhat.com/testing.FreeBSD/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PATCH] target/i386/kvm: Add missing fallthrough comment
On 11/09/20 14:53, Thomas Huth wrote: > Let's make this file compilable with -Werror=implicit-fallthrough : > Looking at the code, it seems like the fallthrough is intended here, > so we should add the corresponding "/* fallthrough */" comment here. > > Signed-off-by: Thomas Huth > --- > target/i386/kvm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target/i386/kvm.c b/target/i386/kvm.c > index 205b68bc0c..283d3305d5 100644 > --- a/target/i386/kvm.c > +++ b/target/i386/kvm.c > @@ -1568,6 +1568,7 @@ int kvm_arch_init_vcpu(CPUState *cs) > if (env->nr_dies < 2) { > break; > } > +/* fallthrough */ > case 4: > case 0xb: > case 0xd: > Acked-by: Paolo Bonzini