Re: [PATCH] vfio/migration: Add helper function to set state or reset device
On 12/31/23 11:48, Avihai Horon wrote: There are several places where failure in setting the device state leads to a device reset, which is done by setting ERROR as the recover state. Add a helper function that sets the device state and resets the device in case of failure. This will make the code cleaner and remove duplicate comments. Signed-off-by: Avihai Horon Applied to vfio-next. Thanks, C.
Re: [PATCH] vfio/migration: Add helper function to set state or reset device
On 31/12/23 11:48, Avihai Horon wrote: There are several places where failure in setting the device state leads to a device reset, which is done by setting ERROR as the recover state. Add a helper function that sets the device state and resets the device in case of failure. This will make the code cleaner and remove duplicate comments. Signed-off-by: Avihai Horon --- hw/vfio/migration.c | 41 + 1 file changed, 17 insertions(+), 24 deletions(-) Reviewed-by: Philippe Mathieu-Daudé
Re: [PATCH] vfio/migration: Add helper function to set state or reset device
On 12/31/23 11:48, Avihai Horon wrote: There are several places where failure in setting the device state leads to a device reset, which is done by setting ERROR as the recover state. Add a helper function that sets the device state and resets the device in case of failure. This will make the code cleaner and remove duplicate comments. Signed-off-by: Avihai Horon Reviewed-by: Cédric Le Goater Thanks, C.
