Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements
Patchew URL:
https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1
=== TEST SCRIPT END ===
PASS 1 fdc-test /x86_64/fdc/cmos
PASS 2 fdc-test /x86_64/fdc/no_media_on_start
PASS 3 fdc-test /x86_64/fdc/read_without_media
==6120==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 4 fdc-test /x86_64/fdc/media_change
PASS 5 fdc-test /x86_64/fdc/sense_interrupt
PASS 6 fdc-test /x86_64/fdc/relative_seek
---
PASS 33 test-opts-visitor /visitor/opts/dict/unvisited
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
tests/test-coroutine -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="test-coroutine"
PASS 11 fdc-test /x86_64/fdc/read_no_dma_18
==6195==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 1 test-coroutine /basic/no-dangling-access
==6195==WARNING: ASan is ignoring requested __asan_handle_no_return: stack top:
0x7ffc61dec000; bottom 0x7f9a87484000; size: 0x0061da968000 (420279123968)
False positive error reports may follow
For details see https://github.com/google/sanitizers/issues/189
PASS 2 test-coroutine /basic/lifecycle
---
PASS 12 fdc-test /x86_64/fdc/read_no_dma_19
PASS 13 fdc-test /x86_64/fdc/fuzz-registers
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 QTEST_QEMU_IMG=qemu-img
tests/qtest/ide-test -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="ide-test"
==6210==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 14 test-aio /aio/timer/schedule
PASS 15 test-aio /aio/coroutine/queue-chaining
PASS 16 test-aio /aio-gsource/flush
---
PASS 25 test-aio /aio-gsource/event/wait
PASS 26 test-aio /aio-gsource/event/flush
PASS 27 test-aio /aio-gsource/event/wait/no-flush-cb
==6218==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 1 ide-test /x86_64/ide/identify
==6224==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 2 ide-test /x86_64/ide/flush
PASS 28 test-aio /aio-gsource/timer/schedule
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
tests/test-aio-multithread -m=quick -k --tap < /dev/null |
./scripts/tap-driver.pl --test-name="test-aio-multithread"
==6233==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 1 test-aio-multithread /aio/multi/lifecycle
==6230==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 3 ide-test /x86_64/ide/bmdma/simple_rw
PASS 2 test-aio-multithread /aio/multi/schedule
==6250==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 4 ide-test /x86_64/ide/bmdma/trim
==6261==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 3 test-aio-multithread /aio/multi/mutex/contended
PASS 4 test-aio-multithread /aio/multi/mutex/handoff
PASS 5 test-aio-multithread /aio/multi/mutex/mcs
PASS 6 test-aio-multithread /aio/multi/mutex/pthread
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
tests/test-throttle -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="test-throttle"
==6282==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
==6288==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 1 test-throttle /throttle/leak_bucket
PASS 2 test-throttle /throttle/compute_wait
PASS 3 test-throttle /throttle/init
---
PASS 14 test-throttle /throttle/config/max
PASS 15 test-throttle /throttle/config/iops_size
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
tests/test-thread-pool -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="test-thread-pool"
==6293==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 1 test-thread-pool /thread-pool/submit
PASS 2 test-thread-pool /thread-pool/submit-aio
PASS 3 test-thread-pool /thread-pool/submit-co
---
PASS 10 test-hbitmap /hbitmap/set/all
PASS 11 test-hbitmap /hbitmap/set/one
PASS 12 test-hbitmap /hbitmap/set/two-elem
==6364==WARNING: ASan
Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements
Patchew URL: https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements Message-id: 20200309235411.76587-1-liran.a...@oracle.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20200309235411.76587-1-liran.a...@oracle.com -> patchew/20200309235411.76587-1-liran.a...@oracle.com Switched to a new branch 'test' 3a9a905 hw/i386/vmport: Assert vmport initialized before registering commands a1e45e6 hw/i386/vmport: Add support for CMD_GETHZ 10e0ccf i386/cpu: Store LAPIC bus frequency in CPU structure b4b58a3 hw/i386/vmport: Allow x2apic without IR 04d32bb hw/i386/vmport: Add support for CMD_GET_VCPU_INFO 7925d7e hw/i386/vmport: Add support for CMD_GETTIMEFULL b919c87 hw/i386/vmport: Add support for CMD_GETTIME 87fe8e2 hw/i386/vmport: Add support for CMD_GETBIOSUUID 8cad96e hw/i386/vmport: Define enum for all commands e167453 hw/i386/vmport: Report VMX type in CMD_GETVERSION e70b2d1 hw/i386/vmport: Introduce vmx-version property 4c37f8b hw/i386/vmport: Add device properties 6aeb201 hw/i386/vmport: Set EAX to -1 on failed and unsupported commands 78864e8 hw/i386/vmport: Propagate IOPort read to vCPU EAX register === OUTPUT BEGIN === 1/14 Checking commit 78864e828d9a (hw/i386/vmport: Propagate IOPort read to vCPU EAX register) 2/14 Checking commit 6aeb2014d982 (hw/i386/vmport: Set EAX to -1 on failed and unsupported commands) 3/14 Checking commit 4c37f8b7fcc5 (hw/i386/vmport: Add device properties) 4/14 Checking commit e70b2d1864b7 (hw/i386/vmport: Introduce vmx-version property) 5/14 Checking commit e1674539df49 (hw/i386/vmport: Report VMX type in CMD_GETVERSION) 6/14 Checking commit 8cad96e6c606 (hw/i386/vmport: Define enum for all commands) 7/14 Checking commit 87fe8e21b595 (hw/i386/vmport: Add support for CMD_GETBIOSUUID) ERROR: "(foo*)" should be "(foo *)" #33: FILE: hw/i386/vmport.c:128: +uint32_t *uuid_parts = (uint32_t*)(qemu_uuid.data); total: 1 errors, 0 warnings, 39 lines checked Patch 7/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/14 Checking commit b919c87b2d71 (hw/i386/vmport: Add support for CMD_GETTIME) 9/14 Checking commit 7925d7e58bc7 (hw/i386/vmport: Add support for CMD_GETTIMEFULL) 10/14 Checking commit 04d32bb772b9 (hw/i386/vmport: Add support for CMD_GET_VCPU_INFO) ERROR: return is not a function, parentheses are not required #41: FILE: hw/i386/vmport.c:185: +return (1 << VCPU_INFO_RESERVED_BIT); total: 1 errors, 0 warnings, 38 lines checked Patch 10/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/14 Checking commit b4b58a3754a3 (hw/i386/vmport: Allow x2apic without IR) 12/14 Checking commit 10e0ccf9b53a (i386/cpu: Store LAPIC bus frequency in CPU structure) 13/14 Checking commit a1e45e66e18f (hw/i386/vmport: Add support for CMD_GETHZ) 14/14 Checking commit 3a9a9056d1b3 (hw/i386/vmport: Assert vmport initialized before registering commands) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200309235411.76587-1-liran.a...@oracle.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements
Patchew URL:
https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1
=== TEST SCRIPT END ===
PASS 1 fdc-test /x86_64/fdc/cmos
PASS 2 fdc-test /x86_64/fdc/no_media_on_start
PASS 3 fdc-test /x86_64/fdc/read_without_media
==6129==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 4 fdc-test /x86_64/fdc/media_change
PASS 5 fdc-test /x86_64/fdc/sense_interrupt
PASS 6 fdc-test /x86_64/fdc/relative_seek
---
PASS 32 test-opts-visitor /visitor/opts/range/beyond
PASS 33 test-opts-visitor /visitor/opts/dict/unvisited
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
tests/test-coroutine -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="test-coroutine"
==6193==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
==6193==WARNING: ASan is ignoring requested __asan_handle_no_return: stack top:
0x7ffc912f; bottom 0x7faa2358; size: 0x00526dd7 (354030125056)
False positive error reports may follow
For details see https://github.com/google/sanitizers/issues/189
PASS 1 test-coroutine /basic/no-dangling-access
---
PASS 11 test-aio /aio/event/wait
PASS 12 test-aio /aio/event/flush
PASS 13 test-aio /aio/event/wait/no-flush-cb
==6208==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 14 test-aio /aio/timer/schedule
PASS 15 test-aio /aio/coroutine/queue-chaining
PASS 16 test-aio /aio-gsource/flush
---
PASS 12 fdc-test /x86_64/fdc/read_no_dma_19
PASS 13 fdc-test /x86_64/fdc/fuzz-registers
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 QTEST_QEMU_IMG=qemu-img
tests/qtest/ide-test -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="ide-test"
==6216==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 28 test-aio /aio-gsource/timer/schedule
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
tests/test-aio-multithread -m=quick -k --tap < /dev/null |
./scripts/tap-driver.pl --test-name="test-aio-multithread"
PASS 1 ide-test /x86_64/ide/identify
==6223==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 1 test-aio-multithread /aio/multi/lifecycle
==6225==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 2 ide-test /x86_64/ide/flush
PASS 2 test-aio-multithread /aio/multi/schedule
==6242==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 3 ide-test /x86_64/ide/bmdma/simple_rw
==6253==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 4 ide-test /x86_64/ide/bmdma/trim
PASS 3 test-aio-multithread /aio/multi/mutex/contended
==6259==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 4 test-aio-multithread /aio/multi/mutex/handoff
PASS 5 test-aio-multithread /aio/multi/mutex/mcs
PASS 6 test-aio-multithread /aio/multi/mutex/pthread
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
tests/test-throttle -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="test-throttle"
==6281==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 1 test-throttle /throttle/leak_bucket
PASS 2 test-throttle /throttle/compute_wait
PASS 3 test-throttle /throttle/init
---
PASS 14 test-throttle /throttle/config/max
PASS 15 test-throttle /throttle/config/iops_size
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
tests/test-thread-pool -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="test-thread-pool"
==6285==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 1 test-thread-pool /thread-pool/submit
PASS 2 test-thread-pool /thread-pool/submit-aio
PASS 3 test-thread-pool /thread-pool/submit-co
PASS 4 test-thread-pool /thread-pool/submit-many
PASS 5 test-thread-pool /thread-pool/cancel
==6352==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 6 test-thread-pool /thread-pool/cancel-async
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 +
Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements
Patchew URL: https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements Message-id: 20200309235411.76587-1-liran.a...@oracle.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' e612415 hw/i386/vmport: Assert vmport initialized before registering commands 9aad846 hw/i386/vmport: Add support for CMD_GETHZ de3b721 i386/cpu: Store LAPIC bus frequency in CPU structure 25cba27 hw/i386/vmport: Allow x2apic without IR f779fc6 hw/i386/vmport: Add support for CMD_GET_VCPU_INFO 42ff7b9 hw/i386/vmport: Add support for CMD_GETTIMEFULL 1df74aa hw/i386/vmport: Add support for CMD_GETTIME bef18ba hw/i386/vmport: Add support for CMD_GETBIOSUUID 8d00a31 hw/i386/vmport: Define enum for all commands 59dd012 hw/i386/vmport: Report VMX type in CMD_GETVERSION 9d6dcf5 hw/i386/vmport: Introduce vmx-version property 83c777e hw/i386/vmport: Add device properties 76c35fd hw/i386/vmport: Set EAX to -1 on failed and unsupported commands 3415e5c hw/i386/vmport: Propagate IOPort read to vCPU EAX register === OUTPUT BEGIN === 1/14 Checking commit 3415e5c8f2bb (hw/i386/vmport: Propagate IOPort read to vCPU EAX register) 2/14 Checking commit 76c35fd191ac (hw/i386/vmport: Set EAX to -1 on failed and unsupported commands) 3/14 Checking commit 83c777e525f3 (hw/i386/vmport: Add device properties) 4/14 Checking commit 9d6dcf5f85dc (hw/i386/vmport: Introduce vmx-version property) 5/14 Checking commit 59dd012575b6 (hw/i386/vmport: Report VMX type in CMD_GETVERSION) 6/14 Checking commit 8d00a315ff15 (hw/i386/vmport: Define enum for all commands) 7/14 Checking commit bef18baf157e (hw/i386/vmport: Add support for CMD_GETBIOSUUID) ERROR: "(foo*)" should be "(foo *)" #33: FILE: hw/i386/vmport.c:128: +uint32_t *uuid_parts = (uint32_t*)(qemu_uuid.data); total: 1 errors, 0 warnings, 39 lines checked Patch 7/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/14 Checking commit 1df74aaccdd2 (hw/i386/vmport: Add support for CMD_GETTIME) 9/14 Checking commit 42ff7b94f787 (hw/i386/vmport: Add support for CMD_GETTIMEFULL) 10/14 Checking commit f779fc608aac (hw/i386/vmport: Add support for CMD_GET_VCPU_INFO) ERROR: return is not a function, parentheses are not required #41: FILE: hw/i386/vmport.c:185: +return (1 << VCPU_INFO_RESERVED_BIT); total: 1 errors, 0 warnings, 38 lines checked Patch 10/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/14 Checking commit 25cba27733da (hw/i386/vmport: Allow x2apic without IR) 12/14 Checking commit de3b7215948c (i386/cpu: Store LAPIC bus frequency in CPU structure) 13/14 Checking commit 9aad8462bcc2 (hw/i386/vmport: Add support for CMD_GETHZ) 14/14 Checking commit e612415198f4 (hw/i386/vmport: Assert vmport initialized before registering commands) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200309235411.76587-1-liran.a...@oracle.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements
Patchew URL:
https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1
=== TEST SCRIPT END ===
PASS 1 fdc-test /x86_64/fdc/cmos
PASS 2 fdc-test /x86_64/fdc/no_media_on_start
PASS 3 fdc-test /x86_64/fdc/read_without_media
==6149==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 1 test-clone-visitor /visitor/clone/struct
PASS 2 test-clone-visitor /visitor/clone/alternate
PASS 3 test-clone-visitor /visitor/clone/list_union
---
PASS 32 test-opts-visitor /visitor/opts/range/beyond
PASS 33 test-opts-visitor /visitor/opts/dict/unvisited
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
tests/test-coroutine -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="test-coroutine"
==6191==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
==6191==WARNING: ASan is ignoring requested __asan_handle_no_return: stack top:
0x7ffc33232000; bottom 0x7fb21c92; size: 0x004a16912000 (318206189568)
False positive error reports may follow
For details see https://github.com/google/sanitizers/issues/189
PASS 1 test-coroutine /basic/no-dangling-access
---
PASS 13 test-aio /aio/event/wait/no-flush-cb
PASS 11 fdc-test /x86_64/fdc/read_no_dma_18
PASS 14 test-aio /aio/timer/schedule
==6206==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 15 test-aio /aio/coroutine/queue-chaining
PASS 16 test-aio /aio-gsource/flush
PASS 17 test-aio /aio-gsource/bh/schedule
---
PASS 27 test-aio /aio-gsource/event/wait/no-flush-cb
PASS 28 test-aio /aio-gsource/timer/schedule
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
tests/test-aio-multithread -m=quick -k --tap < /dev/null |
./scripts/tap-driver.pl --test-name="test-aio-multithread"
==6211==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 1 test-aio-multithread /aio/multi/lifecycle
PASS 2 test-aio-multithread /aio/multi/schedule
PASS 12 fdc-test /x86_64/fdc/read_no_dma_19
PASS 13 fdc-test /x86_64/fdc/fuzz-registers
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 QTEST_QEMU_IMG=qemu-img
tests/qtest/ide-test -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="ide-test"
PASS 3 test-aio-multithread /aio/multi/mutex/contended
==6233==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 1 ide-test /x86_64/ide/identify
==6244==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 2 ide-test /x86_64/ide/flush
==6250==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 3 ide-test /x86_64/ide/bmdma/simple_rw
==6256==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 4 ide-test /x86_64/ide/bmdma/trim
==6262==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 4 test-aio-multithread /aio/multi/mutex/handoff
PASS 5 test-aio-multithread /aio/multi/mutex/mcs
PASS 6 test-aio-multithread /aio/multi/mutex/pthread
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
tests/test-throttle -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="test-throttle"
==6279==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 1 test-throttle /throttle/leak_bucket
PASS 2 test-throttle /throttle/compute_wait
PASS 3 test-throttle /throttle/init
---
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
tests/test-thread-pool -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="test-thread-pool"
PASS 1 test-thread-pool /thread-pool/submit
PASS 2 test-thread-pool /thread-pool/submit-aio
==6283==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 3 test-thread-pool /thread-pool/submit-co
PASS 4 test-thread-pool /thread-pool/submit-many
PASS 5 test-thread-pool /thread-pool/cancel
==6350==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 6 test-thread-pool /thread-pool/cancel-async
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} %
Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements
Patchew URL: https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements Message-id: 20200309235411.76587-1-liran.a...@oracle.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' df39962 hw/i386/vmport: Assert vmport initialized before registering commands 3e26c93 hw/i386/vmport: Add support for CMD_GETHZ 1104ba2 i386/cpu: Store LAPIC bus frequency in CPU structure a07269e hw/i386/vmport: Allow x2apic without IR 9cb233c hw/i386/vmport: Add support for CMD_GET_VCPU_INFO b2753ce hw/i386/vmport: Add support for CMD_GETTIMEFULL 8f1b2dd hw/i386/vmport: Add support for CMD_GETTIME e8bda24 hw/i386/vmport: Add support for CMD_GETBIOSUUID 3164756 hw/i386/vmport: Define enum for all commands 1936d4d hw/i386/vmport: Report VMX type in CMD_GETVERSION ae1085f hw/i386/vmport: Introduce vmx-version property a035d7a hw/i386/vmport: Add device properties 22e9fa5 hw/i386/vmport: Set EAX to -1 on failed and unsupported commands b6e0ed2 hw/i386/vmport: Propagate IOPort read to vCPU EAX register === OUTPUT BEGIN === 1/14 Checking commit b6e0ed2af9c7 (hw/i386/vmport: Propagate IOPort read to vCPU EAX register) 2/14 Checking commit 22e9fa57d34e (hw/i386/vmport: Set EAX to -1 on failed and unsupported commands) 3/14 Checking commit a035d7ae1b0c (hw/i386/vmport: Add device properties) 4/14 Checking commit ae1085ff7507 (hw/i386/vmport: Introduce vmx-version property) 5/14 Checking commit 1936d4d49f3f (hw/i386/vmport: Report VMX type in CMD_GETVERSION) 6/14 Checking commit 316475662bbc (hw/i386/vmport: Define enum for all commands) 7/14 Checking commit e8bda2444824 (hw/i386/vmport: Add support for CMD_GETBIOSUUID) ERROR: "(foo*)" should be "(foo *)" #33: FILE: hw/i386/vmport.c:128: +uint32_t *uuid_parts = (uint32_t*)(qemu_uuid.data); total: 1 errors, 0 warnings, 39 lines checked Patch 7/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/14 Checking commit 8f1b2ddcfe39 (hw/i386/vmport: Add support for CMD_GETTIME) 9/14 Checking commit b2753ce908ed (hw/i386/vmport: Add support for CMD_GETTIMEFULL) 10/14 Checking commit 9cb233c214ea (hw/i386/vmport: Add support for CMD_GET_VCPU_INFO) ERROR: return is not a function, parentheses are not required #41: FILE: hw/i386/vmport.c:185: +return (1 << VCPU_INFO_RESERVED_BIT); total: 1 errors, 0 warnings, 38 lines checked Patch 10/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/14 Checking commit a07269e3c600 (hw/i386/vmport: Allow x2apic without IR) 12/14 Checking commit 1104ba291496 (i386/cpu: Store LAPIC bus frequency in CPU structure) 13/14 Checking commit 3e26c9393aef (hw/i386/vmport: Add support for CMD_GETHZ) 14/14 Checking commit df39962e3458 (hw/i386/vmport: Assert vmport initialized before registering commands) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200309235411.76587-1-liran.a...@oracle.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements
Patchew URL: https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements Message-id: 20200309235411.76587-1-liran.a...@oracle.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' a905012 hw/i386/vmport: Assert vmport initialized before registering commands aad4359 hw/i386/vmport: Add support for CMD_GETHZ 3edb9da i386/cpu: Store LAPIC bus frequency in CPU structure b72a3e0 hw/i386/vmport: Allow x2apic without IR 7504676 hw/i386/vmport: Add support for CMD_GET_VCPU_INFO 79d0a3f hw/i386/vmport: Add support for CMD_GETTIMEFULL 0d6e6b1 hw/i386/vmport: Add support for CMD_GETTIME 805b514 hw/i386/vmport: Add support for CMD_GETBIOSUUID 8271871 hw/i386/vmport: Define enum for all commands 9266505 hw/i386/vmport: Report VMX type in CMD_GETVERSION 7e250cd hw/i386/vmport: Introduce vmx-version property b57af82 hw/i386/vmport: Add device properties db12fa9 hw/i386/vmport: Set EAX to -1 on failed and unsupported commands 8eab8de hw/i386/vmport: Propagate IOPort read to vCPU EAX register === OUTPUT BEGIN === 1/14 Checking commit 8eab8ded095b (hw/i386/vmport: Propagate IOPort read to vCPU EAX register) 2/14 Checking commit db12fa95ba3b (hw/i386/vmport: Set EAX to -1 on failed and unsupported commands) 3/14 Checking commit b57af82026fc (hw/i386/vmport: Add device properties) 4/14 Checking commit 7e250cdab468 (hw/i386/vmport: Introduce vmx-version property) 5/14 Checking commit 9266505822e8 (hw/i386/vmport: Report VMX type in CMD_GETVERSION) 6/14 Checking commit 82718710613d (hw/i386/vmport: Define enum for all commands) 7/14 Checking commit 805b5146d2ea (hw/i386/vmport: Add support for CMD_GETBIOSUUID) ERROR: "(foo*)" should be "(foo *)" #33: FILE: hw/i386/vmport.c:128: +uint32_t *uuid_parts = (uint32_t*)(qemu_uuid.data); total: 1 errors, 0 warnings, 39 lines checked Patch 7/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/14 Checking commit 0d6e6b1b6230 (hw/i386/vmport: Add support for CMD_GETTIME) 9/14 Checking commit 79d0a3f89d9c (hw/i386/vmport: Add support for CMD_GETTIMEFULL) 10/14 Checking commit 75046767a647 (hw/i386/vmport: Add support for CMD_GET_VCPU_INFO) ERROR: return is not a function, parentheses are not required #41: FILE: hw/i386/vmport.c:185: +return (1 << VCPU_INFO_RESERVED_BIT); total: 1 errors, 0 warnings, 38 lines checked Patch 10/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/14 Checking commit b72a3e03d26d (hw/i386/vmport: Allow x2apic without IR) 12/14 Checking commit 3edb9da71251 (i386/cpu: Store LAPIC bus frequency in CPU structure) 13/14 Checking commit aad435930bec (hw/i386/vmport: Add support for CMD_GETHZ) 14/14 Checking commit a9050129b333 (hw/i386/vmport: Assert vmport initialized before registering commands) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200309235411.76587-1-liran.a...@oracle.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements
On 10/03/2020 2:54, no-re...@patchew.org wrote:
Patchew URL:
https://urldefense.com/v3/__https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/__;!!GqivPVa7Brio!N5car8IBDE_QFIGGfZAaPfF3gc3sv_CIDltJvgI8K5bvOLgPcGxKnVicygP6jf4$
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
These failures doesn't seem to relate to the patch-series I have
submitted...
The test seems to be broken.
-Liran
=== TEST SCRIPT BEGIN ===
#!/bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1
=== TEST SCRIPT END ===
PASS 1 fdc-test /x86_64/fdc/cmos
PASS 2 fdc-test /x86_64/fdc/no_media_on_start
PASS 3 fdc-test /x86_64/fdc/read_without_media
==6572==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 4 fdc-test /x86_64/fdc/media_change
PASS 5 fdc-test /x86_64/fdc/sense_interrupt
PASS 6 fdc-test /x86_64/fdc/relative_seek
---
PASS 32 test-opts-visitor /visitor/opts/range/beyond
PASS 33 test-opts-visitor /visitor/opts/dict/unvisited
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-coroutine
-m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="test-coroutine"
==6620==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
==6620==WARNING: ASan is ignoring requested __asan_handle_no_return: stack top:
0x7ffd8e97f000; bottom 0x7fc55e2d3000; size: 0x0038306ac000 (241330470912)
False positive error reports may follow
For details see
https://urldefense.com/v3/__https://github.com/google/sanitizers/issues/189__;!!GqivPVa7Brio!N5car8IBDE_QFIGGfZAaPfF3gc3sv_CIDltJvgI8K5bvOLgPcGxKnViceiqsExY$
PASS 1 test-coroutine /basic/no-dangling-access
---
PASS 12 test-aio /aio/event/flush
PASS 13 test-aio /aio/event/wait/no-flush-cb
PASS 14 test-aio /aio/timer/schedule
==6635==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 15 test-aio /aio/coroutine/queue-chaining
PASS 16 test-aio /aio-gsource/flush
PASS 17 test-aio /aio-gsource/bh/schedule
---
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 QTEST_QEMU_IMG=qemu-img
tests/qtest/ide-test -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="ide-test"
PASS 28 test-aio /aio-gsource/timer/schedule
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-aio-multithread
-m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="test-aio-multithread"
==6646==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 1 test-aio-multithread /aio/multi/lifecycle
==6643==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 1 ide-test /x86_64/ide/identify
==6663==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 2 test-aio-multithread /aio/multi/schedule
PASS 2 ide-test /x86_64/ide/flush
==6674==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 3 ide-test /x86_64/ide/bmdma/simple_rw
PASS 3 test-aio-multithread /aio/multi/mutex/contended
==6680==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 4 ide-test /x86_64/ide/bmdma/trim
==6691==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 4 test-aio-multithread /aio/multi/mutex/handoff
PASS 5 test-aio-multithread /aio/multi/mutex/mcs
PASS 6 test-aio-multithread /aio/multi/mutex/pthread
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-throttle
-m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="test-throttle"
==6708==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 1 test-throttle /throttle/leak_bucket
PASS 2 test-throttle /throttle/compute_wait
PASS 3 test-throttle /throttle/init
---
PASS 14 test-throttle /throttle/config/max
PASS 15 test-throttle /throttle/config/iops_size
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))} tests/test-thread-pool
-m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="test-thread-pool"
==6712==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 1 test-thread-pool /thread-pool/submit
PASS 2 test-thread-pool /thread-pool/submit-aio
PASS 3 test-thread-pool /thread-pool/submit-co
PASS 4
Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements
Patchew URL:
https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/
Hi,
This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1
=== TEST SCRIPT END ===
PASS 1 fdc-test /x86_64/fdc/cmos
PASS 2 fdc-test /x86_64/fdc/no_media_on_start
PASS 3 fdc-test /x86_64/fdc/read_without_media
==6572==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 4 fdc-test /x86_64/fdc/media_change
PASS 5 fdc-test /x86_64/fdc/sense_interrupt
PASS 6 fdc-test /x86_64/fdc/relative_seek
---
PASS 32 test-opts-visitor /visitor/opts/range/beyond
PASS 33 test-opts-visitor /visitor/opts/dict/unvisited
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
tests/test-coroutine -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="test-coroutine"
==6620==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
==6620==WARNING: ASan is ignoring requested __asan_handle_no_return: stack top:
0x7ffd8e97f000; bottom 0x7fc55e2d3000; size: 0x0038306ac000 (241330470912)
False positive error reports may follow
For details see https://github.com/google/sanitizers/issues/189
PASS 1 test-coroutine /basic/no-dangling-access
---
PASS 12 test-aio /aio/event/flush
PASS 13 test-aio /aio/event/wait/no-flush-cb
PASS 14 test-aio /aio/timer/schedule
==6635==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 15 test-aio /aio/coroutine/queue-chaining
PASS 16 test-aio /aio-gsource/flush
PASS 17 test-aio /aio-gsource/bh/schedule
---
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 QTEST_QEMU_IMG=qemu-img
tests/qtest/ide-test -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="ide-test"
PASS 28 test-aio /aio-gsource/timer/schedule
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
tests/test-aio-multithread -m=quick -k --tap < /dev/null |
./scripts/tap-driver.pl --test-name="test-aio-multithread"
==6646==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 1 test-aio-multithread /aio/multi/lifecycle
==6643==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 1 ide-test /x86_64/ide/identify
==6663==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 2 test-aio-multithread /aio/multi/schedule
PASS 2 ide-test /x86_64/ide/flush
==6674==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 3 ide-test /x86_64/ide/bmdma/simple_rw
PASS 3 test-aio-multithread /aio/multi/mutex/contended
==6680==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 4 ide-test /x86_64/ide/bmdma/trim
==6691==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 4 test-aio-multithread /aio/multi/mutex/handoff
PASS 5 test-aio-multithread /aio/multi/mutex/mcs
PASS 6 test-aio-multithread /aio/multi/mutex/pthread
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
tests/test-throttle -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="test-throttle"
==6708==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 1 test-throttle /throttle/leak_bucket
PASS 2 test-throttle /throttle/compute_wait
PASS 3 test-throttle /throttle/init
---
PASS 14 test-throttle /throttle/config/max
PASS 15 test-throttle /throttle/config/iops_size
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
tests/test-thread-pool -m=quick -k --tap < /dev/null | ./scripts/tap-driver.pl
--test-name="test-thread-pool"
==6712==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 1 test-thread-pool /thread-pool/submit
PASS 2 test-thread-pool /thread-pool/submit-aio
PASS 3 test-thread-pool /thread-pool/submit-co
PASS 4 test-thread-pool /thread-pool/submit-many
==6779==WARNING: ASan doesn't fully support makecontext/swapcontext functions
and may produce false positives in some cases!
PASS 5 test-thread-pool /thread-pool/cancel
PASS 6 test-thread-pool /thread-pool/cancel-async
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
tests/test-hbitmap -m=quick -k --tap < /dev/null |
Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements
Patchew URL: https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements Message-id: 20200309235411.76587-1-liran.a...@oracle.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 9a5eea3 hw/i386/vmport: Assert vmport initialized before registering commands 1e6dd04 hw/i386/vmport: Add support for CMD_GETHZ 0ac0d03 i386/cpu: Store LAPIC bus frequency in CPU structure a7c67f7 hw/i386/vmport: Allow x2apic without IR 45a8906 hw/i386/vmport: Add support for CMD_GET_VCPU_INFO b2e5182 hw/i386/vmport: Add support for CMD_GETTIMEFULL 781c578 hw/i386/vmport: Add support for CMD_GETTIME b9766e1 hw/i386/vmport: Add support for CMD_GETBIOSUUID 45d84ea hw/i386/vmport: Define enum for all commands 4fd0f2a hw/i386/vmport: Report VMX type in CMD_GETVERSION fb9a37d hw/i386/vmport: Introduce vmx-version property 42c9b1b hw/i386/vmport: Add device properties ef80fe3 hw/i386/vmport: Set EAX to -1 on failed and unsupported commands 4f4c376 hw/i386/vmport: Propagate IOPort read to vCPU EAX register === OUTPUT BEGIN === 1/14 Checking commit 4f4c3766dab8 (hw/i386/vmport: Propagate IOPort read to vCPU EAX register) 2/14 Checking commit ef80fe384f2a (hw/i386/vmport: Set EAX to -1 on failed and unsupported commands) 3/14 Checking commit 42c9b1bcba22 (hw/i386/vmport: Add device properties) 4/14 Checking commit fb9a37d94ae8 (hw/i386/vmport: Introduce vmx-version property) 5/14 Checking commit 4fd0f2a4fbd8 (hw/i386/vmport: Report VMX type in CMD_GETVERSION) 6/14 Checking commit 45d84eaad9b8 (hw/i386/vmport: Define enum for all commands) 7/14 Checking commit b9766e1d7b89 (hw/i386/vmport: Add support for CMD_GETBIOSUUID) ERROR: "(foo*)" should be "(foo *)" #33: FILE: hw/i386/vmport.c:128: +uint32_t *uuid_parts = (uint32_t*)(qemu_uuid.data); total: 1 errors, 0 warnings, 39 lines checked Patch 7/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/14 Checking commit 781c5786106a (hw/i386/vmport: Add support for CMD_GETTIME) 9/14 Checking commit b2e51824129e (hw/i386/vmport: Add support for CMD_GETTIMEFULL) 10/14 Checking commit 45a8906700f6 (hw/i386/vmport: Add support for CMD_GET_VCPU_INFO) ERROR: return is not a function, parentheses are not required #41: FILE: hw/i386/vmport.c:185: +return (1 << VCPU_INFO_RESERVED_BIT); total: 1 errors, 0 warnings, 38 lines checked Patch 10/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/14 Checking commit a7c67f736cd1 (hw/i386/vmport: Allow x2apic without IR) 12/14 Checking commit 0ac0d0363873 (i386/cpu: Store LAPIC bus frequency in CPU structure) 13/14 Checking commit 1e6dd042d2a2 (hw/i386/vmport: Add support for CMD_GETHZ) 14/14 Checking commit 9a5eea388576 (hw/i386/vmport: Assert vmport initialized before registering commands) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200309235411.76587-1-liran.a...@oracle.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements
On 10/03/2020 2:13, no-re...@patchew.org wrote: Patchew URL: https://urldefense.com/v3/__https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/__;!!GqivPVa7Brio!IXfneuptZ4caQyQEEgsIN74dLYkkLHJ8XSqL2iGyrzODUx_Jt8Vk-eKN_QQftVU$ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements Message-id: 20200309235411.76587-1-liran.a...@oracle.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' ec54414 hw/i386/vmport: Assert vmport initialized before registering commands 77ea4ed hw/i386/vmport: Add support for CMD_GETHZ b1ed920 i386/cpu: Store LAPIC bus frequency in CPU structure 62d770f hw/i386/vmport: Allow x2apic without IR 5c97d52 hw/i386/vmport: Add support for CMD_GET_VCPU_INFO e4a716d hw/i386/vmport: Add support for CMD_GETTIMEFULL febcb47 hw/i386/vmport: Add support for CMD_GETTIME 25890df hw/i386/vmport: Add support for CMD_GETBIOSUUID 9e6211d hw/i386/vmport: Define enum for all commands fc5f5ec hw/i386/vmport: Report VMX type in CMD_GETVERSION f284754 hw/i386/vmport: Introduce vmx-version property 114bf59 hw/i386/vmport: Add device properties 8acf5a2 hw/i386/vmport: Set EAX to -1 on failed and unsupported commands 97c3de7 hw/i386/vmport: Propagate IOPort read to vCPU EAX register === OUTPUT BEGIN === 1/14 Checking commit 97c3de7b1b98 (hw/i386/vmport: Propagate IOPort read to vCPU EAX register) 2/14 Checking commit 8acf5a2b7630 (hw/i386/vmport: Set EAX to -1 on failed and unsupported commands) 3/14 Checking commit 114bf59021b3 (hw/i386/vmport: Add device properties) 4/14 Checking commit f284754e01a3 (hw/i386/vmport: Introduce vmx-version property) 5/14 Checking commit fc5f5ec6f72f (hw/i386/vmport: Report VMX type in CMD_GETVERSION) 6/14 Checking commit 9e6211d4df01 (hw/i386/vmport: Define enum for all commands) 7/14 Checking commit 25890df0767b (hw/i386/vmport: Add support for CMD_GETBIOSUUID) ERROR: "(foo*)" should be "(foo *)" #33: FILE: hw/i386/vmport.c:128: +uint32_t *uuid_parts = (uint32_t*)(qemu_uuid.data); total: 1 errors, 0 warnings, 39 lines checked Patch 7/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/14 Checking commit febcb4730cb2 (hw/i386/vmport: Add support for CMD_GETTIME) 9/14 Checking commit e4a716de3f06 (hw/i386/vmport: Add support for CMD_GETTIMEFULL) 10/14 Checking commit 5c97d52c360a (hw/i386/vmport: Add support for CMD_GET_VCPU_INFO) ERROR: return is not a function, parentheses are not required #41: FILE: hw/i386/vmport.c:185: +return (1 << VCPU_INFO_RESERVED_BIT); total: 1 errors, 0 warnings, 38 lines checked Patch 10/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/14 Checking commit 62d770f375b6 (hw/i386/vmport: Allow x2apic without IR) 12/14 Checking commit b1ed920b0bf3 (i386/cpu: Store LAPIC bus frequency in CPU structure) 13/14 Checking commit 77ea4ed42420 (hw/i386/vmport: Add support for CMD_GETHZ) 14/14 Checking commit ec54414bea14 (hw/i386/vmport: Assert vmport initialized before registering commands) === OUTPUT END === Test command exited with code: 1 Arr... Will fix these minor coding-conventions after the patches are reviewed so I will take all into account in v2. -Liran
Re: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements
Patchew URL: https://patchew.org/QEMU/20200309235411.76587-1-liran.a...@oracle.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 00/14]: hw/i386/vmport: Bug fixes and improvements Message-id: 20200309235411.76587-1-liran.a...@oracle.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' ec54414 hw/i386/vmport: Assert vmport initialized before registering commands 77ea4ed hw/i386/vmport: Add support for CMD_GETHZ b1ed920 i386/cpu: Store LAPIC bus frequency in CPU structure 62d770f hw/i386/vmport: Allow x2apic without IR 5c97d52 hw/i386/vmport: Add support for CMD_GET_VCPU_INFO e4a716d hw/i386/vmport: Add support for CMD_GETTIMEFULL febcb47 hw/i386/vmport: Add support for CMD_GETTIME 25890df hw/i386/vmport: Add support for CMD_GETBIOSUUID 9e6211d hw/i386/vmport: Define enum for all commands fc5f5ec hw/i386/vmport: Report VMX type in CMD_GETVERSION f284754 hw/i386/vmport: Introduce vmx-version property 114bf59 hw/i386/vmport: Add device properties 8acf5a2 hw/i386/vmport: Set EAX to -1 on failed and unsupported commands 97c3de7 hw/i386/vmport: Propagate IOPort read to vCPU EAX register === OUTPUT BEGIN === 1/14 Checking commit 97c3de7b1b98 (hw/i386/vmport: Propagate IOPort read to vCPU EAX register) 2/14 Checking commit 8acf5a2b7630 (hw/i386/vmport: Set EAX to -1 on failed and unsupported commands) 3/14 Checking commit 114bf59021b3 (hw/i386/vmport: Add device properties) 4/14 Checking commit f284754e01a3 (hw/i386/vmport: Introduce vmx-version property) 5/14 Checking commit fc5f5ec6f72f (hw/i386/vmport: Report VMX type in CMD_GETVERSION) 6/14 Checking commit 9e6211d4df01 (hw/i386/vmport: Define enum for all commands) 7/14 Checking commit 25890df0767b (hw/i386/vmport: Add support for CMD_GETBIOSUUID) ERROR: "(foo*)" should be "(foo *)" #33: FILE: hw/i386/vmport.c:128: +uint32_t *uuid_parts = (uint32_t*)(qemu_uuid.data); total: 1 errors, 0 warnings, 39 lines checked Patch 7/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/14 Checking commit febcb4730cb2 (hw/i386/vmport: Add support for CMD_GETTIME) 9/14 Checking commit e4a716de3f06 (hw/i386/vmport: Add support for CMD_GETTIMEFULL) 10/14 Checking commit 5c97d52c360a (hw/i386/vmport: Add support for CMD_GET_VCPU_INFO) ERROR: return is not a function, parentheses are not required #41: FILE: hw/i386/vmport.c:185: +return (1 << VCPU_INFO_RESERVED_BIT); total: 1 errors, 0 warnings, 38 lines checked Patch 10/14 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/14 Checking commit 62d770f375b6 (hw/i386/vmport: Allow x2apic without IR) 12/14 Checking commit b1ed920b0bf3 (i386/cpu: Store LAPIC bus frequency in CPU structure) 13/14 Checking commit 77ea4ed42420 (hw/i386/vmport: Add support for CMD_GETHZ) 14/14 Checking commit ec54414bea14 (hw/i386/vmport: Assert vmport initialized before registering commands) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200309235411.76587-1-liran.a...@oracle.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
