Re: [PATCH 00/16] Various error handling fixes and cleanups

2021-07-29 Thread Markus Armbruster
Markus Armbruster  writes:

> I doubt the fixes are 6.1 material at this late stage.  If you
> disagree, let me know.

PATCH 16 has become commit 3e61a13af3.  Remainder queued for 6.2;
additional review is welcome all the same.

Thanks, guys!




Re: [PATCH 00/16] Various error handling fixes and cleanups

2021-07-23 Thread Michael S. Tsirkin
On Tue, Jul 20, 2021 at 02:53:52PM +0200, Markus Armbruster wrote:
> I doubt the fixes are 6.1 material at this late stage.  If you
> disagree, let me know.
> 
> Cc: Alex Williamson 
> Cc: Aravinda Prasad 
> Cc: Cornelia Huck 
> Cc: Daniel P. Berrangé 
> Cc: David Gibson 
> Cc: Dr. David Alan Gilbert 
> Cc: Eduardo Habkost 
> Cc: Elena Ufimtseva 
> Cc: Ganesh Goudar 
> Cc: Gerd Hoffmann 
> Cc: Jagannathan Raman 
> Cc: John G Johnson 
> Cc: Juan Quintela 
> Cc: Kamil Rytarowski 
> Cc: Kevin Wolf 
> Cc: Kirti Wankhede 
> Cc: Marc-André Lureau 
> Cc: Marcelo Tosatti 
> Cc: Michael S. Tsirkin 
> Cc: Paolo Bonzini 
> Cc: Peter Xu 
> Cc: Reinoud Zandijk 
> Cc: Sergio Lopez 
> Cc: Stefan Hajnoczi 
> Cc: Sunil Muthuswamy 
> Cc: Thomas Huth 


Acked-by: Michael S. Tsirkin 

agree it's not 6.1 material

> Markus Armbruster (16):
>   error: Use error_fatal to simplify obvious fatal errors (again)
>   spapr: Plug memory leak when we can't add a migration blocker
>   spapr: Explain purpose of ->fwnmi_migration_blocker more clearly
>   multi-process: Fix pci_proxy_dev_realize() error handling
>   vhost-scsi: Plug memory leak on migrate_add_blocker() failure
>   i386: Never free migration blocker objects instead of sometimes
>   vfio: Avoid error_propagate() after migrate_add_blocker()
>   whpx nvmm: Drop useless migrate_del_blocker()
>   migration: Unify failure check for migrate_add_blocker()
>   migration: Handle migration_incoming_setup() errors consistently
>   microvm: Drop dead error handling in microvm_machine_state_init()
>   vhost: Clean up how VhostOpts method vhost_get_config() fails
>   vhost: Clean up how VhostOpts method vhost_backend_init() fails
>   Remove superfluous ERRP_GUARD()
>   vl: Clean up -smp error handling
>   vl: Don't continue after -smp help.
> 
>  backends/tpm/tpm_emulator.c |  3 +--
>  hw/display/qxl.c|  8 
>  hw/i386/microvm.c   |  5 -
>  hw/ppc/spapr_events.c   | 20 ++--
>  hw/remote/mpqemu-link.c |  3 ---
>  hw/remote/proxy.c   | 10 +-
>  hw/s390x/ipl.c  |  6 +-
>  hw/scsi/vhost-scsi.c|  4 ++--
>  hw/vfio/migration.c |  6 ++
>  hw/virtio/vhost-user.c  |  8 
>  hw/virtio/vhost.c   | 16 +++-
>  migration/migration.c   | 34 ++
>  qemu-img.c  |  6 +-
>  qemu-io.c   |  6 +-
>  qemu-nbd.c  |  5 +
>  qga/commands-posix-ssh.c| 17 -
>  qga/commands-win32.c|  1 -
>  scsi/qemu-pr-helper.c   | 11 +++
>  softmmu/vl.c| 19 +++
>  target/i386/kvm/kvm.c   |  9 +++--
>  target/i386/nvmm/nvmm-all.c |  4 +---
>  target/i386/sev.c   |  8 +---
>  target/i386/whpx/whpx-all.c |  4 +---
>  ui/console.c|  7 ++-
>  ui/spice-core.c |  7 +--
>  25 files changed, 72 insertions(+), 155 deletions(-)
> 
> -- 
> 2.31.1