Re: [PATCH 1/1] gitlab-ci: Add KVM x86 cross-build jobs

2021-05-11 Thread Philippe Mathieu-Daudé
On 5/12/21 6:57 AM, Thomas Huth wrote:
> On 12/05/2021 06.42, Philippe Mathieu-Daudé wrote:
>> Add a new job to cross-build the x86 target without the
>> TCG/XEN accelerators (IOW: only KVM accelerator enabled).
>>
>> Signed-off-by: Philippe Mathieu-Daudé 
>> ---
>>   .gitlab-ci.d/crossbuilds.yml | 8 
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml
>> index e44e4b49a25..a8eac2cddba 100644
>> --- a/.gitlab-ci.d/crossbuilds.yml
>> +++ b/.gitlab-ci.d/crossbuilds.yml
>> @@ -198,6 +198,14 @@ cross-win64-system:
>>     variables:
>>   IMAGE: fedora-win64-cross
>>   +cross-i386-kvm-only:
>> +  extends: .cross_accel_build_job
>> +  needs:
>> +    job: i386-fedora-cross-container
>> +  variables:
>> +    IMAGE: fedora-i386-cross
>> +    ACCEL_CONFIGURE_OPTS: --disable-tcg --disable-xen
> 
> We already have build-tcg-disabled in the main .gitlab-ci.yml file ...
> so I fail to see what additional test coverage we get by this job?

Doh I missed build-tcg-disabled was the x86 job, sorry.

Please disregard this patch!




Re: [PATCH 1/1] gitlab-ci: Add KVM x86 cross-build jobs

2021-05-11 Thread Thomas Huth

On 12/05/2021 06.42, Philippe Mathieu-Daudé wrote:

Add a new job to cross-build the x86 target without the
TCG/XEN accelerators (IOW: only KVM accelerator enabled).

Signed-off-by: Philippe Mathieu-Daudé 
---
  .gitlab-ci.d/crossbuilds.yml | 8 
  1 file changed, 8 insertions(+)

diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml
index e44e4b49a25..a8eac2cddba 100644
--- a/.gitlab-ci.d/crossbuilds.yml
+++ b/.gitlab-ci.d/crossbuilds.yml
@@ -198,6 +198,14 @@ cross-win64-system:
variables:
  IMAGE: fedora-win64-cross
  
+cross-i386-kvm-only:

+  extends: .cross_accel_build_job
+  needs:
+job: i386-fedora-cross-container
+  variables:
+IMAGE: fedora-i386-cross
+ACCEL_CONFIGURE_OPTS: --disable-tcg --disable-xen


We already have build-tcg-disabled in the main .gitlab-ci.yml file ... so I 
fail to see what additional test coverage we get by this job?


 Thomas