Re: [PATCH 11/16] microvm: Drop dead error handling in microvm_machine_state_init()

2021-07-20 Thread Pankaj Gupta 
> Stillborn in commit 0ebf007dda "hw/i386: Introduce the microvm machine
> type".
>
> Cc: Sergio Lopez 
> Signed-off-by: Markus Armbruster 
> ---
>  hw/i386/microvm.c | 5 -
>  1 file changed, 5 deletions(-)
>
> diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c
> index aba0c83219..f257ec5a0b 100644
> --- a/hw/i386/microvm.c
> +++ b/hw/i386/microvm.c
> @@ -458,15 +458,10 @@ static void microvm_machine_state_init(MachineState 
> *machine)
>  {
>  MicrovmMachineState *mms = MICROVM_MACHINE(machine);
>  X86MachineState *x86ms = X86_MACHINE(machine);
> -Error *local_err = NULL;
>
>  microvm_memory_init(mms);
>
>  x86_cpus_init(x86ms, CPU_VERSION_LATEST);
> -if (local_err) {
> -error_report_err(local_err);
> -exit(1);
> -}
>
>  microvm_devices_init(mms);
>  }
> --
> 2.31.1

Reviewed-by: Pankaj Gupta

Re: [PATCH 11/16] microvm: Drop dead error handling in microvm_machine_state_init()

2021-07-20 Thread Philippe Mathieu-Daudé 
On 7/20/21 2:54 PM, Markus Armbruster wrote:
> Stillborn in commit 0ebf007dda "hw/i386: Introduce the microvm machine
> type".
> 
> Cc: Sergio Lopez 
> Signed-off-by: Markus Armbruster 
> ---
>  hw/i386/microvm.c | 5 -
>  1 file changed, 5 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 11/16] microvm: Drop dead error handling in microvm_machine_state_init()

2021-07-20 Thread Sergio Lopez 
On Tue, Jul 20, 2021 at 02:54:03PM +0200, Markus Armbruster wrote:
> Stillborn in commit 0ebf007dda "hw/i386: Introduce the microvm machine
> type".
> 
> Cc: Sergio Lopez 
> Signed-off-by: Markus Armbruster 
> ---
>  hw/i386/microvm.c | 5 -
>  1 file changed, 5 deletions(-)
> 
> diff --git a/hw/i386/microvm.c b/hw/i386/microvm.c
> index aba0c83219..f257ec5a0b 100644
> --- a/hw/i386/microvm.c
> +++ b/hw/i386/microvm.c
> @@ -458,15 +458,10 @@ static void microvm_machine_state_init(MachineState 
> *machine)
>  {
>  MicrovmMachineState *mms = MICROVM_MACHINE(machine);
>  X86MachineState *x86ms = X86_MACHINE(machine);
> -Error *local_err = NULL;
>  
>  microvm_memory_init(mms);
>  
>  x86_cpus_init(x86ms, CPU_VERSION_LATEST);
> -if (local_err) {
> -error_report_err(local_err);
> -exit(1);
> -}
>  
>  microvm_devices_init(mms);
>  }
> -- 
> 2.31.1
> 

Reviewed-by: Sergio Lopez 


signature.asc
Description: PGP signature