On 9/21/22 09:08, Alex Bennée wrote:
The purpose of the matches was to only track the execution of
instructions we care about. Without resetting skip to the value at the
start of the block we end up dumping all instructions after the match
with the consequent load on the instrumentation.
Signed-off-by: Alex Bennée
Cc: Alexandre Iooss
---
contrib/plugins/execlog.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/contrib/plugins/execlog.c b/contrib/plugins/execlog.c
index e659ac9cbb..b5360f2c8e 100644
--- a/contrib/plugins/execlog.c
+++ b/contrib/plugins/execlog.c
@@ -147,6 +147,9 @@ static void vcpu_tb_trans(qemu_plugin_id_t id, struct
qemu_plugin_tb *tb)
/* Register callback on instruction */
qemu_plugin_register_vcpu_insn_exec_cb(insn, vcpu_insn_exec,
QEMU_PLUGIN_CB_NO_REGS,
output);
+
+/* reset skip */
+skip = (imatches || amatches) ? true : false;
Drop the redundant ?:. Otherwise,
Reviewed-by: Richard Henderson
r~
